kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
notebooks/components/notebook-controller/config
History
Samu 0215857aa9 Support K8s 1.22 in notebook controller (kubeflow/kubeflow#6374) 
Fix https://github.com/kubeflow/kubeflow/issues/6366

Migrating to Kubebuilder v3 leads to the following changes:
- Add .dockerignore file.
- Upgrade Go version from v1.15 to v1.17.
- Adapt Makefile.
- Add image (build + push) target to makefile.
- Upgrade EnvTest to use K8s v1.22.
- Update PROJECT template.
- Migrate CRD apiVersion from v1beta to v1.
- Add livenessProbe and readinessProbe to controller manager.
- Upgrade controller-runtime from v0.2.0 to v0.11.0.

Other changes:
- Build image using public.ecr.aws registry instead of gcr.io.
- Update README.md documentation.
- Update 3rd party licences.
- Fix notebook.spec description.
- Add 3 sample notebooks (v1, v1alpha1 and v1beta1).

Signed-off-by: Samuel Veloso <svelosol@redhat.com>
 		2022-05-03 15:49:01 +00:00
..
base release: Images for the 1.5.0 tag (kubeflow/kubeflow#6398) 2022-03-09 22:37:11 +00:00
crd Support K8s 1.22 in notebook controller (kubeflow/kubeflow#6374) 2022-05-03 15:49:01 +00:00
default Support K8s 1.22 in notebook controller (kubeflow/kubeflow#6374) 2022-05-03 15:49:01 +00:00
manager Support K8s 1.22 in notebook controller (kubeflow/kubeflow#6374) 2022-05-03 15:49:01 +00:00
overlays Notebook Controller: Consolidate manifests (kubeflow/kubeflow#5723) 2021-03-19 10:22:16 -07:00
rbac Support K8s 1.22 in notebook controller (kubeflow/kubeflow#6374) 2022-05-03 15:49:01 +00:00
samples Support K8s 1.22 in notebook controller (kubeflow/kubeflow#6374) 2022-05-03 15:49:01 +00:00
README.md Notebook Controller: Consolidate manifests (kubeflow/kubeflow#5723) 2021-03-19 10:22:16 -07:00

README.md

Manifests

This folder contains manifests for installing notebook-controller. The structure is the following:

.
├── crd
├── default
├── manager
├── rbac
├── samples
├── base
├── overlays
│   ├── kubeflow
│   └── standalone

The breakdown is the following:

  • crd, default, manager, rbac, samples: Kubebuilder-generated structure. We keep this in order to be compatible with kubebuilder workflows. This is not meant for the consumer of the manifests.
  • base, overlays: Kustomizations meant for consumption by the user:
    • overlays/kubeflow: Installs notebook-controller as part of Kubeflow. The resulting manifests should be the same as the result of the deprecated base_v3 from kubeflow/manifests. At a glance, it makes the following changes:
      • Use namespace kubeflow.
      • Remove namespace resource.
      • Add KFAM container.
      • Add KFAM Service and VirtualService.
    • overlays/standalone: Install notebook-controller in its own namespace. Useful for testing or for users that prefer to install just the controller.

CRD Issue

We patch the kubebuilder-generated CRD with an older version. That's because the validation was more relaxed in a previous version and now we ended up with some clients and resources in a state that fails more detailed validation, but works correctly. For more information, see: https://github.com/kubeflow/kubeflow/issues/5722