kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
notebooks/components/crud-web-apps/common/frontend/kubeflow-common-lib
History
Elena Zioga cca60b7d26 jwa(front): Fix unit tests (kubeflow/kubeflow#6804) 
* jwa(front): Rename form-default component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Create missing module files

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Remove form-rok and form components

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update JWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify rok-url component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add Rok URL message

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update VWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Remove the headers request

Remove the headers request since the common code implements it.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix JWA's unit tests

Fix JWA's unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Add GH action to run JWA unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(build): Update Dockerfile

Update Dockerfile to not build Rok.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
 		2022-12-07 12:49:38 +00:00
..
projects/kubeflow jwa(front): Fix unit tests (kubeflow/kubeflow#6804) 2022-12-07 12:49:38 +00:00
.editorconfig Create an Angular Library with common frontend code (kubeflow/kubeflow#5252) 2020-08-28 05:14:53 -07:00
.eslintrc.json Fix ng lint (kubeflow/kubeflow#6586) 2022-07-21 12:30:17 +00:00
.gitignore Create an Angular Library with common frontend code (kubeflow/kubeflow#5252) 2020-08-28 05:14:53 -07:00
README.md web-apps(front): Update the README (kubeflow/kubeflow#5481) 2020-12-23 02:42:28 -08:00
angular.json web-apps: Ensure in-flight requests are cancelled (kubeflow/kubeflow#6718) 2022-11-10 14:37:00 +00:00
package-lock.json build(deps): bump engine.io and socket.io in /components/crud-web-apps/common/frontend/kubeflow-common-lib (kubeflow/kubeflow#6756) 2022-12-05 10:16:08 +00:00
package.json web-apps(front): Changes needed for trials table (kubeflow/kubeflow#6768) 2022-11-25 13:46:11 +00:00
tsconfig.json web-apps: Common code for all-namespaces (kubeflow/kubeflow#6730) 2022-11-14 16:22:26 +00:00

README.md

Kubeflow Common Frontend Library

This code provides a common library of reusable Angular Components that can be used from our different Kubeflow web apps. This library aims to:

  • Enforce a common UX throughout the different apps
  • Reduce the development effort required to propagate changes to all the web apps
  • Minimize the code duplication between our Kubeflow web apps

This project was generated with Angular CLI version 8.3.20, which is required to build and run the unit tests.

Local development

In order to use this library while developing locally your Angular app you will need to:

  1. Build the kubeflow node module from this source code
  2. Link the produced module to your global npm modules
  3. Link the kubeflow module in the npm modules of you app

Building the library locally

# build the npm module
npm run build

# might need sudo, depending on where you global folder lives
# https://nodejs.dev/learn/where-does-npm-install-the-packages
npm link dist/kubeflow

Linking it to the app

cd ${APP_DIR}
npm install
npm link kubeflow

Running unit tests

Run ng test to execute the unit tests via Karma.

Contributor Guidelines

Unit tests

  1. Any new component added to this library should also include some basic unit tests
  2. The unit tests should be passing at any point of time

Git commits

Git commits that modify this code should be prefixed with web-apps(front).