kubeflow
/
pipelines
mirror of https://github.com/kubeflow/pipelines.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): Missing pipeline version name in new run page. (#9799)

This commit is contained in:
Joe Li 2023-08-02 14:10:18 -07:00 committed by GitHub
parent af753dc645
commit 0153430206
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/src/pages/PipelineDetails.test.tsx
View File

@ -760,6 +760,21 @@ describe('PipelineDetails', () => {
expect(newRunBtn).toBeDefined();
});
it('uses selected version ID to create run if URL does not contain version ID', async () => {
tree = shallow(<PipelineDetails {...generateProps()} />);
await TestUtils.flushPromises();
const instance = tree.instance() as PipelineDetails;
const newRunFromPipelineVersionBtn = instance.getInitialToolbarState().actions[
ButtonKeys.NEW_RUN_FROM_PIPELINE_VERSION
];
newRunFromPipelineVersionBtn.action();
expect(historyPushSpy).toHaveBeenCalledTimes(1);
expect(historyPushSpy).toHaveBeenLastCalledWith(
RoutePage.NEW_RUN +
`?${QUERY_PARAMS.pipelineId}=${testV2Pipeline.pipeline_id}&${QUERY_PARAMS.pipelineVersionId}=${originalTestV2PipelineVersion.pipeline_version_id}`,
);
});
it('clicking new run button navigates to the new run page', async () => {
tree = shallow(<PipelineDetails {...generateProps(PIPELINE_VERSION_ID, false)} />);
await TestUtils.flushPromises();

12
frontend/src/pages/PipelineDetails.tsx
View File

@ -131,10 +131,18 @@ class PipelineDetails extends Page<{}, PipelineDetailsState> {
buttons
.newRunFromPipelineVersion(
() => {
return pipelineIdFromParams ? pipelineIdFromParams : '';
return this.state.v2Pipeline
? this.state.v2Pipeline.pipeline_id
: pipelineIdFromParams
? pipelineIdFromParams
: '';
},
() => {
return pipelineVersionIdFromParams ? pipelineVersionIdFromParams : '';
return this.state.v2SelectedVersion
? this.state.v2SelectedVersion.pipeline_version_id
: pipelineVersionIdFromParams
? pipelineVersionIdFromParams
: '';
},
)
.newPipelineVersion('Upload version', () =>