fix(sdk): no longer require KFP client for kfp components build (#7430)

* fix(sdk): no longer require KFP client for kfp components build

* docs(sdk): added release note for kfp components build fix
This commit is contained in:
Jonny Browning (Datatonic) 2022-03-17 22:25:39 +00:00 committed by GitHub
parent 42115e3bc2
commit 02a52a4185
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions

View File

@ -79,6 +79,7 @@
* Add verify_ssl for Kubeflow client [\#7174](https://github.com/kubeflow/pipelines/pull/7174)
* Depends on `typing-extensions>=3.7.4,<5; python_version<"3.9"` [\#7288](https://github.com/kubeflow/pipelines/pull/7288)
* Depends on `google-api-core>=1.31.5, >=2.3.2` [\#7377](https://github.com/kubeflow/pipelines/pull/7377)
* Fix bug that required KFP API server for `kfp components build` command to work [\#7430](https://github.com/kubeflow/pipelines/pull/7430)
## Documentation Updates

View File

@ -27,6 +27,10 @@ from kfp.deprecated.cli.experiment import experiment
from kfp.deprecated.cli.output import OutputFormat
from kfp.deprecated.cli import components
_NO_CLIENT_COMMANDS = [
'diagnose_me',
'components'
]
@click.group()
@click.option('--endpoint', help='Endpoint of the KFP API service to connect.')
@ -57,8 +61,8 @@ def cli(ctx: click.Context, endpoint: str, iap_client_id: str, namespace: str,
Feature stage:
[Alpha](https://github.com/kubeflow/pipelines/blob/07328e5094ac2981d3059314cc848fbb71437a76/docs/release/feature-stages.md#alpha)
"""
if ctx.invoked_subcommand == 'diagnose_me':
# Do not create a client for diagnose_me
if ctx.invoked_subcommand in _NO_CLIENT_COMMANDS:
# Do not create a client for these subcommands
return
ctx.obj['client'] = Client(endpoint, iap_client_id, namespace,
other_client_id, other_client_secret)