kubeflow
/
pipelines
mirror of https://github.com/kubeflow/pipelines.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SDK - Stop adding empty descriptions and inputs (#1969)

This commit is contained in:
Alexey Volkov 2019-09-11 09:58:49 -07:00 committed by Kubernetes Prow Robot
parent 635370d256
commit 1962715688
4 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sdk/python/kfp/dsl/_metadata.py
View File

@ -158,13 +158,13 @@ def _extract_component_metadata(func):
arg_default = arg_default.value
if arg in annotations:
arg_type = _annotation_to_typemeta(annotations[arg])
inputs.append(ParameterMeta(name=arg, description='', param_type=arg_type, default=arg_default))
inputs.append(ParameterMeta(name=arg, param_type=arg_type, default=arg_default))
# Outputs
outputs = []
if 'return' in annotations:
for output in annotations['return']:
arg_type = _annotation_to_typemeta(annotations['return'][output])
outputs.append(ParameterMeta(name=output, description='', param_type=arg_type))
outputs.append(ParameterMeta(name=output, param_type=arg_type))
#TODO: add descriptions to the metadata
#docstring parser:
@ -174,9 +174,8 @@ def _extract_component_metadata(func):
# Construct the ComponentMeta
return ComponentMeta(
name=func.__name__,
description='',
inputs=inputs,
outputs=outputs,
inputs=inputs if inputs else None,
outputs=outputs if outputs else None,
)
@ -221,7 +220,7 @@ def _extract_pipeline_metadata(func):
# In case the property value for the schema validator is a string instead of a dict.
schema_object = json.loads(schema_object)
validate(instance=arg_default, schema=schema_object)
pipeline_meta.inputs.append(ParameterMeta(name=arg, description='', param_type=arg_type, default=arg_default))
pipeline_meta.inputs.append(ParameterMeta(name=arg, param_type=arg_type, default=arg_default))
#TODO: add descriptions to the metadata
#docstring parser:

4
sdk/python/tests/compiler/compiler_tests.py
View File

@ -555,7 +555,7 @@ class TestCompiler(unittest.TestCase):
image='image'
)
@dsl.pipeline(name='Pipeline', description='')
@dsl.pipeline(name='Pipeline')
def pipeline():
task1 = op()
task2 = op().after(task1)
@ -636,7 +636,7 @@ implementation:
command=['sleep 1'],
)
@dsl.pipeline(name='some_pipeline', description='')
@dsl.pipeline(name='some_pipeline')
def some_pipeline():
task1 = some_op()
task2 = some_op()

10
sdk/python/tests/dsl/component_tests.py
View File

@ -35,11 +35,11 @@ class TestPythonComponent(unittest.TestCase):
containerOp = componentA(1,2,c=3)
golden_meta = ComponentMeta(name='componentA', description='')
golden_meta.inputs.append(ParameterMeta(name='a', description='', param_type={'ArtifactA': {'file_type': 'csv'}}))
golden_meta.inputs.append(ParameterMeta(name='b', description='', param_type={'Integer': {'openapi_schema_validator': {"type": "integer"}}}, default=12))
golden_meta.inputs.append(ParameterMeta(name='c', description='', param_type={'ArtifactB': {'path_type':'file', 'file_type': 'tsv'}}, default='gs://hello/world'))
golden_meta.outputs.append(ParameterMeta(name='model', description='', param_type={'Integer': {'openapi_schema_validator': {"type": "integer"}}}))
golden_meta = ComponentMeta(name='componentA')
golden_meta.inputs.append(ParameterMeta(name='a', param_type={'ArtifactA': {'file_type': 'csv'}}))
golden_meta.inputs.append(ParameterMeta(name='b', param_type={'Integer': {'openapi_schema_validator': {"type": "integer"}}}, default=12))
golden_meta.inputs.append(ParameterMeta(name='c', param_type={'ArtifactB': {'path_type':'file', 'file_type': 'tsv'}}, default='gs://hello/world'))
golden_meta.outputs.append(ParameterMeta(name='model', param_type={'Integer': {'openapi_schema_validator': {"type": "integer"}}}))
self.assertEqual(containerOp._metadata, golden_meta)

4
sdk/python/tests/dsl/pipeline_tests.py
View File

@ -70,8 +70,8 @@ class TestPipeline(unittest.TestCase):
pass
golden_meta = PipelineMeta(name='p1', description='description1')
golden_meta.inputs.append(ParameterMeta(name='a', description='', param_type={'Schema': {'file_type': 'csv'}}, default='good'))
golden_meta.inputs.append(ParameterMeta(name='b', description='', param_type={'Integer': {'openapi_schema_validator': {"type": "integer"}}}, default=12))
golden_meta.inputs.append(ParameterMeta(name='a', param_type={'Schema': {'file_type': 'csv'}}, default='good'))
golden_meta.inputs.append(ParameterMeta(name='b', param_type={'Integer': {'openapi_schema_validator': {"type": "integer"}}}, default=12))
pipeline_meta = _extract_pipeline_metadata(my_pipeline1)
self.assertEqual(pipeline_meta, golden_meta)