kubeflow
/
pipelines
mirror of https://github.com/kubeflow/pipelines.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(backend): correct run field map col names (#10430) 

* fix(backend): correct field map col names

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

* chore(backend): add tests for api field map

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

---------

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
This commit is contained in:
Humair Khan 2024-02-02 11:54:15 -05:00 committed by GitHub
parent 1fe1c63f60
commit 421d65a684
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 30 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
backend/src/apiserver/model/run.go
View File

@ -363,11 +363,11 @@ var runAPIToModelFieldMap = map[string]string{
"storage_state": "StorageState",
"status": "Conditions",
"namespace": "Namespace", // v2beta1 API
"experiment_id": "ExperimentId", // v2beta1 API
"experiment_id": "ExperimentUUID", // v2beta1 API
"state": "State", // v2beta1 API
"state_history": "StateHistory", // v2beta1 API
"runtime_details": "PipelineRuntimeManifest", // v2beta1 API
"recurring_run_id": "RecurringRunId", // v2beta1 API
"recurring_run_id": "JobUUID", // v2beta1 API
}
// APIToModelFieldMap returns a map from API names to field names for model Run.

6
backend/src/apiserver/model/task.go
View File

@ -81,8 +81,8 @@ var taskAPIToModelFieldMap = map[string]string{
"namespace": "Namespace",
"pipeline_name": "PipelineName", // v2beta1 API
"pipelineName": "PipelineName", // v1beta1 API
"run_id": "RunId", // v2beta1 API
"runId": "RunId", // v1beta1 API
"run_id": "RunUUID", // v2beta1 API
"runId": "RunUUID", // v1beta1 API
"display_name": "Name", // v2beta1 API
"execution_id": "MLMDExecutionID", // v2beta1 API
"create_time": "CreatedTimestamp", // v2beta1 API
@ -91,7 +91,7 @@ var taskAPIToModelFieldMap = map[string]string{
"fingerprint": "Fingerprint",
"state": "State", // v2beta1 API
"state_history": "StateHistory", // v2beta1 API
"parent_task_id": "ParentTaskId", // v2beta1 API
"parent_task_id": "ParentTaskUUID", // v2beta1 API
"mlmdExecutionID": "MLMDExecutionID", // v1beta1 API
"created_at": "CreatedTimestamp", // v1beta1 API
"finished_at": "FinishedTimestamp", // v1beta1 API

7
backend/src/apiserver/storage/default_experiment_store_test.go
View File

@ -15,6 +15,7 @@
package storage
import (
"github.com/kubeflow/pipelines/backend/src/apiserver/model"
"testing"
"github.com/stretchr/testify/assert"
@ -93,3 +94,9 @@ func TestUnsetDefaultExperimentIdIfIdMatches(t *testing.T) {
db.Close()
}
func TestExperimentAPIFieldMap(t *testing.T) {
for _, modelField := range (&model.Experiment{}).APIToModelFieldMap() {
assert.Contains(t, experimentColumns, modelField)
}
}

6
backend/src/apiserver/storage/job_store_test.go
View File

@ -964,3 +964,9 @@ func TestDeleteJob_InternalError(t *testing.T) {
assert.Equal(t, codes.Internal, err.(*util.UserError).ExternalStatusCode(),
"Expected delete job to return internal error")
}
func TestJobAPIFieldMap(t *testing.T) {
for _, modelField := range (&model.Job{}).APIToModelFieldMap() {
assert.Contains(t, jobColumns, modelField)
}
}

6
backend/src/apiserver/storage/run_store_test.go
View File

@ -1421,3 +1421,9 @@ func TestParseResourceReferences(t *testing.T) {
assert.Nil(t, err)
assert.Equal(t, expectedResourceReferences, actualResourceReferences)
}
func TestRunAPIFieldMap(t *testing.T) {
for _, modelField := range (&model.Run{}).APIToModelFieldMap() {
assert.Contains(t, runColumns, modelField)
}
}

6
backend/src/apiserver/storage/task_store_test.go
View File

@ -617,3 +617,9 @@ func TestTaskStore_UpdateOrCreateTasks(t *testing.T) {
})
}
}
func TestTaskAPIFieldMap(t *testing.T) {
for _, modelField := range (&model.Task{}).APIToModelFieldMap() {
assert.Contains(t, taskColumns, modelField)
}
}