kubeflow
/
pipelines
mirror of https://github.com/kubeflow/pipelines.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(sdk): Registry Client - default to read full spec of versions (#7936) 

* default to read full spec of versions

* update tests

* fix formatting
This commit is contained in:
chongyouquan 2022-06-24 08:43:51 -07:00 committed by GitHub
parent e0fe0f188b
commit 58f7ab8b49
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/python/kfp/registry/context/kfp_pkg_dev.json
View File

@ -11,8 +11,8 @@
"delete_tag_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/tags/{tag}",
"create_tag_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/tags?tagId={tag}",
"update_tag_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/tags/{tag}?updateMask=version",
"get_version_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/versions/{version}",
"list_versions_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/versions",
"get_version_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/versions/{version}?view=FULL",
"list_versions_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/versions?view=FULL",
"delete_version_url":"https://artifactregistry.googleapis.com/v1/projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/versions/{version}",
"package_format":"projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}",
"tag_format":"projects/{project_id}/locations/{location}/repositories/{repo_id}/packages/{package_name}/tags/{tag}",

8
sdk/python/kfp/registry/registry_client.py
View File

@ -195,7 +195,8 @@ class RegistryClient:
return ApiAuth(auth_token)
return None
def load_config(self, host: Optional[str], config_file: Optional[str]) -> dict:
def load_config(self, host: Optional[str],
config_file: Optional[str]) -> dict:
"""Loads the config.
Args:
@ -285,8 +286,9 @@ class RegistryClient:
return config
return loaded_config
def _get_auth(self) -> Optional[Union[requests.auth.AuthBase,
credentials.Credentials]]:
def _get_auth(
self
) -> Optional[Union[requests.auth.AuthBase, credentials.Credentials]]:
"""Helper function to convert google credentials to AuthBase class if
needed.

10
sdk/python/kfp/registry/registry_client_test.py
View File

@ -100,11 +100,11 @@ class RegistryClientTest(parameterized.TestCase):
'get_version_url':
('https://artifactregistry.googleapis.com/v1/projects/'
'proj/locations/us-central1/repositories'
'/repo/packages/{package_name}/versions/{version}'),
'/repo/packages/{package_name}/versions/{version}?view=FULL'),
'list_versions_url':
('https://artifactregistry.googleapis.com/v1/projects/'
'proj/locations/us-central1/repositories'
'/repo/packages/{package_name}/versions'),
'/repo/packages/{package_name}/versions?view=FULL'),
'delete_version_url':
('https://artifactregistry.googleapis.com/v1/projects/'
'proj/locations/us-central1/repositories'
@ -278,7 +278,7 @@ class RegistryClientTest(parameterized.TestCase):
mock_get.assert_called_once_with(
url=('https://artifactregistry.googleapis.com/v1/projects/'
'proj/locations/us-central1/repositories'
'/repo/packages/pack/versions/sha256:abcde12345'),
'/repo/packages/pack/versions/sha256:abcde12345?view=FULL'),
data='',
headers=None,
auth=mock.ANY)
@ -291,7 +291,7 @@ class RegistryClientTest(parameterized.TestCase):
mock_get.assert_called_once_with(
url=('https://artifactregistry.googleapis.com/v1/projects/'
'proj/locations/us-central1/repositories'
'/repo/packages/pack/versions'),
'/repo/packages/pack/versions?view=FULL'),
data='',
headers=None,
auth=mock.ANY)
@ -309,7 +309,7 @@ class RegistryClientTest(parameterized.TestCase):
mock_get.assert_called_once_with(
url=('https://artifactregistry.googleapis.com/v1/projects/'
'proj/locations/us-central1/repositories'
'/repo/packages/pack/versions'),
'/repo/packages/pack/versions?view=FULL'),
data='',
headers=None,
auth=mock.ANY)