[Frontend] Configure tslint for better DX (#2431)

* Configure tslint to show warnings during dev time, but error on CI build

* Ignore generated folder too

frontend/package.json

@@ -41,10 +41,11 @@
     "apis:run": "java -jar swagger-codegen-cli.jar generate -i ../backend/api/swagger/run.swagger.json -l typescript-fetch -o ./src/apis/run -c ./swagger-config.json",
     "apis:filter": "java -jar swagger-codegen-cli.jar generate -i ../backend/api/swagger/filter.swagger.json -l typescript-fetch -o ./src/apis/filter -c ./swagger-config.json",
     "apis:visualization": "java -jar swagger-codegen-cli.jar generate -i ../backend/api/swagger/visualization.swagger.json -l typescript-fetch -o ./src/apis/visualization -c ./swagger-config.json",
-    "build": "react-scripts-ts build",
+    "build": "npm run lint && react-scripts-ts build",
     "docker": "COMMIT_HASH=`git rev-parse HEAD`; docker build -q -t ml-pipelines-frontend:${COMMIT_HASH} --build-arg COMMIT_HASH=${COMMIT_HASH} --build-arg DATE=\"`date -u`\" -f Dockerfile ..",
     "eject": "react-scripts-ts eject",
     "java": "java -version",
+    "lint": "tslint -c ./tslint.prod.json -p .",
     "mock:api": "ts-node-dev -O '{\"module\": \"commonjs\"}' mock-backend/mock-api-server.ts 3001",
     "mock:server": "node server/dist/server.js build",
     "postinstall": "cd ./server && npm i && cd ../mock-backend && npm i && cd ../src/generated/src/apis/metadata && npm i",

frontend/tsconfig.json

@@ -21,7 +21,6 @@
     "strictBindCallApply": true,
     "strictNullChecks": true,
     "suppressImplicitAnyIndexErrors": true,
-    "noUnusedLocals": true,
     "skipLibCheck": true
   },
   "exclude": [

frontend/tsconfig.prod.json

@@ -1,3 +1,6 @@
 {
-  "extends": "./tsconfig.json"
-}
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noUnusedLocals": true
+  }
+}

frontend/tslint.json

@@ -1,5 +1,6 @@
 {
   "extends": ["tslint:recommended", "tslint-react", "tslint-config-prettier"],
+  "defaultSeverity": "warn",
   "linterOptions": {
     "exclude": [
       "config/**/*.js",
@@ -7,8 +8,10 @@
       "src/apis/**/*.ts",
       "coverage/lcov-report/*.js",
       "backstop_data/**/*.js",
-      "../frontend/src/api/*.ts"
-    ]
+      "generated/**",
+      "src/api/*.ts"
+    ],
+    "format": "verbose"
   },
   "rules": {
     "interface-name": [true, "never-prefix"],
@@ -18,6 +21,7 @@
     "ordered-imports": false,
     "semicolon": [true, "always", "ignore-bound-class-methods"],
     "typedef": [true, "call-signature"],
+    "no-unused-variable": true,
     "variable-name": [
       true,
       "check-format",

frontend/tslint.prod.json

@@ -0,0 +1,4 @@
+{
+  "extends": "./tslint.json",
+  "defaultSeverity": "error"
+}