Commit Graph

8 Commits

Author SHA1 Message Date
Jagadeesh J 58d22d4ba9
chore(components/pytorch) - Samples fix for PT and PTL Upgrade (#8148)
* WIP: chore(components/pytorch) - Samples fix for PT and PTL Upgrade

* fix: bert example

 - fix minio secret
 - remove pth file upload to minio
 - add captum to pip packages

* fix: bert-dist training args

* fix: cifar10 example

* fix: cifar10 example notebook

* fix: captum example

* fix: gpu fixes for bert and cifar10 example

* fix: bert dist ptl upgrade
2022-09-22 05:29:38 +00:00
shrinath-suresh a54aa33f51
chore(components/pytorch): bert samples - confusion matrix (#6458)
* Fixing confusion matrix

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Enabling confusion matrix

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Passing attention masks to compute_bert_outputs

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
2021-09-03 12:05:10 -07:00
shrinath-suresh b4ad3d1488
chore(components/pytorch): Samples Unit tests and lint fixes (#6288)
* Applying yapf on all the python files in samples

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Test compile yaml fixes

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Remove unused file

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Lint fixes: generate_templates.py

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Lint fixes:  gen_image_timestamp.py

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Lint fixes

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Cifar10 handler lint fixes

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Lint fixes for the remaining files

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
2021-08-11 22:59:02 -07:00
shrinath-suresh d88394ba4a
fix(components/pytorch): pytorch kfp components and Sample - GPU updates (#5939)
* Updating trainer test wiht model parameter to support multi gpu multi node scenario

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Changing get_model to lightning_module in bert example as PTL is used from source

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* removing ptl 1.3.x from dependency as Pytorch operator needs ptl to be installed from source

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating trainer args with gpu parameters

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Installing PTL from source

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating get_model to lightning_module

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
2021-07-11 22:06:26 -07:00
shrinath-suresh 192b8e8756
fix(components/pytorch) Pytorch Lightning Arguments string pass through (#5870)
* Updating bert script to use input arguments as string

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding utility to parse input arguments

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing tensorboard root and checkpoint dirs

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding string pass through in component.yaml

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing pipeline.py file

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing pipeline keys

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing args in component.yaml

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Removing extra comma

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Removing unused code

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating cifar10 example

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Uncommenting confusion matrix

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating jupyter notebooks

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing cifar10 train component.yaml

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Addressing review comments

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing lint issues

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
2021-06-23 23:10:19 -07:00
Jagadeesh J 2d7f3a21f2
feat(components/pytorch): Add requirement for mar generation (#5850)
* Feat: Add requirement for mar generation

 - Notebook clean to skip root access
 - Adds package.json

* Fix: Update config.properties for cifar10 and bert examples

* Fix: Update s3 urls with git urls

 - readme fixes
 - add config.properties

* Fix: Docker files copy command permission
2021-06-17 03:10:28 -07:00
shrinath-suresh 9cfa4dfc0a
fix(components/pytorch) Pytorch - Tensorboard Profiler fix (#5860)
* Fix: module_file_args overriding the trainer_args variable. Updating module_file_args as the superset

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Setting PTL to 1.3.5 in requirements.txt

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing typo

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding print statements for profiler debugging

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Removing cpuonly tag

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>
2021-06-16 16:06:27 -07:00
shrinath-suresh 703822c420
feat(components): Adding samples for PyTorch - KFP (#5812)
* Adding Cifar10, Bert examples, component.yamls and Dockerfile

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding cifar10 and bert notebooks

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing component yaml paths

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Changing docker image name

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* updating notebooks

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating image name in component.yaml

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding --no-cache option to pip install

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating readme file with cluster steps

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing links in README.md

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing README.md indendation

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Removing local pipelines files

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Updating docker image name

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding Docstrings, yapf, pylint

Signed-off-by: ankan94 <ankan@ideas2it.com>

* fix test images paths in the notebook

Signed-off-by: Arvind-Ideas2IT <arvindkumarsingh.gautam@ideas2it.com>

* Adding docker file for gpu

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding pipeline.py file to run the example from local environment

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding build script for local testing

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing name

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding license header and description in component.yaml files

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixin docker file license

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Renaming docker file

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding docker file name to build script

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* updating readme.md with local steps

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Installing pytorch-components from pypi

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Fixing cpu docker file

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Adding --no-cache-dir for pip

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

* Removing headers

Signed-off-by: Shrinath Suresh <shrinath@ideas2it.com>

Co-authored-by: ankan94 <ankan@ideas2it.com>
Co-authored-by: Arvind-Ideas2IT <arvindkumarsingh.gautam@ideas2it.com>
2021-06-09 06:44:16 -07:00