Commit Graph

8 Commits

Author SHA1 Message Date
Yihong Wang bb9dc67572
feat(frontend): make container name configurable (#9433)
* feat(frontend): make container name configurable

Add an UIConfig param to specify the container name in a pod
where logs are retrieved. The default container name for
the Argo is `main`. However, in Tekton, the main container name
contains the `step-` prefix. Make this configurable to support
other orchestrations.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

* fix test case error

add `undefined` as the expected `logContainerName` param

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

* address the comment

use default value `main` in `getPodLogsStreamFromK8s`
same as `getPodLogs`

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

* only pass podLogContainerName

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

---------

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
2023-05-17 23:37:06 +00:00
Alexey Volkov cc83e1089b
Assigned copyright to the project authors (#5587) 2021-05-05 13:53:22 +08:00
Yuan (Bob) Gong b7706c0134
[UI Server] Enable strict type checking and fix errors (#3593)
* wip

* Fix typing

* Fix build error

* Add type checking to tests

* Fix server typing

* Clean up

* Fix server typing
2020-04-23 09:25:11 -07:00
Yuan (Bob) Gong 70bce6d183 Fix node server typing problems (#2807) 2020-01-07 04:10:17 -08:00
Eterna2 2ec2fd23c5 [Frontend] unit tests for node server (#2745)
* Add unit tests for aws-helper and minio-helper.

* Break up server.ts into app.ts and handlers/*.ts so that unit test can be written more easily.

* update @types/node because of https://github.com/microsoft/TypeScript/issues/32333

* upgrade kubernete-client version to be compatible with new @types/node version

* fix bug: AWSInstanceProfileCredentials.profile() returns a promise not a string

* remove I prefix from interfaces. minor fixes on lint errors.

* fix format errors

* Added more unit tests, and minor fixes.

* Fix comment: GKS should be GKE

* use jest.resetAllMocks instead of reset each mock individually

* fix format for helper test
2020-01-05 20:43:40 -08:00
Yuan (Bob) Gong e86e40907b [UI] Pass namespace to APIs (#2676)
* Format other frontend code using prettier

* Regenerate frontend api clients

* Pass namespace to CreateRun api request

* Fetch logs from pod namespace

* Fix log handler cannot work with pod name only query bug

* Fix and refactor existing tests

* Unit test adding namespace to create run api call.

* Remove unneeded snapshot

* Fix lint errors

* Consistently use resource reference id for namespace
2019-12-17 09:07:59 -08:00
Yuan (Bob) Gong 4500d244d7 Format other frontend code using prettier (#2717) 2019-12-11 05:04:06 -08:00
Eterna2 aa2d2f42b3 [pipeline-ui] Retrieve pod logs from argo archive (#2081)
* Retrieve pod logs from argo archive

* Added aws instance profile iam credential support for minio client. Read workflow status for argo archive location for pod logs.

* fix minor typo, and enforce typing for minio client options

* Update helm chart for pipelines ui role with permission to access secret and workflow crd

* remove unnecessary type cast

* Fix bug: s3client should be a callable, so that iam token is refreshed
2019-11-07 16:58:18 -08:00