Commit Graph

86 Commits

Author SHA1 Message Date
Ricardo Martinelli de Oliveira 6275177e6e
Fix metrics visualization v2 sample (#10399) 2024-01-17 16:54:30 -08:00
Chen Sun a727783abd
chore: remove 'dummy_root' in test samples (#9640)
* remove 'dummy_root' in test samples

* more cleanup
2023-06-21 23:51:41 +00:00
Lingqing Gan b8caf811c2
feat(backend): support secrets (#9178)
* support secret in driver

* add sample tests

* fix comments
2023-04-20 00:33:39 +00:00
Lingqing Gan ca63f20049
fix(backend): fix volume bug (#9150)
* fix volume bug

* fix indentation

* update driver image

* revert launcher image sha
2023-04-18 23:53:54 +00:00
Aditya Soni a0074c8963
test: added verify_func in TestCase (#9002) 2023-04-18 20:07:53 +00:00
Lingqing Gan 89bdac9340
feat(backend): support optional and default parameters. Fixes #8716 (#8765)
* support optional and default parameters

* add sample test

* change assert value

* update test

* update test

* fix sample test

* fix sample test

* fix sample test

* test fix

* change parameter logic

* test

* test

* change logic handling not provided parameter

* remove unnecessary code and add more sample case

* fix sample test bug

* fix sample test

* update logic

* change parameter logic

* update logic

* update logic handling when parameter not provided

* fix sample test

* add error message

* fix samples test

* samples test

* remove unused code
2023-03-02 17:47:04 +00:00
Lingqing Gan faca1e5aab
feat(backend): add support for environment variables. Fixes #8704 (#8886)
* support env var and add test

* sample test fix

* remove compiler test case

* fix test script

* update sample test
2023-02-27 18:02:08 +00:00
Chen Sun 684779eb2e
fix(samples): update sklearn package name (#8439) 2022-11-10 12:35:00 +00:00
Chen Sun 5ce4954d6b
feat(sdk)!: Implement Graph Component (#8179)
* Implement Graph Component

* isort imports

* release note

* address review comments

* address review comments
2022-08-26 09:28:49 +00:00
Scott_Xu 121ddcbc04
fix(sdk): fix v2 sample tests for cuj3 (#8168)
* fix v2 sample tests for cuj3

* separate sh -c

* fix two step pipeline

* fix piping error

* fix nit

* change path to uri to correct cat command

* correct bash script

* remove display name

* change directory reference in commands

* remove old files
2022-08-25 15:30:22 -07:00
Scott_Xu 04c827fc3a
feat(sdk): supporting bring your own container for arbitrary input and outputs (#8066)
* support container_component decorator for function with no inputs

* resolve review comments

* add sample tests for milestone 1

* modify compiler test data

* resolve reviews

* resolve reviews

* WIP

* implementation of function of no inputs

* fixed sample test

* re-fix sample test

* fix rebase merge conflict

* resolve formatting

* resolve isort error for test data

* resolve comments

* fix nit

* resolve nit

* add implementation for placeholders i/o, sample and compiler tests

* resolve comments and merge logic for constructing container component

* resolve comments

* resolve comments

* fix assertion messages

* add error handling for accessing artifact by itself

* add test for raising error for accessing artifact by itself
2022-08-08 21:00:53 +00:00
Connor McCarthy 3a8d2e2c3c
test(samples): skip concat placeholder test (#7988) 2022-07-07 18:17:48 +00:00
Connor McCarthy a5548440a3
use click for dsl-compile command (#7560) 2022-04-20 14:57:10 -06:00
Yaqi Ji 04123280a4
fix(sdk): add default value for inputs (#7405)
* fix(sdk): add default value for inputs

* merge conflict

* release

* fix sample
2022-03-23 18:59:20 +00:00
Connor McCarthy c7301c449c
feat(sdk)!: use yaml for IR package (#7431)
* change serialization format from json to yaml

* refactor: use guard clause for clarity

* convert test data from json to yaml

* add and update tests

* permit deprecated compile to json

* re-add json test data

* update compiler tests

* refactor Compiler._write_pipeline_spec_file

* update golden snapshots

* update sample output extensions

* test file extension exceptions and warnings

* update release notes

* remove json golden snapshots
2022-03-21 21:45:31 +00:00
Yaqi Ji 8bb0d0e025
feat(sdk)!: move v2 to main namespace (#7376)
* feat(sdk)!: move v2 to main namespace

* edit samples
2022-03-04 21:56:51 +00:00
Yaqi Ji b693909a08
feat(sdk)!: move v1 to deprecated folder (#7291)
* chore(sdk): move v1 to deprecated

* fix testsg

* fix testsg

* fix setup.py

* fix test

* s'

* fix tests

* fix test

* retore v2 test changes

* fix py3.6 test

* fix py3.6 test

* fix py3.6 import fallback error

* remove deprecated

* fix samples test

* sample test

* fix samples

* add readme

* restroe test

* python require

* remove path

* fix tests

* inteegration tests

* remove tfx tests for dependency with kfp v1

* fix e2e

* fix e2e

* fix integration tests

* fix sampe

* move client down

* change to kfp

* add import alias

* fix

* runid

* fix dsl

* only use kfp for function

* revert train_until_good

* tfx test

* kfp

* try import

* onprem
2022-03-04 00:52:59 +00:00
Yuan (Bob) Gong ca6e05591d
test: update README of v2 sample test (#7121)
* test: update README of v2 sample test

* address review comments by @zijianjoy

* use absolute paths, suggested by @zijianjoy

* Update README.md
2021-12-30 16:22:54 +08:00
Yuan (Bob) Gong 2460aaa653
test: migrate sample integration test to v2 sample test infra (#7115)
* test: migrate sample integration test to v2 sample test infra

* test: configure v2 integration test timeout
2021-12-26 04:17:44 +00:00
Yuan (Bob) Gong ac14a3b610
test: migrate all sample tests to v2 sample test infra (#7114)
* test: migrate all sample tests to v2 sample test infra

* fix
2021-12-24 08:15:43 +00:00
Yuan (Bob) Gong 44228c242b
test(v2): v2 sample test supports notebooks (#7109)
* test(v2): v2 sample test supports notebooks

* fix

* fix relative path problem
2021-12-24 02:37:42 +00:00
Yuan (Bob) Gong 76b8060a27
refactor(v2): remove v2 compatible related code (#7103)
* refactor(v2): remove v2 compatible related code

* fix presubmit

* clean up more usages of v2 compatible

* fix
2021-12-23 12:43:16 +08:00
Yuan (Bob) Gong c7448c71df
test(v2): refactor sample test utils into a py package (#7105)
* test(v2): refactor sample test utils into a py package

* fix error
2021-12-23 11:10:01 +08:00
Yuan (Bob) Gong 048218b091
feat(v2): control flow - conditional (#7088)
* feat(v2): control flow - conditional

* fix v2 go tests

* fix importer sample

added condition_test

* address comments

* fix
2021-12-22 10:13:21 +08:00
Yuan (Bob) Gong 26d33ead40
chore(v2): v2 iterator expr selector support (#7020)
* chore(v2): parameter expression selector support

* implement input parameter type validation and conversion

* fix some issues

* test: add tests for remaining loop samples

* fix

* fix2

* fix3

* address comments

* fix some tests
2021-12-10 19:01:49 +00:00
Yuan (Bob) Gong 713558cfb8
feat(v2): iterator and sub-DAG basic support (#6985)
* chore(samples): add loop_output_v2 sample

* feat(v2): iterator support

* refactor v2 backend compiler tests to golden files

* fix unit tests

* test(v2): verify loop_output_test MLMD data

* clean up

* fix

* fix2

* fix
2021-12-09 14:23:55 +00:00
Yuan (Bob) Gong 50d7518245
refactor(v2): executions use parent_dag_id custom property for DAG - task relationship (#6983)
* refactor(v2): executions use parent_id custom property for parent child relationship

* chore: do not store pipeline root on executions

* review feedback by @capri-xiyue

* refactor: rename parent_id to parent_dag_id for clarity
2021-12-02 02:26:04 +00:00
Yuan (Bob) Gong f099b93a2b
test(samples): simplify v2 sample test verify funcs + clean up (#6964)
* test(samples): simplify v2 sample test verify funcs + clean up

* chore(samples): add placeholder_if tests back, fix flakiness in xgboost sample

* test(samples): clean up empty tests in config.yaml

* chore: add placeholder_if back

* chore(samples): clean up all samples

* fix

* Update xgboost_sample.py
2021-11-30 10:55:30 +00:00
Chen Sun 59dfffebea
fix(sdk.v2): Avoid pydantic union bug (#6957)
* avoid pydantic union bug

* release note
2021-11-24 21:48:34 +00:00
Chen Sun 5bbb384cc7
test: clean up v2 compatible mode sample tests (#6943) 2021-11-23 02:08:06 +00:00
Chen Sun 2910d10cc3
fix(sdk.v2): Fix bug on executor input with default value. (#6937)
* fix bug on executor input

* release note

* fix test on empty message

* fix part of the test
2021-11-22 21:09:06 +00:00
Chen Sun 73804f8928
test(sample): reenable samples tests run with V2_ENGINE mode (#6932)
* reenable v2 engine

* fix

* fix

* fix

* log v2 engine test

* don't fill in default value at test util

* fix

* pass to job instead of spec
2021-11-20 18:18:35 +00:00
Chen Sun 7921946b07
feat(sdk.v2)!: Merge v2 experimental change back to v2 namespace (#6890)
* merge v2 experimental change back to v2 namespace

* release note

* fix tests

* fix cli

* fix py3.6 test

* skip v2 compatible mode tests

* fix tests

* skip v2 engine tests
2021-11-11 00:25:42 +00:00
Chen Sun 8c6843fdb8
fix(sdk.v2): Fix importer ignoring `reimport` setting, and switch to Protobuf.Value for import uri. (#6827)
* fix importer

* release note

* remove error usage in test sample

* disable importer test
2021-10-28 20:40:51 -07:00
Ajay Gopinathan 0be57c3880
feat(sdk): Use google.protobuf.Value in v2 for passing parameters. (#6804)
* Use google.protobuf.Value in v2 for passing parameters.

* retest samples.

* Fix tests.

* Update release, more cleanup.

* Use github.com/kubeflow/pipelines/api from same repo.

* Run go mod tidy

* chore: go mod tidy

* fix v2 compile error and clean up unused code

* pr comments.

* update goldens

* Fix metadata recording.

* Update kfp mlmd client.

* fix test again

* another try.

* chore: migrate v2 DAG driver input parameters to protobuf.Value + small refactorings

* fix v2 launcher + clean up

* fix a compile error

* fix a few more tests

* fix number parsing

* clean up

* disable cache_v2 test.

Co-authored-by: Yuan Gong <gongyuan94@gmail.com>
2021-10-28 14:25:51 -07:00
capri-xiyue 0c2759d844
fix: disable cache for v1 mode in sample test (#6641)
* disable cache for v1 mode

* disable cache for v1 mode

* change to use task max cache staless instead of adding pod annotation

* modified code

* added comments

* fixed e2e test error
2021-09-28 21:49:48 -07:00
capri-xiyue 951b968cb6
feat(v2): Support v2 caching (#6569)
* modified argo workflow

* v2 caching draft

* move driver folder to component folder

* move driver back to driver folder

* finished cache logic, need debug

* added cached execution entry

* fixed typo

* added cache v2 e2e test

* added enable caching flag for kfp v2 tests

* fixed v2 e2e test

* fixed cache e2e test

* fixed cache e2e test

* pass container spec as a whole

* fixed nits

* fixed ut

* remove local file wriiting for v2 cache

* fixed bug
2021-09-24 17:12:40 -07:00
Chen Sun ed3453f794
chore: update comments in a pipeline sample (#6601)
* Update lightweight_python_functions_v2_pipeline.py

* Update lightweight_python_functions_v2_pipeline.py

* Update lightweight_python_functions_v2_pipeline.py

* Update mock_lightweight_python_functions_v2_pipeline.json

* Update lightweight_python_functions_v2_pipeline.json

* Update mock_lightweight_python_functions_v2_pipeline.json
2021-09-23 11:29:36 -07:00
capri-xiyue 4438929259
feat(v2): added importer support (#6415)
* added importer support in compilor

* added importer launcher

* complete importer launcher draft

* added importer e2e test draft

* added importer e2e test draft and fixed build error

* added importer e2e test draft and fixed build error

* changed sample test config

* fixed mlmd publish error

* fixed format and added task verification for importer e2e test

* changed sample v2 importer test

* added non default bucket support

* fixed importer build error

* fixed e2e test

* modify importer e2e test

* fixed e2e test

* fixed e2e test

* fixed e2e test

* fixed importer e2e test

* fixed comments

* fixed unit test

* fixed importer e2e test

* added todo comment

* remove unused code

* Update importer.go

Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com>
2021-08-31 04:06:03 -07:00
Yuan (Bob) Gong 2b7aed3be2
chore(v2): support changing pipeline root (#6363)
* test(v2): support changing pipeline root

* fix
2021-08-18 04:06:38 -07:00
Ajay Gopinathan f3f383c2ff
chore(sdk): Refactor and move all v2 related code to under the v2 namespace. (#6358)
* Refactor and move all v2 related code to under the v2 namespace.

Most of the changes are around imports and restructuring of the
codebase. While it looks like a lot of code was added, most of the code
already existed and was simply moved or copied over to v2. The only
exceptions are:
- under kfp/v2/components/component_factory.py: some helper functions
  were copied with simplification from _python_op.py
- we no longer strip the `_path` suffix in v2 components.

Note: there is still some duplication of code (particularly between
component_factory.py and _python_op.py), but it's ok for now since we
intend to replace some of this with v2 ComponentSpec + BaseComponent.

* Update setup.py.

* update tests.

* revert accidental change of gcpc

* Fix component entrypoint.

* Update goldens.

* fix tests.

* fix merge conflict.

* revert gcpc change.

* fix tests.

* fix tests.

* Add type aliases for moved files.

* merge and update goldens.
2021-08-17 19:25:37 -07:00
James Liu 5203ecf273
test: Update visualization v2 to output HTML and Markdown. Partial #3970 (#6349)
* test: Update visualization v2 to output HTML and Markdown.

* address comment

* vis test
2021-08-17 04:46:42 -07:00
Yuan (Bob) Gong 674756c76f
chore(v2): support output metadata file (#6361)
* chore(v2): support output metadata file

* add one more sample
2021-08-17 03:56:42 -07:00
Yuan (Bob) Gong afd28c605d
test(v2): add more samples. Part of #6150 (#6353)
* test(v2): add all samples using parameter + artifact passing features to v2 engine

* fix some samples

* fix output file

* comment failing samples

* improve comments
2021-08-16 21:38:41 -07:00
Chen Sun 7559e27cfb
feat(backend/sdk): Rename `pipeline-output-directory` to `pipeline-root`. Fixes #6307 (#6329) 2021-08-13 00:41:54 -07:00
Yuan (Bob) Gong 2b78d16e03
chore(v2): artifact passing via local path (#6285)
* chore(v2): add implicit dependencies for artifacts

* chore(v2): artifact passing via local path

* clean up
2021-08-10 21:40:25 -07:00
Yuan (Bob) Gong 25958081e6
chore(v2): parameter passing. Fixes #6151 (#6208)
* chore(v2): publish output parameters

* chore(v2): resolve input parameters from producer task

* chore(v2): add implicit parameter dependencies to DAG tasks

* test(v2): add verification for v2 tests

* fix compiler unit test
2021-08-05 18:25:50 -07:00
Ajay Gopinathan c5591f2652
feat(sdk): Enable the use of Executor from KFP package for v2 lightweight components (#6202)
* Enable the use of v2 Executor from KFP package.

This avoids the need to paste Executor code for v2 components into
the entrypoint of lightweight components.

* Update tests.

* quote package path.

* quote package path.

* escape fragment

* Update golden files.

* update goldens.

* Cleanup.

* More cleanup.

* update goldens.

* style updates.

* clean up sample tests.

* fix trailing comma

* Try using signed urls.

* fix

* fix presubmit

* try /bin/bash for Makefile shell

* undo signed url change.

Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com>
2021-08-05 14:53:03 -07:00
Yuan (Bob) Gong 2181b2fb8b
feat(sdk): add_default_resource_spec container op transformer (#6203)
* feat(sdk): add_default_resource_spec container op transformer

* set memory request/limit for sampOOMed samples

* refactor

* adjust tensorboard minio memory usage

* adjust resource usage

* clean up

* address feedbacks
2021-08-05 15:28:17 +08:00
Yuan (Bob) Gong 9c69e68652
test(v2): v2 sample test supports v2 engine mode (#6193)
* test(v2): v2 sample test supports v2 engine mode

* enable other tests

* chore(v2): prepublish pod info to MLMD before user command

* fix test failure

* update annotations

* fix go tests

* add use-new-run arg to kaniko

* test(v2): add resource request/limit to build image tasks

* verify

* test2

* pin 1.3.0 kaniko image to avoid OOM issues

* simplify the change

* fix

* clean up unnecessary changes
2021-08-01 01:58:37 -07:00