Commit Graph

15 Commits

Author SHA1 Message Date
gkcalat f626629f79
chore(testing): Enable samples in e2e tests with v1 kfp SDK (#9169)
* Add pipeline_id to run and recurring run protos

* Add pipeline_id to run and recurring_run

* Set status when creating a new job. Closes #9125.

* Enable sample tests
2023-04-19 04:55:53 +00:00
Yaqi Ji b693909a08
feat(sdk)!: move v1 to deprecated folder (#7291)
* chore(sdk): move v1 to deprecated

* fix testsg

* fix testsg

* fix setup.py

* fix test

* s'

* fix tests

* fix test

* retore v2 test changes

* fix py3.6 test

* fix py3.6 test

* fix py3.6 import fallback error

* remove deprecated

* fix samples test

* sample test

* fix samples

* add readme

* restroe test

* python require

* remove path

* fix tests

* inteegration tests

* remove tfx tests for dependency with kfp v1

* fix e2e

* fix e2e

* fix integration tests

* fix sampe

* move client down

* change to kfp

* add import alias

* fix

* runid

* fix dsl

* only use kfp for function

* revert train_until_good

* tfx test

* kfp

* try import

* onprem
2022-03-04 00:52:59 +00:00
James Liu af9d058e85
fix(manifests): Remove redundant secret value in profile controller (#7087)
* fix(manifests): Remove redundant secret value in profile controller

* attempt to fix sample test
2021-12-23 16:41:42 +00:00
Alexey Volkov cc83e1089b
Assigned copyright to the project authors (#5587) 2021-05-05 13:53:22 +08:00
Yuan (Bob) Gong 02cb6e3300
test(samples): fix sample-test argo logs command. Fixes #5283 (#5284)
* test(samples): fix sample-test argo logs command

* Update check_notebook_results.py

* Update run_sample_test.py

* Update run_resnet_cmle_test.py
2021-03-11 19:39:24 -08:00
Yuan (Bob) Gong 82e9731c32
test(proxy): use inverse proxy staging env for presubmit tests. Part of #4667 (#4678)
* wip

* test(proxy): use inverse proxy staging env for presubmit tests

* update

* update

* fix syntax error

* fix

* let test run faster

* keep cluster for debugging

* update

* fix tests
2020-10-30 00:44:06 -07:00
Alexey Volkov 7b6957ae06 SDK - Client - Added a way to set experiment name using environment variables (#2292)
* SDK - Client - Added a way to set experiment name using environment variables

This is useful for launching notebooks or pipeline files that submit
themselves for execution.

* Switched to subprocess.run which supports env

* Setting the environment variable differently
Looks like `subprocess.run` uses `PATH` to search for the program.

* Convert return code to string

* Changed the way the experiment name is being set

* Changed how the notebook installs the SDK

Notebook is overriding the SDK that's being tested.

* Not installing the KFP SDK package

* Removed the experiment_name from samples and configs.

* Changed the SDK installation lines in samples

Otherwise the sample tests do not correctly test the new SDK code.
2019-10-14 14:55:51 -07:00
Jiaxiao Zheng 7b1c720a47 Improve notebook check automation (#2040)
* Add logic to detect extension name.

* Rename notebook samples

* Change to use config yaml for papermill preprocess.

* Remove ad hoc logic

* Remove duplicated logic

* Refactor

* Add run_pipeline flag in config yaml

* Add run pipeline flag for .py sample as well.

* Fix extension name

* Fix

* Fix problems in docstring.

* refactor run_sample_test.py into two functions

* Refactor the procedure into 3 steps

* Fix bug in exit code format

* Remove two redundant functions.
2019-09-09 13:40:55 -07:00
Jiaxiao Zheng 4918d1919a
Change sample test to read test arguments from yaml config file (#1987)
* Clean unused import

* nit

* nit: improve docstring.

* Refactor sample test into digesting params from config yaml files.

* Fix argument assignment.

* Fix path.

* Fix output params. Not every test is using it.

* Add output placeholder in yaml config.

* Fix yaml config.

* Minor fix.

* Minor fix.

* Move timeout info to config.yaml, too

* Fix import in check_notebook_results.py

* Add type hints in config.yaml

* Remove redundant close.
2019-08-29 16:29:55 -07:00
Jiaxiao Zheng e58ba48eac
Refactor check_notebook_results.py into python module. (#1947)
* Refactor check_notebook_results.py into python module.

* Fix indentation.

* Fix indentation.

* Fix indentation.

* Fix indentation.
2019-08-26 18:05:04 -07:00
Jiaxiao Zheng b476a848d9
Refactor sample tests configuration to reduce the efforts of adding samples. (#1730)
* Remove redundant import.

* Simplify sample_test.yaml by using withItem syntax.

* Simplify sample_test.yaml by using withItem syntax.

* Change dict to str in withItems.

* remove redundant sed options.

* Fix format/style issues

* [WIP] Refactor repeated logic into two utility functions.

* [WIP] Add a utility function to validate the test results from a notebook test.

* [WIP] Refactor test cases (except for notebook sample tests) into adopting utility functions.
TODO: Need to move the functions of run_*_test.py into a unified run_sample_test.py.

* [WIP] Fix a typo in test name and incorporate tfx-cab-classification, kubeflow-training-classification, xgboost-training-cm and basic ones into one run_sample_test.py

* Fix/add some comments.

* Refactor notebook tests into using utility functions

* lint

* Unify naming in sample_test.yaml

* Remove old *_test.py files

* Fix tests by fixing test names.

* Fix string formatting, per Ark-kun's comment.

* Fix names of papermill-generated python notebook.

* Fix tests

* Fix test by fixing experiment names, and test names in yaml.

* Fix test by fixing experiment names.

* Fix dsl type checking test that does not require experiment set-up.

* Remove redundant commands and usage of ipython

* Revert "Remove redundant commands and usage of ipython"

This reverts commit 23a0e014

* Remove redundant string subs and edit an AI.

* Move image name injection to a utility function to improve readability.

* Revert lint changes of check_notebook_results.py

* Unify test case naming convention to underscore.

* Fix .py name

* Fix README.md

* Fix test

* Add TODO items.

* Add a utility function to inject kubeflow_training_classification python sample file.

* Fix redundant cd command.

* Fix indentation.

* Fix test names in component_test.yaml

* Remove redundant clean_cmle_models.py

* Fix nit problem.

* Fix comment.
2019-08-09 12:27:37 -07:00
Ning 06e544ba8c add type checking sample to sample tests (#1129)
* add type checking sample to sample tests

* Dadd the test script exit code to the sample test result; update the check_notebook_result script to not validate the pipeline runs when experiment arg is not provided

* fix typo
2019-04-11 21:40:45 -07:00
Ning 2118baf752 Fix sample test failure (#548)
* enable debug mode

* add gcp secret to tfdv; add tensorflow installation in lightweight sample test

* disable debug mode

* update the args in check_notebook_results

* change tfdv output schema

* typo fix

* update roc image in tfx sample test

* update confusionmatrix image in the tfx sample test
2018-12-19 08:55:29 -08:00
Ning 886e113f78 Improve get_experiment and list_runs in the python sdk (#508)
* add get_experiment_id and list_runs_by_experiment

* offer only one get_experiment function

* return experiment body instead of id

* simply codes

* simply code 2

* remove experiment_id check in the while loop

* minor bug
2018-12-11 22:02:24 -08:00
nealgao ad1950b8e6 Add notebook sample test: tfx sample (#470)
* add notebook sample tests for tfx

* parameterize component image tag

* parameterize base and target image tags

* install tensorflow package for the notebook tfx sample test

* bug fixes

* start debug mode

* fix bugs

* add namespace arg to check_notebook_results, copy test results to gcs, fix minor bugs
add CMLE model deletion

* install the correct KFP version in the notebook; parameterize deployer model name and version

* fix CMLE model name bug

* add notebook sample test in v2

* add gcp sa in notebook tfx sample and shutdown debug mode

* import kfp.gcp
2018-12-07 10:49:30 -08:00