Commit Graph

340 Commits

Author SHA1 Message Date
dependabot[bot] 710c664660
Bump websocket-extensions from 0.1.3 to 0.1.4 in /frontend (#3929)
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/faye/websocket-extensions-node/releases)
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-06-08 00:47:46 -07:00
Jiaxin Shan 3cae116992
Generate clickable artifact url for s3 URI (#3531)
* Generate clickable artifact url for s3 URI

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

* Format code using prettier@1.19.1

* Fix unit test failure

* Use encoded string in bucket url
2020-05-30 21:11:53 -07:00
Yuan (Bob) Gong 508f31aa0f
[UI] Also cloning recurring run schedule, fixes #3761 (#3840)
* [UI] Also cloning recurring run schedule

* Fix unit test for trigger and utils

* Add and fix unit tests for Trigger

* Add NewRun page unit tests

* Fix unit tests

* Fix jest test timezone
2020-05-25 05:03:12 -07:00
Yuan (Bob) Gong 0199de0cd0
[UI] Fix confusion matrix wrong axes (#3817)
* [UI] Fix confusion matrix wrong axes

* Fix confusion matrix background opacity
2020-05-22 00:18:38 -07:00
Yuan (Bob) Gong 61960efb87
Add probes to metadata grpc service (#3765)
* Add probes to metadata grpc service

* Fix port name length limit

* Update README.md
2020-05-14 13:50:59 -07:00
Yuan (Bob) Gong 5435e8724f
[UI Server] Refactor for configurable auth header (#3753)
* [UI] Make auth header configurable

* Refactor authorizeFn to move side effects out

* Refactor tests to reduce duplication
2020-05-12 22:06:25 -07:00
Yuan (Bob) Gong bb0c4d9805
[UI] Show tooltip on long version names (#3750)
* [UI] Show tooltip on version name in selector

* Update snapshots

* Add tooltip for pipeline version in run list

* refactor code
2020-05-12 20:38:26 -07:00
Yuan (Bob) Gong 06cd029af9
[UI] Fix artifact preview with outdated content (#3749)
* Fix preview with outdated content

* Update snapshot
2020-05-12 19:50:26 -07:00
Yuan (Bob) Gong bd4be88705
[UI] Wrap parameter/urls on overflow (#3747)
* [UI] Wrap parameter/urls on overflow

* Add comment about css

* Let artifact preview take over full width
2020-05-12 17:14:26 -07:00
Yuan (Bob) Gong e8356bc37a
Show version tag in UI (#3743)
* Show version tag in UI

* Add new arguments to test cloudbuild configuration

* backend cloudbuild should use commit_sha as argument

* Fix minor bug during dev
2020-05-12 11:02:21 -07:00
Eterna2 e57a61916c
Fix bug in #3707 - href should show full artifact content instead of preview (#3745) 2020-05-12 05:00:20 -07:00
Eterna2 30345d1d49
[frontend] Show artifact preview in UI (#2172) (#3707)
* show a preview of an artifact in the ui

* Add styling to preview box

* fix minor typo in unit test

* minor fixes + DetailsTable now accepts a ValueComponent again

* encode uricomponent for generate artifact url

* fix classname typo

* Added valueComponentProps for DetailsTable for better type checking.

* fix mock bug in test. peek -> maxbytes & maxlines for MinioArtifactPreview

* fix format

* mock Editor
2020-05-11 19:42:24 +08:00
Yuan (Bob) Gong b1c9976627
[UI] Make visualization tab easier to understand (#3717)
* Rename artifacts tab to visualizations and add documentation link

* Show a banner when no visualizations

* Clean up code

* Update snapshots

* Fix banner tests

* Add unit test for visualization creator

* Update VisualizationCreator.tsx

* Update VisualizationCreator.tsx
2020-05-08 21:53:51 -07:00
jingzhang36 fe019088e5
remove an accidentally committed debugging log (#3716) 2020-05-09 11:22:15 +08:00
Yuan (Bob) Gong cb41f7ab12
[UI] Cleanup, remove types from urls in artifact/execution details page (#3715)
* Remove types from urls in artifact/execution details page

* Remove unused route params

* Fix snapshot tests
2020-05-08 03:11:42 -07:00
Yuan (Bob) Gong c5ceaf51a3
[UI] Hide empty resource op manifest tab in run details page (#3713)
* Hide manifest tab when empty

* fix unit tests

* Fix tests
2020-05-08 02:13:43 -07:00
Yuan (Bob) Gong eab5d31781
[UI] Improve TFX artifact visualization speed (#3712)
* Improve TFX artifact visualization speed

* Update OutputArtifactLoader.ts

* Fix loading

* Add nodeId back as an identifier
2020-05-08 01:11:42 -07:00
Yuan (Bob) Gong e5bd2df3e8
[UI] textbox to select KSA when creating runs/jobs (#3651)
* Add service account field to run and job api objects

* Update description

* Fix field casing

* Use service account from api object

* Fix bug and add unit test

* [UI] Allow choosing Kubernetes service account

* fix unit tests

* fix format

* Also clone service account

* service account UI features

* Add unit test for cloning service account

* Fix frontend integration tests
2020-05-06 20:39:09 -07:00
jingzhang36 fd7cb1ce96
Experiment archiving related UI changes (#3615)
* archive button to experiment details page

* list of archived exp

* remove a prop

* restore; new run only in unarchived experiment

* in all experiments tab, only unarchived ones are listed

* refine dialog messages; disable selection of runs in archived experiment list

* unit test for experiment list component

* more unit tests

* remove unnecessary methods and props

* using tabs instead of radio buttons to switch between archived runs and archived experiments

* added tests

* fix rundetails test

* add tests

* sidenav snapshot

* sidenav snapshot update

* address comments

* format
2020-05-06 00:15:08 -07:00
Yuan (Bob) Gong 44abf2199d
Update @kubeflow/frontend with fixes for #3625 and #3648 (#3695) 2020-05-05 22:17:08 -07:00
Yuan (Bob) Gong cb71eed5f9
[UI] authorize tensorboard actions (#3639)
* Authorization service proto

* implement auth service

* Add unit tests

* Generate auth api client

* Authorization checks for tensorboard apis

* UI Server authorization checks

* Clean up error parsing

* Revert changes

* Fix portable-fetch not found bug

* Fix unit test

* Include portable-fetch required by api client

* Fix portable-fetch module import error

* Fix portable-fetch again

* Add unit tests

* Address CR comments

* add unit test for header

* Update readme
2020-04-28 15:26:24 -07:00
Dmitry B a5b3e7e3f0
Fix source for mlpipeline-ui-metadata in WorkflowParser (#3379)
* WorkflowParser->loadNodeOutputPaths
source: s3.endpoint === 's3.amazonaws.com' ? StorageService.S3 : StorageService.MINIO

* Use isS3Endpoint (server/aws-helper.ts) to identify artifact source

* npm run format

* created src/lib/AwsHelper.ts (for frontend code), because frontend client and frontend server do not share code for now.
2020-04-28 09:42:06 -07:00
Yuan (Bob) Gong f214a39420
[UI] Fix artifact url for multi namespace (#3605)
* Regenerate and use new visualization api

* [UI] Support namespaced visualization api

* Fix minio artifact link

* Fix tests
2020-04-25 20:33:28 -07:00
Yuan (Bob) Gong 84b77c7696
[UI] get run id from both property and custom property (#3501)
* [UI] Groups executions by run if it exists

* Get run_id from both custom property and property
2020-04-25 02:53:28 -07:00
Yuan (Bob) Gong 69efa6233d
[UI] Show cached steps (#3602)
* [UI] Show cached steps

* Tests for parseNodePhase

* Complete unit tests

* Update StatusUtils.test.tsx
2020-04-24 02:56:07 -07:00
Yuan (Bob) Gong 0b17641217
[UI] Migrate to namespaced visualization request (#3603)
* Regenerate and use new visualization api

* [UI] Support namespaced visualization api
2020-04-24 01:08:06 -07:00
Yuan (Bob) Gong b7706c0134
[UI Server] Enable strict type checking and fix errors (#3593)
* wip

* Fix typing

* Fix build error

* Add type checking to tests

* Fix server typing

* Clean up

* Fix server typing
2020-04-23 09:25:11 -07:00
Jonas De Beukelaer 264953c108
[UI] fix - create run missing-param warning not reacting to param value changes (#3559) 2020-04-23 00:05:45 -07:00
Yuan (Bob) Gong 1dad677d2d
[UI] Get execution details from metadata writer (#3553) 2020-04-22 23:17:44 -07:00
Yuan (Bob) Gong 09b506fc1a
[UI] Multi user permission separation for artifact api (#3522)
* [UI Server] Proxy /namespaces/:namespace/artifacts/get requests to namespace specific artifact services

* [UI] Show artifacts by namespace

* Fix minio artifact link tests

* Fix DetailsTable tests

* Fix OutputArtifactLoader.test

* Change artifact proxy to use query param instead

* Add integration tests for artifact proxy

* Fix unit tests

* Rename service name

* Add comment

* add more comments

* Fix import

* Refactored how to spy on internal methods from tests
2020-04-22 22:31:45 -07:00
jingzhang36 56d519e9f7
Add archive experiment feature in backend (#3359)
* add new field in db schema and api schema

* auto genereted types for experiment storage state

* add archive and unarchive methods to backend for experiments.

* auto generated archive/unarchive methods for epxeriments

* add archive and unarchive to client

* set proper storage state when creating experiment

* retrieve storage state when we get/list epxeriment(s)

* change expection in test to have storage state

* add storage state in resource manager test

* revise experiemnt server test

* revise api converter test

* integration test of experiment archive

* archive/unarchive experiment affect the storage state of runs in it

* test all the runs in archive/unarchive experiment

* test all runs are archived/unarchived with their experiment in experiment server

* integration test

* integration test: value type mismatch in assertion

* unused import; default value for storage state

* autogen code for frontend

* reorder the fields in api experiment schema

* switch the position of the two enum to verify a hypothesis

* Put a place hodler to prevent any valid item to take the value 0

* Get rid of the place holder since the cause of issue related to value 0 is found and fixed.

* The returned api experiment now has storage state field

* create experiment return doesn't contain storege state

* Cleanup needs to clean runs and pipeliens now

* a missing client

* use resource reference as fileter instead of experiment uuid

* use same namespace in archive unit test

* Leave archive/unarchive experiment integration test to a separate PR

* also need to update jobs when experiments are archived

* Change of unarchiving logic. When experiment is unarchived, jobs/runs in
it stay archived

* add unit test for the job status in archived/unarchived experiment

* change archive state to 3 value enum; add experiment integration test

* make archive state 3 value enum to avoid 0 value mapped to available; add integration test

* run swagger autogen

* fix an expected value

* fix experiment server test

* add job check in experiment server test

* update job crds

* fix a typo

* remove accidentally included irrelevant changes
2020-04-16 07:31:09 +08:00
Yuan (Bob) Gong 2200268f5c
[UI] Groups executions by run if it exists (#3485) 2020-04-13 23:05:10 -07:00
Yuan (Bob) Gong 32fff03c20
[UI] Redirect to experiment list page when namespace changes in RunDetails or Compare page (#3483)
* Redirect to experiment list page when namespace changes

* Fix namespace initialize case

* Update KubeflowClient.tsx
2020-04-09 19:17:47 -07:00
Yuan (Bob) Gong 6b358d09a7
[UI] Show execution details in Run Details Page ML Metadata tab of steps (#3457)
* ML metadata tab in run details page

* Show execution details UI in run details step tab

* Fix tests

* Revert unnecessary changes
2020-04-08 21:53:44 -07:00
Yuan (Bob) Gong 4302f1e2f1
[Frontend] Fix npm reported vulnerabilities (#3480)
* Fix server vulnerability

* Fix vulnerability in frontend

* Fix frontend vulnerabilities

* pin webpackv ersion
2020-04-08 21:09:43 -07:00
Yuan (Bob) Gong 100369a75b
[UI - multiuser] Fix pod log namespace source (#3477)
* Fix pod log namespace source

* Fix unit tests
2020-04-08 00:47:44 -07:00
Yuan (Bob) Gong a38a46c26c
[UI] No longer pass namespace to createRun api (#3403) 2020-04-01 21:04:23 -07:00
Yuan (Bob) Gong 47cde0b6b9
[UI] Tensorboard support for multi user (#3355)
* [UI Server] Add namespace argument for tensorboard endpoints

* Allow local node server to talk to minio in cluster

* Use tensorboard namespace in UI

* Add unit tests for tensorboard UI server

* Fix tests

* Fix tensorboard proxy url

* Fix tensorboard proxy failure

* Fix tests

* Remove unecessary encodeURIComponent

* Add old comment back
2020-03-26 19:50:22 -07:00
Rafael Barreto c33150f434
Fix tensorboard image parsing (#3356)
I introduced a bug when parsing the image for Tensorboard in
https://github.com/kubeflow/pipelines/pull/3235. This fixes it.
2020-03-24 23:35:02 -07:00
Yuan (Bob) Gong fe78e1efa1
[UI] Add namespace filter for All and Archived Runs page (#3351)
* [UI] Stops experiment list from leaking previous error message

* Move the fix to Page component so it's more generic

* [UI] Add namespace to AllRunsList api request

* [UI] Add namespace to archived run page

* Fix snapshot
2020-03-24 19:41:02 -07:00
Yuan (Bob) Gong 124067a58d
[UI] Stops experiment list from leaking previous error message (#3350)
* [UI] Stops experiment list from leaking previous error message

* Move the fix to Page component so it's more generic

* Update ExperimentList.test.tsx
2020-03-24 18:45:02 -07:00
Yuan (Bob) Gong 0ef074239d
[UI Server] Blocks non public KFP report APIs (#3334)
* [UI Server] Blocks reportMetrics KFP api

* Also reject report workflow endpoint

* Also block report swf endpoint
2020-03-23 23:34:47 -07:00
Eterna2 a7606a12de
kfp UI node server support preview and handles gzip, tarball, and raw artifacts in a consistent manner. (#2992) 2020-03-23 22:30:47 -07:00
Yuan (Bob) Gong f882f361cc
[UI] Show step pod yaml and events in RunDetails page (#3304)
* [UI Server] Pod info handler

* [UI] Pod info tab in run details page

* Change pod info preview to use yaml editor

* Fix namespace

* Adds error handling for PodInfo

* Adjust to warning message

* [UI] Pod events in RunDetails page

* Adjust error message

* Refactor k8s helper to get rid of in cluster limit

* Tests for pod info handler

* Tests for pod event list handler

* Move pod yaml viewer related components to separate file.

* Unit tests for PodYaml component

* Fix react unit tests

* Fix error message

* Address CR comments

* Add permission to ui role
2020-03-20 02:42:38 -07:00
Yuan (Bob) Gong ec41c6964b
[UI] Delete manifest.json (#3320)
* Delete manifest.json

* Update index.html
2020-03-19 23:30:36 -07:00
Yuan (Bob) Gong 47940d656d
[UI] Auto refresh/redirect experiment list/detail page when user selects a different namespace (#3297)
* [UI] Auto refresh/redirect experiment list/detail page when namespace changes

* Add comments

* Address CR comment
2020-03-18 19:32:43 -07:00
jingzhang36 01074dc799
Add Deletion button to archived runs (#3285)
* addd delete button to archived run page

* unit test

* comments

* address comments

* remove unintended console log in test
2020-03-18 03:14:47 -07:00
Yuan (Bob) Gong 0dca4fe8b4
[UI] Pass namespace to experiment api calls (#3252)
* Regenerate frontend api client

* [UI] Add namespace resource reference to experiment api call

* Pass namespace to experiment list api call

* Add namespace to NewRun page api calls
2020-03-17 00:18:21 -07:00
Yuan (Bob) Gong b0e933b029
[Frontend] Fix reported vulnerabilities (#3281) 2020-03-15 22:22:35 -07:00
Rafael Barreto 23fb4618ae
Parametrize the image used for the Tensorboard viewer (#3235)
* Parametrize the image used for the Tensorboard viewer

Right now, the image is hard-coded and it's not possible to override it.
This is a problem when running Kubeflow Pipelines in a cluster without
access to the internet or public repositories (e.g.
https://github.com/kubeflow/pipelines/issues/3232). This solves the
issue by parametrizing the image name through an environment
variable.

* Fix formatting issues

* Address review comments
2020-03-15 20:36:35 -07:00