Commit Graph

5 Commits

Author SHA1 Message Date
Alexey Volkov dd1bb7fe57 SDK - Compiler - Fixed failures on Jinja placeholders (#2522)
Also fixes handling other cases with double curly braces.
2019-10-31 19:03:24 -07:00
deepio-oc 6e4f423e7f SDK - Compiler - Fix bugs in the data passing rewriter (#2297)
* fix for #2295

* fix for #827
2019-10-07 17:03:47 -07:00
Alexey Volkov 181de66cf9 SDK - Compiler - Move Argo volume specifications to templates (#2229)
* SDK - Compiler - Move volumes to templates

Argo v2.3.0+ supports per-template volume specs similiar to Kubernetes. Prior to version 2.3.0 Argo only supported workflow-level volume specs.
We had several outstanding issues caused by the need to put all volumes in the same place.
There was also the issue with input parameter reference placeholders in volume specifications which were placed outside their home templates declaring the inputs.

 This change fixes those issues.

* Removed dead code line
2019-10-07 16:55:12 -07:00
Alexey Volkov 66be0161be
SDK - Compiler - Fixed small bug in data passing rewriter (#2259) 2019-09-30 21:45:27 -07:00
Alexey Volkov ef63c653af SDK - Compiler - Fix large data passing (#2173)
* SDK - Compiler - Fix large data passing

Stop outputting parameters unless they're consumed as parameters downstream.
This prevents the situaltion when component outputs a big file, but DSL compiler instructs Argo to pick it up as parameter (parameters only hold few kilobytes of data).

As byproduct, this change fixes some minor compiler data passing bugs where some parameters were being passed around, but never consumed (happened with `ResourceOp`, `dsl.Condition` and recursion).

* Replaced ... with `raise AssertionError`

* Fixed small bug

* Removed unused variables

* Fixed names of the mark_upstream_ios_of_* functions

* Fixed detection of parameter output references

* Fixed handling of volumes
2019-09-20 15:05:27 -07:00