Commit Graph

169 Commits

Author SHA1 Message Date
Redback 9281ea1341 Updated README Swagger CodeGen version (#2228) 2019-09-24 22:49:59 -07:00
Yuan (Bob) Gong 7659e238bf Execution detail page shows inputs and outputs (#2155)
* Utils to convert metadata api from callback paradigm to promise paradigm

* Show input and output in execution details page

* Change execution detail page input/output table styling

* Make artifact names in execution detail page a deep link

* Change deep link to artifact ID instead

* Fix absolute import

* Fix lint errors
2019-09-20 07:57:00 -07:00
Yuan (Bob) Gong 0a38ced70a Make gs:// links in metadata UI point to GCS console page (#2167)
* Add gcloud console link for gs:// uris on artifact list page

* Make every gs:// link clickable

* Fix compile error
2019-09-20 07:25:00 -07:00
Renmin 29bbe1198f add us to OWNERS for SHA (#2047)
* add owner

* updated owners per comment, keep at least one from SHA for easy co-operation

* limit OWNERS scope first
2019-09-19 13:50:58 -07:00
Yuan (Bob) Gong a687573b47 Pretty print json value in execution/artifact detail page (#2165)
* Pretty print json property values in ResourceInfo

* Remove console.log
2019-09-18 22:59:14 -07:00
Yuan (Bob) Gong 08f471659e Add URI to artifact details page (#2157) 2019-09-18 22:58:59 -07:00
Yuan (Bob) Gong 4d9a4e8ed9 Utils to convert metadata api from callback paradigm to promise paradigm (#2153) 2019-09-17 23:39:29 -07:00
Yuan (Bob) Gong 2106c8fee5 Fix missing execution name in execution list page. (#2135) 2019-09-17 17:47:29 -07:00
Yuan (Bob) Gong 4166e7afee Artifact list column creation time (#2105)
* Add artifact creation date in artifact list UI

* Clean up code

* Basic error handling for artifact list page creation time fetching.
2019-09-16 22:44:22 -07:00
Yuan (Bob) Gong 2159a8d7a0 Fix execution detail page fetch params. (#2127)
* Fix execution detail page fetch params.

* Fix lint warnings
2019-09-16 02:48:37 -07:00
Yuan (Bob) Gong 49834c4120 Workaround error thrown from metadata server when there is no record (#2126) 2019-09-16 00:48:37 -07:00
Yuan (Bob) Gong 33f4244384 Add script that automatically proxies backend servers for frontend dev server (#2104)
* Add npm run dev script that automatically proxies both backend and mlmd servers.

* Add more comments + rename command to reflect what it does

* Add error handling for pod discovery

* Make npm run start:proxies a separate command

* Update README about new script too
2019-09-15 22:58:36 -07:00
Kirin Patel 58453151d5 Add warning message when there are empty parameters in NewRun.tsx (#2016)
* Added warning message to NewRun.tsx when a pipelines has empty parameters

* Updated existing test snapshots

* Created unit tests for new missing parameters message
2019-09-11 10:32:48 -07:00
Alexey Volkov 570141d7c9 Make wget quieter (#2069) 2019-09-09 14:32:54 -07:00
Riley Bauer 0c27a04e52 Add execution list and details pages (#2059)
* Adds execution list and details pages

* Simplifies envoy dockerfile

* Add routing

* Update tests
2019-09-06 22:31:18 -07:00
Riley Bauer 8d196d4dec Adds Metadata Artifacts to UI (#2057)
* Working, though the request seems malformed

* Working with grpc-web. trying to push to cluster

* WIP

* With great hax come great success

* Begin moving some metadata UI pages to KFP

* Artifact list and details pages work! A lot of clean up is needed. Look for console.log and TODO

* Clean up

* Fixes filtering of artifact list

* More cleanup

* Revert ui deployment

* Updates tests

* Update envoy deployment
2019-09-06 13:19:19 -07:00
Kirin Patel 3cbbd87021 Fix ROC Curve visualization argument placeholder (#2002)
* Updated ROC curve argument placeholder

* Updated snapshot

* Fixed method of obtaining values from variables dict for ROC curve visualization
2019-08-30 12:48:16 -07:00
Kirin Patel c5d2f68655 Add frontend support for Python based visualizations (#1959)
* EOD Push

Most work on feature is completed. Currently attempting to fix bug where UI does not properly render visualizations for selected component.

* Fixed bug where switching selected node would not update visualizations in artifacts tab

* Remove debugging code

* Updated RunDetails.test.tsx.snap

* Addressed PR comments

* Improved error message readability
2019-08-29 10:31:56 -07:00
Kirin Patel 6827a2c977 Remove TFMA from frontend (#1986) 2019-08-28 18:51:55 -07:00
Kirin Patel 32ed27a98f Add endpoint to allow custom visualizations (#1931)
* Added support for custom visualizations to the VisualizationCreator component

* Add support for enabling/disabling custom visualizations

* Added mock-backend support for new api endpoint

* Changed allowCustomVisualization to be a prop
2019-08-26 14:22:37 -07:00
Kirin Patel 3d69062e13 Add custom visualization support for Python based visualizations (#1929)
* Added custom visualization type

* Added support for custom visualizations to the VisualizationCreator component

* Re-generated API

* Updated VisualizationCreator.test.tsx.snap

* Updated VisualizationCreator.test.tsx tohave new and more specific tests

* Added tests to ensure Editor component is visible when specifying visualization type
* Updated test to properly validate provided source is rendered

* Added unit test to ensure that an argument placeholder is provided for every visualization type

* Fixed linting error

* Simplified canGenerate logic
2019-08-25 15:10:20 -07:00
Kirin Patel 5abba6695b Add pipeline id to pipeline summary card (#1927)
* Added pipeline id to pipeline summary card

* Updated PipelineDetails.test.tsx.snap
2019-08-22 14:45:18 -07:00
Kirin Patel 3c8952e6bf Add TFDV, TFMA, and Table visualization support for Python based visualizations (#1898)
* Added table and tfdv visualization

Also fixed issue surrounding ApiVisualizationType enum

* Fixed table visualization

* Removed byte limit
* Fixed issue where headers would not properly be applied
* Fixed issue where table would not be intractable

* Updated table visualizaiton to reflect changes made to dependency injection

* Fixed bug where checking if headers is provided to table visualizations could crash visualization

* Added TFMA visualization

* Updated new visualizations to match syntax of #1878

* Updated test snapshots to account for TFMA visualization

* Small if statement synax changes

* Add flake8 noqa comments to table.py and tfma.py
2019-08-22 13:57:20 -07:00
Eterna2 af456bcc61 [front-end-server] Allow viewer:tensorboard podTemplateSpec to be customizable (#1906)
* Allow front-end server to provide custom viewer podTemplateSpec via path/configmap

* Fix JSON.parse input to string
2019-08-22 11:08:33 -07:00
Kirin Patel 41d39c17a2 Add run with json data as input within fixed-data.ts for UI testing and development (#1895)
* Added run with json data as input

* Changed run and uid to not be duplicates of hello-world-runtime
2019-08-21 19:38:31 -07:00
Kirin Patel 851e7c80d2 Replace codemirror editor react component with react-ace editor component (#1890)
* Replaced CodeMirror with Editor in PipelineDetails.tsx

* Replaced codemirror in DetailsTable with react-ace

* Removed codemirror

* Updated unit tests for Editor.tsx to test placeholder and value in simplified manner

* Updated DetailsTable.test.tsx.snap to reflect changes made in DetailsTable.tsx

* Updated PipelineDetails test snapshot

* Changed width of Editor in DetailsTable to be 100% instead of 300px

* Revert "Updated unit tests for Editor.tsx to test placeholder and value in simplified manner"

This reverts commit 40103f2e01.
2019-08-21 19:04:31 -07:00
Kirin Patel 7b442f4a54 Created extensible code editor based on react-ace (#1855)
* Created extensible code editor based on react-ace

* Installed dependencies

* Updated unit tests for Editor.tsx to test placeholder and value in simplified manner

* Updated Editor unit tests to use snapshot testing where applicable
2019-08-20 18:27:19 -07:00
Riley Bauer d2e94e4e04 Fix run duration bug (#1827)
* Allows durations >=24h and renames 'showLink' in RunList

* Update, fix tests
2019-08-15 19:52:34 -07:00
Kirin Patel afe8a694f6 Reduce API usage by utilizing reference name in reference resource API (#1824)
* Regenerated run api for frontend

* Added support for reference name to resource reference API in frontend

* Revert "Regenerated run api for frontend"

* Addressed PR comments

* Removed extra if statement by setting default value of parameter

* Removed the whole comment

* Addressed PR feedback

* Addressed PR feedback

* Simplified logic after offline discussion
2019-08-15 17:00:28 -07:00
Riley Bauer 0517114dc2 Reduce getPipeline calls in RunList (#1852)
* Skips calling getPipeline in RunList if the pipeline name is in the pipeline_spec

* Update fixed data to include pipeline names in pipeline specs

* Remove redundant getRuns call
2019-08-15 12:28:35 -07:00
IronPan 39e5840f2f Add retry button in Pipeline UI (#1782)
* add retry button

* add retry button

* add retry button

* address comments

* fix tests

* fix tests

* update image

* Update StatusUtils.test.tsx

* Update RunDetails.test.tsx

* Update Buttons.ts

* update test

* update frontend

* update

* update

* addrerss comments

* update test
2019-08-15 11:04:34 -07:00
Riley Bauer 2d6a314e54 All tests passing (#1812) 2019-08-12 15:33:40 -07:00
hongye-sun c5418fdb46 Fix github security alert. (#1798) 2019-08-11 14:25:10 -07:00
Yasser Elsayed 4ec770a70f Remove yebrahim from approvers/reviewers (#1787)
* Update OWNERS

* Update OWNERS

* Update OWNERS
2019-08-09 12:22:52 -07:00
Riley Bauer 66883b0eed Fixes cloning of recurring runs (#1712)
* Fixes cloning of recurring runs

Simplifies NewRun a little

Creates NewRunParameters component

* Fixes all NewRun tests

* All tests pass

* Adds tests for NewRunParameters

* Adds clone test to RecurringRunDetails

* Clean up
2019-08-06 07:09:54 -07:00
Kirin Patel fa1abde7f6 Rename InputPath -> Source for Visualization API definition (#1717)
* InputPath -> Source

* Changed name of data path/pattern variable from InputPath to Source to improve consistency with current visualization method
* Updated unit tests to reflect name change
* Regenerated swagger definitions to reflect name change

* Readded test that was removed with previous commit

It was deleted by mistake
2019-08-05 10:55:50 -07:00
Kirin Patel f3de0c415d Add new PlotType to Allow for Visualization Creation (#1677)
* Added VisualizationCreator as new PlotType

* Addressed PR feedback made by @rileyjbauer

* Fix issue where updated props would not be accessible to VisualizationCreator

View [comment](https://github.com/kubeflow/pipelines/pull/1677#discussion_r307490016) for more details

* Updated select and input fields to become disabled when isBusy is true

* Updated test names to be more descriptive

* Fixed bug where enum key was used rather than enum value when determining ApiVisualizationType
2019-07-26 12:05:57 -07:00
Kirin Patel a4813fffb8 Added visualization API service to frontend (#1675) 2019-07-25 11:10:05 -07:00
Kirin Patel 82391f4d1d Add visualization swagger files to frontend (#1663)
* Generated visualization swagger files for frontend

* Changed swagger codegen cli version from 2.4.1 to 2.3.1

Regenerated visualization API with swagger codegen cli version 2.3.1
2019-07-24 19:39:51 -07:00
Riley Bauer e059511a08 Sets min widths for buttons to avoid text wrapping (#1637)
* Sets min widths for buttons to avoid text wrapping

* Update tests
2019-07-24 13:35:52 -07:00
Riley Bauer befb547c6e Add recurring run column to run lists (#1635)
* Adds recurring run column to run list with link to run config

* Adds tests

* Show recurring run ID

* Update snapshots
2019-07-22 13:04:54 -07:00
Riley Bauer 48c46bd1fb Trims whitespace from pipeline params on creation of new run (#1605) 2019-07-17 10:26:36 -07:00
Kirin Patel c7d19f0302 Removed duplicate CircularProgress within UI (#1625)
* Removed duplicate CircularProgress

Previously, there was a CircularProgress to indicate that the UI is busy within the [RunDetails.tsx](24aae0d082/frontend/src/pages/RunDetails.tsx (L213)) and [SidePanel.tsx](a8b9107878/frontend/src/components/SidePanel.tsx (L81)). This removes the CircularProgress from RunDetails.tsx.

* Updated test snapshot
2019-07-16 11:32:47 -07:00
jingzhang36 22ccc91538 Set user credentials when creating viewer object (#1603)
* Specify user credentials properly in our viewer crd.

* remove unnecessary import
2019-07-09 14:02:26 -07:00
Derek Hao Hu 24aae0d082 Use GCP external Stackdriver links (#1552)
* Use GCP external Stackdriver links

* Update snapshot tests
2019-06-26 13:39:22 -07:00
Riley Bauer 3ccc22ccb5 Add metrics table to run details page, run outputs tab (#1530)
* Adds metrics table to run outputs

* Clean-up and tests

* WIP adding titles to run outputs

* Clean up
2019-06-20 16:48:36 -07:00
jingzhang36 bf6fee9bbb Add a helper function to create tensorboard crd (#1237)
* Add a helper function to create a tensorboard crd.

* Add a helper function to create a tensorboard crd.

* Remove optional parameter "pretty".

* Reuse constants when possible

* createTensorboardInstance, getTensorboardInstance, waitForTensorboardInstance

* Revise getTensorboardHandler and createTensorboardHandler to use getTensorboardInstance
and createTensorboardInstance

* remove trailing spaces

* Fix comment

* Ajust paremeter values.

* stringfy error objects; change 'plural' to 'viewer'

* Change 'plural' to 'viewers'

* Use derived namespace (instead of hardcoded kubeflow) to create viewer
 CRD. Derive viewer CRD's name from log dir.

* Adjust local dns

* Add GCP credentials for viewer resource.

* Address pr reviews

* auto formatting

* 1. viewer controller propagates credentials when creating pod
2. set credentials in viewer crd

* Put credentials info in PodTemplateSpec

* Cleanup not-to-be-included changes.

* Empty line

* Formatting

* Remove a duplicate include

* add crypto-js dependency

* Add path prefix

* Update k8s-helper.ts

* (1) set viewer service port be 6006 (2) trailing / is required for tensorboard path

* Remove url address encoding

* Remove an accidental change

* Formatting

* Add comment and TODO

* Change 6006 back to 80

* Remove deprecated functions from k8shelper. Revise some comments.

* Use getNamespacedCustomobject

* Try to fix unit test for the tensorboard.tsx change

* Re-arrange func order

* Polish comments

* When there is no existing tensorboard, GetNamespacedCustomObject's promise is reject, and in case of that reject, use ''
2019-06-20 13:00:36 -07:00
Alexey Volkov cd0aeb6c62 SDK+Frontend - Fixed the task display name annotation key (#1526)
Turns out, Kubernetes only allows a single slash character in annotation key.
2019-06-18 14:50:33 -07:00
Alexey Volkov 7d69cda69c
Frontend - Show customized task display names (#1463)
* Frontend - Show customized task display names

* Added customized name test

* Added ContainerOp.set_display_name(name) method

* Stopped writing human_name to display_name annotation for now
Reason: It's a change to existing pipelines.

* Added test for op.set_display_name

* Fix for tests that have workflows with status nodes, but without any spec or templates

* Fixed the test workflow

* Fix linter error
Error: "The key 'metadata' is not sorted alphabetically"
2019-06-06 17:36:32 -07:00
Riley Bauer 918f197c0e Updates Google Cloud Storage and pins axios version (#1415)
* Updates Google Cloud Storage and pins axios version

* Small fix
2019-06-03 18:07:01 -07:00