Commit Graph

1350 Commits

Author SHA1 Message Date
Ning fae0361fbf fix bug: list is not expecting keyword arg (#2107) 2019-09-13 13:54:29 -07:00
Ning 4f46720c1c Release 1449d08aee (#2099)
* Updated component images to version 1449d08aee

* Updated components to version e7a021ed1d
2019-09-13 11:14:31 -07:00
Ning 06aeb0a052
update sdk versions (#2100) 2019-09-13 10:15:44 -07:00
dushyanthsc 22eb915b4c gcp-marketplace: Updating metadata deployment to use gRPC server (#2083)
Change to update gcp marketplace helm charts to use gRPC MLMD metadata
server.
2019-09-12 20:02:31 -07:00
Ning 646aa5ff64 feature parity between notebook sample and normal sample (#2095)
* feature parity between notebook sample and normal sample

* typo
2019-09-12 18:26:31 -07:00
Jiaxiao Zheng 1449d08aee Fix the logic of passing default values of pipeline parameters. (#2098)
* Fix the logic of passing default values.

* Modify unit test

* Solve.
2019-09-12 17:10:33 -07:00
IronPan 97b01b8f4a
Remove broken environment variables in namespace install (#2087)
Likely introduced by a bad merge 
https://github.com/kubeflow/pipelines/pull/1918/files#diff-4f0f86e24382decf794ec0f3d0c4c54cR672
2019-09-12 11:06:38 +08:00
Kirin Patel 58453151d5 Add warning message when there are empty parameters in NewRun.tsx (#2016)
* Added warning message to NewRun.tsx when a pipelines has empty parameters

* Updated existing test snapshots

* Created unit tests for new missing parameters message
2019-09-11 10:32:48 -07:00
Alexey Volkov 1962715688 SDK - Stop adding empty descriptions and inputs (#1969) 2019-09-11 09:58:49 -07:00
dushyanthsc 635370d256 manifests/metadata: Metadata server invocation change (#2041)
Change to update invocation to use command line parameters as against
using proto text.
2019-09-10 19:28:46 -07:00
Jiaxiao Zheng 497d016e85 Expose an API for appending params/names/descriptions in a programmable way. (#2082)
* Refactor. Expose a public API to append pipeline param without interacting with dsl.Pipeline obj.

* Add unit test and fix.

* Fix docstring.

* Fix test

* Fix test

* Fix two nit problems

* Refactor
2019-09-10 17:58:47 -07:00
Jiaxiao Zheng a4fa1edb42 Use GCSHelper to upload test result (#2078)
* Add GCSHelper in sample_test_launcher

* Remove redundant stuff
2019-09-10 09:06:55 -07:00
Alexey Volkov a3c83f50b6 SDK - Testing - Run some unit-tests in a more correct way (#2036)
* SDK - Testing - Run some unit-tests in a more correct way
Replaced `@unittest.expectedFailure` with `with self.assertRaises(...):`.
Replaced `assert` with `self.assertEqual(...)`.
Stopped producing the stray "comp.yaml" file.
Enabled the test_load_component_from_url test.

* Removed a stray comment

* Addded two tests for output_component_file
2019-09-10 08:35:05 -07:00
Kirin Patel 3726eb216c Fix bug where source and variables are not accessible to visualization (#2012)
* Fix bug where source and variables are not accessible to visualization

* Updated snapshot

* Removed test_generate_test_visualization_html_from_notebook

* Added test cases to ensure roc_curve, table, and tfdv visualizations can be generated

* Made test requirements identical to normal requirements

* Fixed source links

* Updated test_server.py to use table visualization

* Update .travis.yml

* Add logging to debug travis tests

* Add tensorflow back to requirements.txt

* Updated .travis.yml and requirements.txt, also added comment that specifies required libraries to run tests

* Testing TFDV visualization with different source

* Changed remote paths to be local due to timeout issues

* Removed visualization tests due to continued failure

* Reverted .gitignore and removed tensorflow from text_exporter pip install command

* Moved where dependencies are installed in .travis.yaml

* Revert "Made test requirements identical to normal requirements"

This reverts commit 7f11c43c44.

* Added pip install requirements to .travis file

* Removed new unit test and requirements.txt install

* Cleaned up tests and re-added test.py predefined visualization

* Cleanup
2019-09-10 08:34:53 -07:00
IronPan b7f37da23f fix (#2079) 2019-09-10 02:16:55 -07:00
Jiaxiao Zheng 30b97ddffa Fix. (#2077) 2019-09-09 19:30:53 -07:00
Ning bdb8598116 Add cmle tpu sample link (#2074)
* add CMLE tpu sample link

* revert the change

* typos
2019-09-09 18:56:54 -07:00
IronPan 715471f113 Store DB password as K8s secret for marketplace deployment (#2067)
* pass in secret

* fix

* use application name by default for database prefix

* bug fixes and bump kfp version

* Update application.yaml

* fix objectstore name

* fix objectstore name

* store db pwd as secret

* fix

* fix

* fix

* fix
2019-09-09 18:06:54 -07:00
Alexey Volkov 4e21c76364 Release - Fixed the deprecated component image build (#2063)
* Release - Fixed the deprecated component image build

* Trigger postsubmit
2019-09-09 16:26:53 -07:00
Alexey Volkov 570141d7c9 Make wget quieter (#2069) 2019-09-09 14:32:54 -07:00
Jiaxiao Zheng 7b1c720a47 Improve notebook check automation (#2040)
* Add logic to detect extension name.

* Rename notebook samples

* Change to use config yaml for papermill preprocess.

* Remove ad hoc logic

* Remove duplicated logic

* Refactor

* Add run_pipeline flag in config yaml

* Add run pipeline flag for .py sample as well.

* Fix extension name

* Fix

* Fix problems in docstring.

* refactor run_sample_test.py into two functions

* Refactor the procedure into 3 steps

* Fix bug in exit code format

* Remove two redundant functions.
2019-09-09 13:40:55 -07:00
IronPan 0d81785466 Chang object store naming for marketplace deployment (#2066)
* pass in secret

* fix

* use application name by default for database prefix

* bug fixes and bump kfp version

* Update application.yaml

* fix objectstore name

* fix objectstore name
2019-09-09 03:59:18 -07:00
IronPan 3edaa38e51 fixes name inconsistency for marketplace manifest and bump kfp version (#2065)
* pass in secret

* fix

* use application name by default for database prefix

* bug fixes and bump kfp version

* Update application.yaml
2019-09-09 01:31:20 -07:00
IronPan be01314ac2 Add parameter for service account credential (#2039)
* pass in secret

* fix

* use application name by default for database prefix
2019-09-08 23:51:17 -07:00
Alexey Volkov 6c59d9d00f Release - Creating the release branch from the specified commit (#2062) 2019-09-07 19:03:18 -07:00
Riley Bauer 0c27a04e52 Add execution list and details pages (#2059)
* Adds execution list and details pages

* Simplifies envoy dockerfile

* Add routing

* Update tests
2019-09-06 22:31:18 -07:00
Alexey Volkov d83601d19a SDK - Compiler - Quoting the predicate operands (#2043)
Fixes https://github.com/kubeflow/pipelines/issues/1950
2019-09-06 17:05:21 -07:00
Ning 2a3dd327db move old gcp components to deprecated folder (#2031) 2019-09-06 16:29:20 -07:00
Alexey Volkov 979396702e SDK - Compiler - Failing when PipelineParam is unresolved (#2055)
Instead of silently producing a broken pipeline package, the compiler now raises error and instructs the user to submit a bug report.
2019-09-06 15:51:20 -07:00
Alexey Volkov 08104d6cf9 SDK - Containers - Build python container image based on current working directory (#1970)
* SDK - Containers - Build container image from current environment

* Removed the ability to capture the active python environment (as requested by @hongye-sun)

* Added the type hint and docstring to for the return type.

* Renamed `build_image_from_env` function to `build_image_from_working_dir`
as requested by @hongye-sun

* Explained the function behavior in the documentation.

* Removed extra empty line

* Improved caching by copying python files only after installing python packages

* Made test more portable

* Added support for specifying the base_image
`kfp.containers.default_base_image = ...`
The image can also be a callable returning the image name.

* Renamed `get_python_image` to `get_python_image_for_current_version`

* Switched the default base image to Google Deep Learning container image as requested by @hongye-sun
The size of this image is 4.35GB which really concerns me. The GPU image size is 6.45GB.

* Stopped importing kfp.containers.* into kfp.*

* Fixed test

* Fixed the regex string

* Fixed the type annotation style

* Addressed @hongye-sun feedback

* Removed the container image size warning

* Fixed import failure
2019-09-06 15:19:19 -07:00
Ning 60018e3149
update sample readme for the new structure (#2058)
* update sample readme for the new structure
* sidecar seems flaky, disable for now and will re-enable later
2019-09-06 14:24:45 -07:00
Jiaxiao Zheng bd9d6319c8
Refactor kfp.compiler for better modularity (#2052)
* init analyze

* Refactor

* Renaming
2019-09-06 13:52:23 -07:00
Riley Bauer 8d196d4dec Adds Metadata Artifacts to UI (#2057)
* Working, though the request seems malformed

* Working with grpc-web. trying to push to cluster

* WIP

* With great hax come great success

* Begin moving some metadata UI pages to KFP

* Artifact list and details pages work! A lot of clean up is needed. Look for console.log and TODO

* Clean up

* Fixes filtering of artifact list

* More cleanup

* Revert ui deployment

* Updates tests

* Update envoy deployment
2019-09-06 13:19:19 -07:00
Ning fe0bc678a8 add more core samples in the sample test (#2030)
* add more core samples in the sample test

* remove retry test for now

* update pipeline transformer sample

* add default value to volume_ops and fix error

* remove volume snapshot and resource op sample tests, which require platform support

* remove volume_ops since it is already included in the e2e

* add timeout
2019-09-06 11:46:15 -07:00
Alexey Volkov 6c15f27f7e SDK - Components - Hiding signature attribute from CloudPickle (#2045)
* SDK - Components - Hiding signature attribute from CloudPickle

Cloudpickle has some issues with pickling type annotations in python versions < 3.7, so they disabled it. https://github.com/cloudpipe/cloudpickle/issues/196
`create component_from_airflow_op` spoofs the function signature by setting the `func.__signature__` attribute. cloudpickle then tries to pickle that attribute which leads to failures during unpickling.
To prevent this we remove the `.__signature__` attribute before pickling.

* Added comments

        # Hack to prevent cloudpickle from trying to pickle generic types that might be present in the signature. See https://github.com/cloudpipe/cloudpickle/issues/196 
        # Currently the __signature__ is only set by Airflow components as a means to spoof/pass the function signature to _func_to_component_spec
2019-09-06 11:12:15 -07:00
Alexey Volkov 5360f3fcab SDK - Compiler - Stopped adding mlpipeline artifacts to every compiled template (#2046)
* Explicitly added mlpipeline outputs to the components that actually produce them

* Updated samples

* SDK - DSL - Stopped adding mlpipeline artifacts to every compiled template
Fixes https://github.com/kubeflow/pipelines/issues/1421
Fixes https://github.com/kubeflow/pipelines/issues/1422

* Updated the Lighweight sample

* Updated the compiler tests

* Fixed the lightweight sample

* Reverted the change to one contrib/samples/openvino
The sample will still work fine as it is now.
I'll add the change to that file as a separate PR.
2019-09-05 17:56:57 -07:00
Alexey Volkov f911742d1a SDK - Compiler - Fixed handling of PipelineParams in artifact arguments (#2042)
Previously only constant strings were supported and serialized PipelineParams were not resolved, producing incorrect workflows.
2019-09-05 15:16:58 -07:00
Kirin Patel aa8f0a2a6c Fix python syntax of TFMA visualization (#1972)
* Fix python syntax

* Update tfma.py
2019-09-05 14:44:57 -07:00
sina chavoshi e4556a0896 Removing the outdated resnet-CMLE sample (#2053) 2019-09-05 14:10:58 -07:00
Alexey Volkov 301186cc87 SDK - Refactoring - Reduced the usage of dsl.Pipeline context (#2034)
Also reduced the unnecessary explicit usage of PipelineParam bu the end users
2019-09-05 01:26:52 -07:00
Alexey Volkov 9104fd327f SDK - Testing - Make dsl and compiler tests discoverable by unittest (#2038)
This makes it possible to execute all test by running `python3 -m unittest discover --verbose -p *test*.py`
2019-09-04 12:38:22 -07:00
Ilias Katsakioris df4bc2365e SDK/DSL: Fix bug when using PipelineParam in `pvc` of PipelineVolume (#2018)
If no `name` is provided to PipelineVolume constructor, a custom name is
generated. It relies on `json.dumps()` of the struct after getting
converted to dict.
When `pvc` is provided and `name` is not, the following error is raised:
  TypeError: Object of type PipelineParam is not JSON serializable

This commit fixes it and extends tests to catch it.
2019-09-04 11:32:23 -07:00
Jiaxiao Zheng 60dde2b149 Apply gcp secret. (#2037) 2019-09-04 10:58:59 -07:00
Timur Solovev 8fce00642c SDK: fix setting pipeline-wide artifact_location for ResourceOp and VolumeOp classes and add description field for create_experiment() function (#2025)
* fix setting pipeline-wide artifact_location for ResourceOp and VolumeOp classes

* add description field for create_experiment() function
2019-09-03 21:54:59 -07:00
Ilias Katsakioris 0cc9f69b04 Extend E2E tests: Add VolumeOp test (#2019)
* Extend E2E tests: Add VolumeOp test

* Rename: `samples/core/volume_ops/volumeop.py` ->
          `samples/core/volume_ops/volume_ops.py`
  for uniformity regarding test launching
* Change VolumeOp modes from RWM to RWO

* Add volume_ops.config.yaml
2019-09-03 21:24:58 -07:00
Yuan (Bob) Gong 3d2b0ae417 Print cloud build logs when the task fails (#1989)
* Print cloud build logs when the task fails

* Add comment about why cloud build is made async
2019-09-03 18:12:58 -07:00
Alexey Volkov cf681cb0f1 SDK - Switching python container components to Lightweight components code generator (#1889)
* SDK - Switching python container components to Lightweight components code generator

* Fixed the tests

Had to remove the python2 test since python2 code generation is going away (python2 is near its End of Life and Kubeflow Pipelines only support python 3.5+).

* Added description for the internal add_files parameter

* Fixed typo

* Removed the `test_func_to_entrypoint` test
This was proposed by @gaoning777: `_func_to_entrypoint` is now just a reference to `_func_to_component_spec` which is extensively covered by other tests.
2019-09-03 17:10:58 -07:00
dushyanthsc 1b4919f3fb
manifest/metadata: Switching to use metadata grpc server (#1973)
This change switches pipeline deployments to use metadata-grpc server
instead of kf-mlmd server.
2019-09-03 16:15:02 -07:00
Ning c65111c497 remove the bigquery components to favor the new gcp components (#2006) 2019-09-03 15:20:59 -07:00
Jiaxiao Zheng 5c059b93f4 Add guideline for including a sample in sample test (#2026)
* Init guideline

* Draft for sample test guideline.

* Fix

* Fix

* Resolve comments.

* Add section link

* Fix link, use relative path.
2019-09-03 14:42:59 -07:00