* Fix the broken sample path in API
Related change b476a848d9
/hold
Need investigate why test doesn't catch it.
/assign @numerology @hongye-sun
* Update sample_config.json
* avoid istio injector in the container builder
* find the correct namespace
* configure default ns to kubeflow if out of cluster; fix unit tests
* container build default gcs bucket
* resolve comments
* code refactor; add create_bucket_if_not_exist in containerbuilder
* support load kube config and output error, good for ai platform notebooks/local notebooks
* remove create_bucket_if_not_exist param
* SDK - Containers - Returning image name with digest
Image building functions now return image name with digest: image_repo@sha256:digest
Fixes https://github.com/kubeflow/pipelines/issues/1715
* Added comments
* Update docker images and minor refactoring
* Update image tag, bug fixes, remove unneeded imports
* Revert to using image version, use origin batch transform output method
* Forgot to save 2 changes
* Remove redundant import.
* Simplify sample_test.yaml by using withItem syntax.
* Simplify sample_test.yaml by using withItem syntax.
* Change dict to str in withItems.
* remove redundant sed options.
* Fix format/style issues
* [WIP] Refactor repeated logic into two utility functions.
* [WIP] Add a utility function to validate the test results from a notebook test.
* [WIP] Refactor test cases (except for notebook sample tests) into adopting utility functions.
TODO: Need to move the functions of run_*_test.py into a unified run_sample_test.py.
* [WIP] Fix a typo in test name and incorporate tfx-cab-classification, kubeflow-training-classification, xgboost-training-cm and basic ones into one run_sample_test.py
* Fix/add some comments.
* Refactor notebook tests into using utility functions
* lint
* Unify naming in sample_test.yaml
* Remove old *_test.py files
* Fix tests by fixing test names.
* Fix string formatting, per Ark-kun's comment.
* Fix names of papermill-generated python notebook.
* Fix tests
* Fix test by fixing experiment names, and test names in yaml.
* Fix test by fixing experiment names.
* Fix dsl type checking test that does not require experiment set-up.
* Remove redundant commands and usage of ipython
* Revert "Remove redundant commands and usage of ipython"
This reverts commit 23a0e014
* Remove redundant string subs and edit an AI.
* Move image name injection to a utility function to improve readability.
* Revert lint changes of check_notebook_results.py
* Unify test case naming convention to underscore.
* Fix .py name
* Fix README.md
* Fix test
* Add TODO items.
* Add a utility function to inject kubeflow_training_classification python sample file.
* Fix redundant cd command.
* Fix indentation.
* Fix test names in component_test.yaml
* Remove redundant clean_cmle_models.py
* Fix nit problem.
* Fix comment.
* Remove redundant import.
* Simplify sample_test.yaml by using withItem syntax.
* Simplify sample_test.yaml by using withItem syntax.
* Change dict to str in withItems.
* Add image pull secret sample.
* Move imagepullsecret sample from test dir to sample dir. Waiting on corresponding unit test infra refactoring.
* Update the location of imagepullsecrets so that it can serve as an example.
* Add minimal comments documenting usage.
Problem: Docker implicitly prepends "sh -c " to the RUN commands (no "-e"). Without "-e", the exit code of the shell script is the exit code of the last executed command. So the csample compilation script will only fail if the last sample failed the compilation.
Fix: Explicitly adding "set -e" to the command fixes the issue.
Fixes https://github.com/kubeflow/pipelines/issues/1735
* Remove redundant import.
* Simplify sample_test.yaml by using withItem syntax.
* Simplify sample_test.yaml by using withItem syntax.
* Change dict to str in withItems.
* Add preemptible gpu tpu sample and unittest
* Update a test utility function.
* Seperate the location of sample and gold .yaml for testing purpose.
* adding a basic sample for component build
* adding a basic command line based sample for component build
* remvoing use of global
* Update samples/core/component_build/component_build.py
Co-Authored-By: Jiaxiao Zheng <jxzheng@google.com>
* Switching to Notebook based sample
* Added Pip install KFP SDK
* Fixes cloning of recurring runs
Simplifies NewRun a little
Creates NewRunParameters component
* Fixes all NewRun tests
* All tests pass
* Adds tests for NewRunParameters
* Adds clone test to RecurringRunDetails
* Clean up
* Add components for workteam and Ground Truth, minor update for HPO and train, add sample pipeline demo for workteam and GT, update images
* Minor style fixes
* Address PR comments
* Refactor for new folder structure
* InputPath -> Source
* Changed name of data path/pattern variable from InputPath to Source to improve consistency with current visualization method
* Updated unit tests to reflect name change
* Regenerated swagger definitions to reflect name change
* Readded test that was removed with previous commit
It was deleted by mistake
* Add env var for single part support.
AddFile will have the option to send single part. for backend which doesn't support multipart.
in order to use it change ObjectStoreConfig.Disable.Multipart value to true
* few changes
* remove redundent import
* remove newlines
* Add a sample for mounting and using secrets
* Fixed formatting issue and updated comments
* Corrected formatting issue.
* Added API call to sample, moved to contrib
* Backend - Starting the container build from scratch
This reduces the image size, reduces the attack surface and avoids security vulnerabilities.
Fixes https://github.com/kubeflow/pipelines/issues/1545
* Starting building other controller images from scratch
* Added support for mulitple outputs
* Added test for multiple output
* Adding sample for multiple outputs
* func_signature now shorter form
* Added parameters tag
* Fixed func_signature mistake
* Setup initial server with roc_curve visualization
* Created Dockerfile.visualization
* Fixed import issue
* Changed implementation of generate_html_from_notebook to allow template type to be specified
* Added tfdv.py
* Added unit tests for exporter.py
* Deleted __init__.py
* visualizations/ -> visualization/
* Added requirements.txt and updated Dockerfile.visualization to use it
* Updated .travis.yml to run python visualization unit tests
* Fixed travis file path issue
* Continued testing to fix travis test issues
* Removed jupyter from pip3 install
Previously included to ensure python3 kernel was accessible to jupyter_client.
* Updated requirements.txt to included ipykernel
* Removed maxDiff limit for all python tests
* Sorted keys within args dictionary to ensure tests do not fail due to dictionary order
* Created requirements-test.txt
* Added input_path argument support for python service
Also adds check for missing input_path argument and returns 400 error if argument is missing.
* Updated Copyright in Dockerfile.visualization
* Updated snapshot to include all tests
* Added types, additional comments, and TemplateType enum
Also made additional style changes
* Formatted template files
* Addressed most feedback made by @kevinbache
* Revert "Formatted template files"
This reverts commit a7afd7b8af. This was done due to issues faced by the templating engine.
* Fixed comment placement and switched os -> Path
* Changed way exporter is implemented to use importlib
* Reverted to str.format due to python comparability issue
Python 3.6 introduced support for f-stringsl, this results in the tests failing when run in a python 3.5 environment
* Added unit tests for tornado web server
* Added license script for open source compliance
* Added line between file comment and license to match exporter.py
* Updated server structure
* Created Exporter class
* Introduced ability to specify visualization timeout (default is 100 seconds)
* Added more comments
* Broke up post function in VisualizationHandler to call multiple function rather than handling all logic within post function
* Updated imports
* Updated tests
* Addressed additional feedback from @kevinbache
* Fixed snapshot for test_exporter
* Comments -> Docstring Comments and other small fixes
* Fixed missing and incorrect typings
* shutdown_kernel is now private method of Exporter class
* Added missing and updated docstring comments in server.py
* Resolved latency issue with visualization server
Issue stemmed from a recreation of an exporter object per request, this was resolved by creating a global exporter.
hongye-sun
IronPan
Ning
Alexey Volkov
carolynwang
Jiaxiao Zheng
Yasser Elsayed
Kirin Patel
sina chavoshi
Tommy Li
Riley Bauer
nirsagi
Zane Durante
Ilias Katsakioris