kubeflow
/
spark-operator
mirror of https://github.com/kubeflow/spark-operator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make image optional (#2439) 

* Make app.Spec.Driver.Image and app.Spec.Image optional
Signed-off-by: jbhalodia-slack <jbhalodia@salesforce.com>

* Make app.Spec.Executor.Image optional
Signed-off-by: jbhalodia-slack <jbhalodia@salesforce.com>
This commit is contained in:
jbhalodia-slack 2025-02-19 23:03:42 -05:00 committed by GitHub
parent bd197c6f8c
commit d10b8f5f3a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/controller/sparkapplication/submission.go
View File

@ -320,8 +320,6 @@ func driverConfOption(app *v1beta2.SparkApplication) ([]string, error) {
} else if app.Spec.Image != nil && *app.Spec.Image != "" {
args = append(args, "--conf",
fmt.Sprintf("%s=%s", common.SparkKubernetesDriverContainerImage, *app.Spec.Image))
} else {
return nil, fmt.Errorf("driver container image is not specified")
}
if app.Spec.Driver.Cores != nil {
@ -676,8 +674,6 @@ func executorConfOption(app *v1beta2.SparkApplication) ([]string, error) {
} else if app.Spec.Image != nil && *app.Spec.Image != "" {
args = append(args, "--conf",
fmt.Sprintf("%s=%s", common.SparkKubernetesExecutorContainerImage, *app.Spec.Image))
} else {
return nil, fmt.Errorf("executor container image is not specified")
}
if app.Spec.Executor.Cores != nil {