From 01307e4b8d7677846b0b6e0c3952f4307afa853e Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Mon, 3 Mar 2025 10:45:39 +0800 Subject: [PATCH 1/3] remove feature gate RemainingItemCount that was GAed in v1.29 Kubernetes-commit: bb79c29dd51f46003e0d35cd3d3683a2338448b1 --- pkg/features/kube_features.go | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index 8e4153d10..4b731f1d2 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -142,13 +142,6 @@ const ( // in the spec returned from kube-apiserver. OpenAPIEnums featuregate.Feature = "OpenAPIEnums" - // owner: @caesarxuchao - // stable: 1.29 - // - // Allow apiservers to show a count of remaining items in the response - // to a chunking list request. - RemainingItemCount featuregate.Feature = "RemainingItemCount" - // owner: @stlaz // // Enable kube-apiserver to accept UIDs via request header authentication. @@ -357,12 +350,6 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate {Version: version.MustParse("1.24"), Default: true, PreRelease: featuregate.Beta}, }, - RemainingItemCount: { - {Version: version.MustParse("1.15"), Default: false, PreRelease: featuregate.Alpha}, - {Version: version.MustParse("1.16"), Default: true, PreRelease: featuregate.Beta}, - {Version: version.MustParse("1.29"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, - }, - RemoteRequestHeaderUID: { {Version: version.MustParse("1.32"), Default: false, PreRelease: featuregate.Alpha}, }, From bd0e77441603221b7fa4000ae1fa550e33309a90 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Mon, 3 Mar 2025 11:01:02 +0800 Subject: [PATCH 2/3] remove AggregatedDiscoveryEndpoint that was GAed in v1.30 Kubernetes-commit: 8195f82fe82e7bcf36ba50ddc8b78c00fa8df2bc --- pkg/endpoints/discovery/aggregated/wrapper.go | 14 ++---- .../discovery/aggregated/wrapper_test.go | 5 -- pkg/features/kube_features.go | 13 ----- pkg/server/config.go | 20 +++----- pkg/server/genericapiserver.go | 50 ++++++++----------- 5 files changed, 34 insertions(+), 68 deletions(-) diff --git a/pkg/endpoints/discovery/aggregated/wrapper.go b/pkg/endpoints/discovery/aggregated/wrapper.go index 25fe90fa4..c9f0907e7 100644 --- a/pkg/endpoints/discovery/aggregated/wrapper.go +++ b/pkg/endpoints/discovery/aggregated/wrapper.go @@ -28,8 +28,6 @@ import ( "k8s.io/apimachinery/pkg/runtime" "k8s.io/apiserver/pkg/endpoints/handlers/negotiation" - genericfeatures "k8s.io/apiserver/pkg/features" - utilfeature "k8s.io/apiserver/pkg/util/feature" ) type WrappedHandler struct { @@ -39,13 +37,11 @@ type WrappedHandler struct { } func (wrapped *WrappedHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) { - if utilfeature.DefaultFeatureGate.Enabled(genericfeatures.AggregatedDiscoveryEndpoint) { - mediaType, _ := negotiation.NegotiateMediaTypeOptions(req.Header.Get("Accept"), wrapped.s.SupportedMediaTypes(), DiscoveryEndpointRestrictions) - // mediaType.Convert looks at the request accept headers and is used to control whether the discovery document will be aggregated. - if IsAggregatedDiscoveryGVK(mediaType.Convert) { - wrapped.aggHandler.ServeHTTP(resp, req) - return - } + mediaType, _ := negotiation.NegotiateMediaTypeOptions(req.Header.Get("Accept"), wrapped.s.SupportedMediaTypes(), DiscoveryEndpointRestrictions) + // mediaType.Convert looks at the request accept headers and is used to control whether the discovery document will be aggregated. + if IsAggregatedDiscoveryGVK(mediaType.Convert) { + wrapped.aggHandler.ServeHTTP(resp, req) + return } wrapped.handler.ServeHTTP(resp, req) } diff --git a/pkg/endpoints/discovery/aggregated/wrapper_test.go b/pkg/endpoints/discovery/aggregated/wrapper_test.go index 3db842afb..91071b647 100644 --- a/pkg/endpoints/discovery/aggregated/wrapper_test.go +++ b/pkg/endpoints/discovery/aggregated/wrapper_test.go @@ -24,9 +24,6 @@ import ( "testing" "github.com/stretchr/testify/assert" - genericfeatures "k8s.io/apiserver/pkg/features" - utilfeature "k8s.io/apiserver/pkg/util/feature" - featuregatetesting "k8s.io/component-base/featuregate/testing" ) const discoveryPath = "/apis" @@ -60,8 +57,6 @@ func (f fakeHTTPHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) } func TestAggregationEnabled(t *testing.T) { - featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, genericfeatures.AggregatedDiscoveryEndpoint, true) - unaggregated := fakeHTTPHandler{data: "unaggregated"} aggregated := fakeHTTPHandler{data: "aggregated"} wrapped := WrapAggregatedDiscoveryToHandler(unaggregated, aggregated) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index 4b731f1d2..fce298188 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -41,13 +41,6 @@ const ( // Enables usage of MatchConditions fields to use CEL expressions for matching on admission webhooks AdmissionWebhookMatchConditions featuregate.Feature = "AdmissionWebhookMatchConditions" - // owner: @jefftree @alexzielenski - // stable: v1.30 - // - // Enables an single HTTP endpoint /discovery/ which supports native HTTP - // caching with ETags containing all APIResources known to the apiserver. - AggregatedDiscoveryEndpoint featuregate.Feature = "AggregatedDiscoveryEndpoint" - // owner: @modulitos // // Allow user.DefaultInfo.UID to be set from x509 cert during cert auth. @@ -266,12 +259,6 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate {Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, }, - AggregatedDiscoveryEndpoint: { - {Version: version.MustParse("1.26"), Default: false, PreRelease: featuregate.Alpha}, - {Version: version.MustParse("1.27"), Default: true, PreRelease: featuregate.Beta}, - {Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, - }, - AllowParsingUserUIDFromCertAuth: { {Version: version.MustParse("1.33"), Default: true, PreRelease: featuregate.Beta}, }, diff --git a/pkg/server/config.go b/pkg/server/config.go index 9e9bf4e3d..c2f885948 100644 --- a/pkg/server/config.go +++ b/pkg/server/config.go @@ -845,14 +845,12 @@ func (c completedConfig) New(name string, delegationTarget DelegationTarget) (*G muxAndDiscoveryCompleteSignals: map[string]<-chan struct{}{}, } - if c.FeatureGate.Enabled(genericfeatures.AggregatedDiscoveryEndpoint) { - manager := c.AggregatedDiscoveryGroupManager - if manager == nil { - manager = discoveryendpoint.NewResourceManager("apis") - } - s.AggregatedDiscoveryGroupManager = manager - s.AggregatedLegacyDiscoveryGroupManager = discoveryendpoint.NewResourceManager("api") + manager := c.AggregatedDiscoveryGroupManager + if manager == nil { + manager = discoveryendpoint.NewResourceManager("apis") } + s.AggregatedDiscoveryGroupManager = manager + s.AggregatedLegacyDiscoveryGroupManager = discoveryendpoint.NewResourceManager("api") for { if c.JSONPatchMaxCopyBytes <= 0 { break @@ -1111,12 +1109,8 @@ func installAPI(name string, s *GenericAPIServer, c *Config) { routes.Version{Version: c.EffectiveVersion.BinaryVersion().Info()}.Install(s.Handler.GoRestfulContainer) if c.EnableDiscovery { - if c.FeatureGate.Enabled(genericfeatures.AggregatedDiscoveryEndpoint) { - wrapped := discoveryendpoint.WrapAggregatedDiscoveryToHandler(s.DiscoveryGroupManager, s.AggregatedDiscoveryGroupManager) - s.Handler.GoRestfulContainer.Add(wrapped.GenerateWebService("/apis", metav1.APIGroupList{})) - } else { - s.Handler.GoRestfulContainer.Add(s.DiscoveryGroupManager.WebService()) - } + wrapped := discoveryendpoint.WrapAggregatedDiscoveryToHandler(s.DiscoveryGroupManager, s.AggregatedDiscoveryGroupManager) + s.Handler.GoRestfulContainer.Add(wrapped.GenerateWebService("/apis", metav1.APIGroupList{})) } if c.FlowControl != nil { c.FlowControl.Install(s.Handler.NonGoRestfulMux) diff --git a/pkg/server/genericapiserver.go b/pkg/server/genericapiserver.go index 82b9df944..c2d9f5c5b 100644 --- a/pkg/server/genericapiserver.go +++ b/pkg/server/genericapiserver.go @@ -785,28 +785,26 @@ func (s *GenericAPIServer) installAPIResources(apiPrefix string, apiGroupInfo *A } resourceInfos = append(resourceInfos, r...) - if s.FeatureGate.Enabled(features.AggregatedDiscoveryEndpoint) { - // Aggregated discovery only aggregates resources under /apis - if apiPrefix == APIGroupPrefix { - s.AggregatedDiscoveryGroupManager.AddGroupVersion( - groupVersion.Group, - apidiscoveryv2.APIVersionDiscovery{ - Freshness: apidiscoveryv2.DiscoveryFreshnessCurrent, - Version: groupVersion.Version, - Resources: discoveryAPIResources, - }, - ) - } else { - // There is only one group version for legacy resources, priority can be defaulted to 0. - s.AggregatedLegacyDiscoveryGroupManager.AddGroupVersion( - groupVersion.Group, - apidiscoveryv2.APIVersionDiscovery{ - Freshness: apidiscoveryv2.DiscoveryFreshnessCurrent, - Version: groupVersion.Version, - Resources: discoveryAPIResources, - }, - ) - } + // Aggregated discovery only aggregates resources under /apis + if apiPrefix == APIGroupPrefix { + s.AggregatedDiscoveryGroupManager.AddGroupVersion( + groupVersion.Group, + apidiscoveryv2.APIVersionDiscovery{ + Freshness: apidiscoveryv2.DiscoveryFreshnessCurrent, + Version: groupVersion.Version, + Resources: discoveryAPIResources, + }, + ) + } else { + // There is only one group version for legacy resources, priority can be defaulted to 0. + s.AggregatedLegacyDiscoveryGroupManager.AddGroupVersion( + groupVersion.Group, + apidiscoveryv2.APIVersionDiscovery{ + Freshness: apidiscoveryv2.DiscoveryFreshnessCurrent, + Version: groupVersion.Version, + Resources: discoveryAPIResources, + }, + ) } } @@ -844,12 +842,8 @@ func (s *GenericAPIServer) InstallLegacyAPIGroup(apiPrefix string, apiGroupInfo // Install the version handler. // Add a handler at / to enumerate the supported api versions. legacyRootAPIHandler := discovery.NewLegacyRootAPIHandler(s.discoveryAddresses, s.Serializer, apiPrefix) - if s.FeatureGate.Enabled(features.AggregatedDiscoveryEndpoint) { - wrapped := discoveryendpoint.WrapAggregatedDiscoveryToHandler(legacyRootAPIHandler, s.AggregatedLegacyDiscoveryGroupManager) - s.Handler.GoRestfulContainer.Add(wrapped.GenerateWebService("/api", metav1.APIVersions{})) - } else { - s.Handler.GoRestfulContainer.Add(legacyRootAPIHandler.WebService()) - } + wrapped := discoveryendpoint.WrapAggregatedDiscoveryToHandler(legacyRootAPIHandler, s.AggregatedLegacyDiscoveryGroupManager) + s.Handler.GoRestfulContainer.Add(wrapped.GenerateWebService("/api", metav1.APIVersions{})) s.registerStorageReadinessCheck("", apiGroupInfo) return nil From d44a862c5122e03bfa5dd8e6fa968ee4978a8411 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Mon, 3 Mar 2025 10:54:46 +0800 Subject: [PATCH 3/3] remove feature gate AdmissionWebhookMatchConditions that was GAed in v1.30 Kubernetes-commit: f16745437182ec50f51253cef39cd5c89041ee95 --- pkg/features/kube_features.go | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index fce298188..5da529e1e 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -34,13 +34,6 @@ const ( // of code conflicts because changes are more likely to be scattered // across the file. - // owner: @ivelichkovich, @tallclair - // stable: v1.30 - // kep: https://kep.k8s.io/3716 - // - // Enables usage of MatchConditions fields to use CEL expressions for matching on admission webhooks - AdmissionWebhookMatchConditions featuregate.Feature = "AdmissionWebhookMatchConditions" - // owner: @modulitos // // Allow user.DefaultInfo.UID to be set from x509 cert during cert auth. @@ -253,12 +246,6 @@ func init() { // Entries are alphabetized and separated from each other with blank lines to avoid sweeping gofmt changes // when adding or removing one entry. var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{ - AdmissionWebhookMatchConditions: { - {Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha}, - {Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta}, - {Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, - }, - AllowParsingUserUIDFromCertAuth: { {Version: version.MustParse("1.33"), Default: true, PreRelease: featuregate.Beta}, },