From 6aae451ac12ac2ef57e239ef1bb1e844cbcdbb5c Mon Sep 17 00:00:00 2001 From: David Eads Date: Thu, 17 Apr 2025 16:34:46 -0400 Subject: [PATCH] Stop exposing list-via-watch from the server With StreamingCollectionEncodingToJSON and StreamingCollectionEncodingToProtobuf, the WatchList must re-justify its necessity. To prevent an ecosystem from building around a feature that may not be promoted, we will stop serving list-via-watch until performance numbers can justify its inclusion. This also stops the kube-controller-manager from using the list-via-watch by default. The fallback is a regular list, so during the skew during an upgrade the "right" thing will happen and the new StreamingCollectionEncoding will be used. Kubernetes-commit: 660df229bf3929741cf31659187060d0c651dcf9 --- pkg/features/kube_features.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index ec5df4379..0ede8f9cb 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -415,5 +415,7 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate WatchList: { {Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha}, {Version: version.MustParse("1.32"), Default: true, PreRelease: featuregate.Beta}, + // switch this back to false because the json and proto streaming encoders appear to work better. + {Version: version.MustParse("1.33"), Default: false, PreRelease: featuregate.Beta}, }, }