kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Explicitly handle returned error values in admission metrics_test 

Kubernetes-commit: 774641ebdbdc7fe89380e7e1e77f5ebbe843ecec
This commit is contained in:
Han Kang 2019-08-21 12:13:33 -07:00 committed by Kubernetes Publisher
parent 99a0cf54d3
commit 7400a466d2
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/admission/metrics/metrics_test.go
View File

@ -37,8 +37,12 @@ var (
func TestObserveAdmissionStep(t *testing.T) {
Metrics.reset()
handler := WithStepMetrics(&mutatingAndValidatingFakeHandler{admission.NewHandler(admission.Create), true, true})
handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil)
handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil)
if err := handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil); err != nil {
t.Errorf("Unexpected error in admit: %v", err)
}
if err := handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil); err != nil {
t.Errorf("Unexpected error in validate: %v", err)
}
wantLabels := map[string]string{
"operation": string(admission.Create),
"type": "admit",
@ -55,8 +59,12 @@ func TestObserveAdmissionStep(t *testing.T) {
func TestObserveAdmissionController(t *testing.T) {
Metrics.reset()
handler := WithControllerMetrics(&mutatingAndValidatingFakeHandler{admission.NewHandler(admission.Create), true, true}, "a")
handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil)
handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil)
if err := handler.(admission.MutationInterface).Admit(context.TODO(), attr, nil); err != nil {
t.Errorf("Unexpected error in admit: %v", err)
}
if err := handler.(admission.ValidationInterface).Validate(context.TODO(), attr, nil); err != nil {
t.Errorf("Unexpected error in validate: %v", err)
}
wantLabels := map[string]string{
"name": "a",
"operation": string(admission.Create),