Change precedence order for continue and legacy exact match
This doesn't matter for shouldDelegateList, but matters when picking source of RV. RV from continue takes precedence. Kubernetes-commit: 7da942ca7486310893d4f11f3af062957f953555
This commit is contained in:
parent
dfc7cb5fe1
commit
91724cfd41
|
@ -257,14 +257,14 @@ func shouldDelegateList(opts storage.ListOptions, cache delegator.Helper) (deleg
|
||||||
case metav1.ResourceVersionMatchNotOlderThan:
|
case metav1.ResourceVersionMatchNotOlderThan:
|
||||||
return delegator.Result{ShouldDelegate: false}, nil
|
return delegator.Result{ShouldDelegate: false}, nil
|
||||||
case "":
|
case "":
|
||||||
// Legacy exact match
|
|
||||||
if opts.Predicate.Limit > 0 && len(opts.ResourceVersion) > 0 && opts.ResourceVersion != "0" {
|
|
||||||
return cache.ShouldDelegateExactRV(opts.ResourceVersion, opts.Recursive)
|
|
||||||
}
|
|
||||||
// Continue
|
// Continue
|
||||||
if len(opts.Predicate.Continue) > 0 {
|
if len(opts.Predicate.Continue) > 0 {
|
||||||
return cache.ShouldDelegateContinue(opts.Predicate.Continue, opts.Recursive)
|
return cache.ShouldDelegateContinue(opts.Predicate.Continue, opts.Recursive)
|
||||||
}
|
}
|
||||||
|
// Legacy exact match
|
||||||
|
if opts.Predicate.Limit > 0 && len(opts.ResourceVersion) > 0 && opts.ResourceVersion != "0" {
|
||||||
|
return cache.ShouldDelegateExactRV(opts.ResourceVersion, opts.Recursive)
|
||||||
|
}
|
||||||
// Consistent Read
|
// Consistent Read
|
||||||
if opts.ResourceVersion == "" {
|
if opts.ResourceVersion == "" {
|
||||||
return cache.ShouldDelegateConsistentRead()
|
return cache.ShouldDelegateConsistentRead()
|
||||||
|
|
|
@ -172,14 +172,14 @@ func shouldDelegateList(opts *metav1.ListOptions, cache delegator.Helper) (deleg
|
||||||
case metav1.ResourceVersionMatchNotOlderThan:
|
case metav1.ResourceVersionMatchNotOlderThan:
|
||||||
return delegator.Result{ShouldDelegate: false}, nil
|
return delegator.Result{ShouldDelegate: false}, nil
|
||||||
case "":
|
case "":
|
||||||
// Legacy exact match
|
|
||||||
if opts.Limit > 0 && len(opts.ResourceVersion) > 0 && opts.ResourceVersion != "0" {
|
|
||||||
return cache.ShouldDelegateExactRV(opts.ResourceVersion, defaultRecursive)
|
|
||||||
}
|
|
||||||
// Continue
|
// Continue
|
||||||
if len(opts.Continue) > 0 {
|
if len(opts.Continue) > 0 {
|
||||||
return cache.ShouldDelegateContinue(opts.Continue, defaultRecursive)
|
return cache.ShouldDelegateContinue(opts.Continue, defaultRecursive)
|
||||||
}
|
}
|
||||||
|
// Legacy exact match
|
||||||
|
if opts.Limit > 0 && len(opts.ResourceVersion) > 0 && opts.ResourceVersion != "0" {
|
||||||
|
return cache.ShouldDelegateExactRV(opts.ResourceVersion, defaultRecursive)
|
||||||
|
}
|
||||||
// Consistent Read
|
// Consistent Read
|
||||||
if opts.ResourceVersion == "" {
|
if opts.ResourceVersion == "" {
|
||||||
return cache.ShouldDelegateConsistentRead()
|
return cache.ShouldDelegateConsistentRead()
|
||||||
|
|
Loading…
Reference in New Issue