From a8cd668cfc5fa5d5467a06cde8a65f2c0a49da52 Mon Sep 17 00:00:00 2001 From: David Eads Date: Fri, 22 Jun 2018 08:58:32 -0400 Subject: [PATCH] legacy api endpoints only support v1 ever Kubernetes-commit: b063e9f85ee28233241ae4f9071a62ac6c9b499c --- pkg/endpoints/discovery/legacy.go | 18 ++++++++---------- pkg/server/genericapiserver.go | 7 +------ 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/pkg/endpoints/discovery/legacy.go b/pkg/endpoints/discovery/legacy.go index fb648e528..837cd0130 100644 --- a/pkg/endpoints/discovery/legacy.go +++ b/pkg/endpoints/discovery/legacy.go @@ -32,23 +32,21 @@ import ( // legacyRootAPIHandler creates a webservice serving api group discovery. type legacyRootAPIHandler struct { // addresses is used to build cluster IPs for discovery. - addresses Addresses - apiPrefix string - serializer runtime.NegotiatedSerializer - apiVersions []string + addresses Addresses + apiPrefix string + serializer runtime.NegotiatedSerializer } -func NewLegacyRootAPIHandler(addresses Addresses, serializer runtime.NegotiatedSerializer, apiPrefix string, apiVersions []string) *legacyRootAPIHandler { +func NewLegacyRootAPIHandler(addresses Addresses, serializer runtime.NegotiatedSerializer, apiPrefix string) *legacyRootAPIHandler { // Because in release 1.1, /apis returns response with empty APIVersion, we // use stripVersionNegotiatedSerializer to keep the response backwards // compatible. serializer = stripVersionNegotiatedSerializer{serializer} return &legacyRootAPIHandler{ - addresses: addresses, - apiPrefix: apiPrefix, - serializer: serializer, - apiVersions: apiVersions, + addresses: addresses, + apiPrefix: apiPrefix, + serializer: serializer, } } @@ -71,7 +69,7 @@ func (s *legacyRootAPIHandler) handle(req *restful.Request, resp *restful.Respon clientIP := utilnet.GetClientIP(req.Request) apiVersions := &metav1.APIVersions{ ServerAddressByClientCIDRs: s.addresses.ServerAddressByClientCIDRs(clientIP), - Versions: s.apiVersions, + Versions: []string{"v1"}, } responsewriters.WriteObjectNegotiated(s.serializer, schema.GroupVersion{}, resp.ResponseWriter, req.Request, http.StatusOK, apiVersions) diff --git a/pkg/server/genericapiserver.go b/pkg/server/genericapiserver.go index 9beba735d..8c6949134 100644 --- a/pkg/server/genericapiserver.go +++ b/pkg/server/genericapiserver.go @@ -341,14 +341,9 @@ func (s *GenericAPIServer) InstallLegacyAPIGroup(apiPrefix string, apiGroupInfo return err } - // setup discovery - apiVersions := []string{} - for _, groupVersion := range apiGroupInfo.PrioritizedVersions { - apiVersions = append(apiVersions, groupVersion.Version) - } // Install the version handler. // Add a handler at / to enumerate the supported api versions. - s.Handler.GoRestfulContainer.Add(discovery.NewLegacyRootAPIHandler(s.discoveryAddresses, s.Serializer, apiPrefix, apiVersions).WebService()) + s.Handler.GoRestfulContainer.Add(discovery.NewLegacyRootAPIHandler(s.discoveryAddresses, s.Serializer, apiPrefix).WebService()) return nil }