kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56308 from yuexiao-wang/apiserver-vet 

Automatic merge from submit-queue (batch tested with PRs 56308, 54304, 56364, 56388, 55853). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix wrong number of args in apiserver/pkg

Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>

**What this PR does / why we need it**:
fix wrong number of args in apiserver/pkg

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 1a455f6f2da6237dc025557763b2287271735447
This commit is contained in:
Kubernetes Publisher 2017-12-15 02:04:34 -08:00
parent f274fcca88 46f7a60026
commit b77e344208
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/registry/rest/resttest/resttest.go
View File

@ -1330,7 +1330,7 @@ func (t *Tester) testListTableConversion(obj runtime.Object, assignFn AssignFunc
t.Errorf("column %d has unexpected format: %q with type %q", j, column.Format, column.Type) t.Errorf("column %d has unexpected format: %q with type %q", j, column.Format, column.Type)
} }
if column.Priority < 0 || column.Priority > 2 { if column.Priority < 0 || column.Priority > 2 {
t.Errorf("column %d has unexpected priority", j, column.Priority) t.Errorf("column %d has unexpected priority: %q", j, column.Priority)
} }
if len(column.Description) == 0 { if len(column.Description) == 0 {
t.Errorf("column %d has no description", j) t.Errorf("column %d has no description", j)
@ -1341,7 +1341,7 @@ func (t *Tester) testListTableConversion(obj runtime.Object, assignFn AssignFunc
} }
for i, row := range table.Rows { for i, row := range table.Rows {
if len(row.Cells) != len(table.ColumnDefinitions) { if len(row.Cells) != len(table.ColumnDefinitions) {
t.Errorf("row %d did not have the correct number of cells: %d in %v", len(table.ColumnDefinitions), row.Cells) t.Errorf("row %d did not have the correct number of cells: %d in %v", i, len(table.ColumnDefinitions), row.Cells)
} }
for j, cell := range row.Cells { for j, cell := range row.Cells {
// do not add to this test without discussion - may break clients // do not add to this test without discussion - may break clients

2
pkg/server/filters/compression_test.go
View File

@ -94,7 +94,7 @@ func TestCompression(t *testing.T) {
} }
body, err := ioutil.ReadAll(reader) body, err := ioutil.ReadAll(reader)
if err != nil { if err != nil {
t.Fatal("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)
} }
if !bytes.Equal(body, responseData) { if !bytes.Equal(body, responseData) {
t.Fatalf("Expected response body %s to equal %s", body, responseData) t.Fatalf("Expected response body %s to equal %s", body, responseData)