kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update staging/src/k8s.io/apiserver/pkg/audit/request_log_test.go 

Co-authored-by: Tim Allclair <timallclair@gmail.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Kubernetes-commit: 721947a5703f2ffaafdc9bef983a6b60c6253ca8
This commit is contained in:
Davanum Srinivas 2025-05-12 13:29:57 -04:00 committed by Kubernetes Publisher
parent b45c4547ed
commit bc489d7b1b
1 changed files with 85 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

135
pkg/audit/request_log_test.go
View File

@ -97,60 +97,85 @@ func TestLogResponseObjectWithPod(t *testing.T) {
} }
func TestLogResponseObjectWithStatus(t *testing.T) { func TestLogResponseObjectWithStatus(t *testing.T) {
// Create a status object to test ResponseStatus handling testCases := []struct {
testStatus := &metav1.Status{ name string
TypeMeta: metav1.TypeMeta{ level auditinternal.Level
APIVersion: "v1", status *metav1.Status
Kind: "Status", shouldEncode bool
expectResponseObj bool
expectStatusFields bool
}{
{
name: "RequestResponse level should encode and log status fields",
level: auditinternal.LevelRequestResponse,
status: &metav1.Status{Status: "Success", Message: "Test message", Code: 200},
shouldEncode: true,
expectResponseObj: true,
expectStatusFields: true,
},
{
name: "Metadata level should log status fields without encoding",
level: auditinternal.LevelMetadata,
status: &metav1.Status{Status: "Success", Message: "Test message", Code: 200},
shouldEncode: false,
expectResponseObj: false,
expectStatusFields: true,
}, },
Status: "Success",
Message: "Test status message",
Reason: "TestReason",
Code: 200,
} }
scheme := runtime.NewScheme() for _, tc := range testCases {
err := metav1.AddMetaToScheme(scheme) t.Run(tc.name, func(t *testing.T) {
if err != nil { scheme := runtime.NewScheme()
t.Fatalf("Failed to add meta to scheme: %v", err) if err := metav1.AddMetaToScheme(scheme); err != nil {
} t.Fatalf("Failed to add meta to scheme: %v", err)
scheme.AddKnownTypes(schema.GroupVersion{Version: "v1"}, &metav1.Status{}) }
codecs := serializer.NewCodecFactory(scheme) scheme.AddKnownTypes(schema.GroupVersion{Version: "v1"}, &metav1.Status{})
negotiatedSerializer := codecs.WithoutConversion() codecs := serializer.NewCodecFactory(scheme)
negotiatedSerializer := codecs.WithoutConversion()
ctx := WithAuditContext(context.Background()) ctx := WithAuditContext(context.Background())
ac := AuditContextFrom(ctx) ac := AuditContextFrom(ctx)
captureSink := &capturingAuditSink{} captureSink := &capturingAuditSink{}
if err := ac.Init(RequestAuditConfig{Level: auditinternal.LevelRequestResponse}, captureSink); err != nil { if err := ac.Init(RequestAuditConfig{Level: tc.level}, captureSink); err != nil {
t.Fatalf("Failed to initialize audit context: %v", err) t.Fatalf("Failed to initialize audit context: %v", err)
} }
LogResponseObject(ctx, testStatus, schema.GroupVersion{Group: "", Version: "v1"}, negotiatedSerializer) LogResponseObject(ctx, tc.status, schema.GroupVersion{Group: "", Version: "v1"}, negotiatedSerializer)
ac.ProcessEventStage(ctx, auditinternal.StageResponseComplete) ac.ProcessEventStage(ctx, auditinternal.StageResponseComplete)
if len(captureSink.events) != 1 { if len(captureSink.events) != 1 {
t.Fatalf("Expected one audit event to be captured, got %d", len(captureSink.events)) t.Fatalf("Expected one audit event to be captured, got %d", len(captureSink.events))
} }
event := captureSink.events[0] event := captureSink.events[0]
if event.ResponseObject == nil { if tc.expectResponseObj {
t.Fatal("Expected ResponseObject to be set, but it was nil") if event.ResponseObject == nil {
} t.Error("Expected ResponseObject to be set, but it was nil")
if event.ResponseStatus == nil { }
t.Fatal("Expected ResponseStatus to be set for Status object, but it was nil") } else {
} if event.ResponseObject != nil {
if event.ResponseStatus.Status != "Success" { t.Error("Expected ResponseObject to be nil")
t.Errorf("Expected ResponseStatus.Status to be 'Success', got %q", event.ResponseStatus.Status) }
} }
if event.ResponseStatus.Message != "Test status message" {
t.Errorf("Expected ResponseStatus.Message to be 'Test status message', got %q", event.ResponseStatus.Message) if tc.expectStatusFields {
} if event.ResponseStatus == nil {
if event.ResponseStatus.Reason != "TestReason" { t.Fatal("Expected ResponseStatus to be set, but it was nil")
t.Errorf("Expected ResponseStatus.Reason to be 'TestReason', got %q", event.ResponseStatus.Reason) }
} if event.ResponseStatus.Status != tc.status.Status {
if event.ResponseStatus.Code != 200 { t.Errorf("Expected ResponseStatus.Status to be %q, got %q", tc.status.Status, event.ResponseStatus.Status)
t.Errorf("Expected ResponseStatus.Code to be 200, got %d", event.ResponseStatus.Code) }
if event.ResponseStatus.Message != tc.status.Message {
t.Errorf("Expected ResponseStatus.Message to be %q, got %q", tc.status.Message, event.ResponseStatus.Message)
}
if event.ResponseStatus.Code != tc.status.Code {
t.Errorf("Expected ResponseStatus.Code to be %d, got %d", tc.status.Code, event.ResponseStatus.Code)
}
} else if event.ResponseStatus != nil {
t.Error("Expected ResponseStatus to be nil")
}
})
} }
} }
@ -179,6 +204,18 @@ func TestLogResponseObjectLevelCheck(t *testing.T) {
expectResponseObj: false, expectResponseObj: false,
expectStatusFields: false, expectStatusFields: false,
}, },
{
name: "Metadata level with Status should log status fields without encoding",
level: auditinternal.LevelMetadata,
obj: &metav1.Status{
Status: "Success",
Message: "Test message",
Code: 200,
},
shouldEncode: false,
expectResponseObj: false,
expectStatusFields: true,
},
{ {
name: "Request level with Pod should not encode or log", name: "Request level with Pod should not encode or log",
level: auditinternal.LevelRequest, level: auditinternal.LevelRequest,
@ -270,10 +307,8 @@ func TestLogResponseObjectLevelCheck(t *testing.T) {
t.Errorf("Expected ResponseStatus.Code to be %d, got %d", status.Code, event.ResponseStatus.Code) t.Errorf("Expected ResponseStatus.Code to be %d, got %d", status.Code, event.ResponseStatus.Code)
} }
} }
} else { } else if event.ResponseStatus != nil {
if event.ResponseStatus != nil { t.Error("Expected ResponseStatus to be nil")
t.Error("Expected ResponseStatus to be nil")
}
} }
}) })
} }