kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #50776 from kevin-wangzefeng/core-to-corev1-round2 

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use the core client with explicit version globally

**What this PR does / why we need it**:
As mentioned in #49535 and #50605, we want to have a global replace to use core client with explicit version.

**Which issue this PR fixes**: fixes #49535

**Special notes for your reviewer**:
The actual type of clientSet.Core() is already the same with clientSet.CoreV1(), so it should be safe replacement.
The places that clientSet.Core() are still in use are identified by IDE "find usages", and changes are made with one time global replace. Hopefully there will be none left after this PR merged.
Let me know if this PR is too big to review, I can split it into some smaller ones.

/cc @kubernetes/sig-api-machinery-pr-reviews
/cc @k82cn @sttts

**Release note**:

```release-note
none
```

Kubernetes-commit: d8ec716f4d7cabc8fa1fc825b20feffe105e99a9
This commit is contained in:
Kubernetes Publisher 2017-10-27 03:09:05 -07:00
parent 7001bc4df8 41430fda7c
commit bc81e99099
2 changed files with 1641 additions and 1641 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3280
Godeps/Godeps.json generated
View File

File diff suppressed because it is too large Load Diff

2
pkg/admission/plugin/namespace/lifecycle/admission.go
View File

@ -165,7 +165,7 @@ func (l *lifecycle) Admit(a admission.Attributes) error {
// refuse to operate on non-existent namespaces // refuse to operate on non-existent namespaces
if !exists || forceLiveLookup { if !exists || forceLiveLookup {
// as a last resort, make a call directly to storage // as a last resort, make a call directly to storage
namespace, err = l.client.Core().Namespaces().Get(a.GetNamespace(), metav1.GetOptions{}) namespace, err = l.client.CoreV1().Namespaces().Get(a.GetNamespace(), metav1.GetOptions{})
switch { switch {
case errors.IsNotFound(err): case errors.IsNotFound(err):
return err return err