update admission test cases
Kubernetes-commit: 82c3d2492cb43f9f81e8a18e1dce2e8ab7e4e56a
This commit is contained in:
hzxuzhonghu
Kubernetes Publisher
parent
b636311708
commit
d395a1e811
|
|
@ -18,26 +18,80 @@ package options
|
|||
|
||||
import (
|
||||
"fmt"
|
||||
"io"
|
||||
"testing"
|
||||
|
||||
"k8s.io/apimachinery/pkg/util/sets"
|
||||
"k8s.io/apiserver/pkg/admission"
|
||||
)
|
||||
|
||||
func TestEnabledPluginNamesMethod(t *testing.T) {
|
||||
func TestEnabledPluginNames(t *testing.T) {
|
||||
scenarios := []struct {
|
||||
expectedPluginNames []string
|
||||
setDefaultOffPluginNames []string
|
||||
setDefaultOffPlugins sets.String
|
||||
setRecommendedPluginOrder []string
|
||||
setEnablePlugins []string
|
||||
setDisablePlugins []string
|
||||
setAdmissionControl []string
|
||||
}{
|
||||
// scenario 1: check if a call to enabledPluginNames sets expected values.
|
||||
// scenario 0: check if a call to enabledPluginNames sets expected values.
|
||||
{
|
||||
expectedPluginNames: []string{"NamespaceLifecycle"},
|
||||
},
|
||||
|
||||
// scenario 2: overwrite RecommendedPluginOrder and set DefaultOffPluginNames
|
||||
// make sure that plugins which are on DefaultOffPluginNames list do not get to PluginNames list.
|
||||
// scenario 1: use default off plugins if no specified
|
||||
{
|
||||
expectedPluginNames: []string{"pluginA"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB"},
|
||||
setDefaultOffPluginNames: []string{"pluginB"},
|
||||
expectedPluginNames: []string{"pluginB"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString("pluginA", "pluginC", "pluginD"),
|
||||
},
|
||||
|
||||
// scenario 2: use default off plugins and with RecommendedPluginOrder
|
||||
{
|
||||
expectedPluginNames: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString(),
|
||||
},
|
||||
|
||||
// scenario 3: use default off plugins and specified by enable-admission-plugin with RecommendedPluginOrder
|
||||
{
|
||||
expectedPluginNames: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString("pluginC", "pluginD"),
|
||||
setEnablePlugins: []string{"pluginD", "pluginC"},
|
||||
},
|
||||
|
||||
// scenario 4: use default off plugins and specified by disable-admission-plugin with RecommendedPluginOrder
|
||||
{
|
||||
expectedPluginNames: []string{"pluginB"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString("pluginC", "pluginD"),
|
||||
setDisablePlugins: []string{"pluginA"},
|
||||
},
|
||||
|
||||
// scenario 5: use default off plugins and specified by enable-admission-plugin and disable-admission-plugin with RecommendedPluginOrder
|
||||
{
|
||||
expectedPluginNames: []string{"pluginA", "pluginC"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString("pluginC", "pluginD"),
|
||||
setEnablePlugins: []string{"pluginC"},
|
||||
setDisablePlugins: []string{"pluginB"},
|
||||
},
|
||||
|
||||
// scenario 6: use default off plugins and specified by admission-control with RecommendedPluginOrder
|
||||
{
|
||||
expectedPluginNames: []string{"pluginA", "pluginB", "pluginC"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString("pluginD"),
|
||||
setAdmissionControl: []string{"pluginA", "pluginB"},
|
||||
},
|
||||
|
||||
// scenario 7: use default off plugins and specified by admission-control with RecommendedPluginOrder
|
||||
{
|
||||
expectedPluginNames: []string{"pluginA", "pluginB", "pluginC"},
|
||||
setRecommendedPluginOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
setDefaultOffPlugins: sets.NewString("pluginC", "pluginD"),
|
||||
setAdmissionControl: []string{"pluginA", "pluginB", "pluginC"},
|
||||
},
|
||||
}
|
||||
|
||||
|
|
@ -46,12 +100,21 @@ func TestEnabledPluginNamesMethod(t *testing.T) {
|
|||
t.Run(fmt.Sprintf("scenario %d", index), func(t *testing.T) {
|
||||
target := NewAdmissionOptions()
|
||||
|
||||
if len(scenario.setDefaultOffPluginNames) > 0 {
|
||||
target.DefaultOffPlugins = scenario.setDefaultOffPluginNames
|
||||
if scenario.setDefaultOffPlugins != nil {
|
||||
target.DefaultOffPlugins = scenario.setDefaultOffPlugins
|
||||
}
|
||||
if len(scenario.setRecommendedPluginOrder) > 0 {
|
||||
if scenario.setRecommendedPluginOrder != nil {
|
||||
target.RecommendedPluginOrder = scenario.setRecommendedPluginOrder
|
||||
}
|
||||
if scenario.setEnablePlugins != nil {
|
||||
target.EnablePlugins = scenario.setEnablePlugins
|
||||
}
|
||||
if scenario.setDisablePlugins != nil {
|
||||
target.DisablePlugins = scenario.setDisablePlugins
|
||||
}
|
||||
if scenario.setAdmissionControl != nil {
|
||||
target.EnablePlugins = scenario.setAdmissionControl
|
||||
}
|
||||
|
||||
actualPluginNames := target.enabledPluginNames()
|
||||
|
||||
|
|
@ -66,3 +129,111 @@ func TestEnabledPluginNamesMethod(t *testing.T) {
|
|||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestValidate(t *testing.T) {
|
||||
scenarios := []struct {
|
||||
setEnablePlugins []string
|
||||
setDisablePlugins []string
|
||||
setRecommendedPluginsOrder []string
|
||||
expectedResult bool
|
||||
}{
|
||||
// scenario 0: not set any flag
|
||||
{
|
||||
expectedResult: true,
|
||||
},
|
||||
|
||||
// scenario 1: set both `--enable-admission-plugin` `--disable-admission-plugin`
|
||||
{
|
||||
setEnablePlugins: []string{"pluginA", "pluginB"},
|
||||
setDisablePlugins: []string{"pluginC"},
|
||||
expectedResult: true,
|
||||
},
|
||||
|
||||
// scenario 2: set invalid `--enable-admission-plugin` `--disable-admission-plugin`
|
||||
{
|
||||
setEnablePlugins: []string{"pluginA", "pluginB"},
|
||||
setDisablePlugins: []string{"pluginB"},
|
||||
expectedResult: false,
|
||||
},
|
||||
|
||||
// scenario 3: set only invalid `--enable-admission-plugin`
|
||||
{
|
||||
setEnablePlugins: []string{"pluginA", "pluginE"},
|
||||
expectedResult: false,
|
||||
},
|
||||
|
||||
// scenario 4: set only invalid `--disable-admission-plugin`
|
||||
{
|
||||
setDisablePlugins: []string{"pluginA", "pluginE"},
|
||||
expectedResult: false,
|
||||
},
|
||||
|
||||
// scenario 5: set valid `--enable-admission-plugin`
|
||||
{
|
||||
setEnablePlugins: []string{"pluginA", "pluginB"},
|
||||
expectedResult: true,
|
||||
},
|
||||
|
||||
// scenario 6: set valid `--disable-admission-plugin`
|
||||
{
|
||||
setDisablePlugins: []string{"pluginA"},
|
||||
expectedResult: true,
|
||||
},
|
||||
|
||||
// scenario 7: RecommendedPluginOrder has duplicated plugin
|
||||
{
|
||||
setRecommendedPluginsOrder: []string{"pluginA", "pluginB", "pluginB", "pluginC"},
|
||||
expectedResult: false,
|
||||
},
|
||||
|
||||
// scenario 8: RecommendedPluginOrder not equal to registered
|
||||
{
|
||||
setRecommendedPluginsOrder: []string{"pluginA", "pluginB", "pluginC"},
|
||||
expectedResult: false,
|
||||
},
|
||||
|
||||
// scenario 9: RecommendedPluginOrder equal to registered
|
||||
{
|
||||
setRecommendedPluginsOrder: []string{"pluginA", "pluginB", "pluginC", "pluginD"},
|
||||
expectedResult: true,
|
||||
},
|
||||
|
||||
// scenario 10: RecommendedPluginOrder not equal to registered
|
||||
{
|
||||
setRecommendedPluginsOrder: []string{"pluginA", "pluginB", "pluginC", "pluginE"},
|
||||
expectedResult: false,
|
||||
},
|
||||
}
|
||||
|
||||
for index, scenario := range scenarios {
|
||||
t.Run(fmt.Sprintf("scenario %d", index), func(t *testing.T) {
|
||||
options := NewAdmissionOptions()
|
||||
options.DefaultOffPlugins = sets.NewString("pluginC", "pluginD")
|
||||
options.RecommendedPluginOrder = []string{"pluginA", "pluginB", "pluginC", "pluginD"}
|
||||
options.Plugins = &admission.Plugins{}
|
||||
for _, plugin := range options.RecommendedPluginOrder {
|
||||
options.Plugins.Register(plugin, func(config io.Reader) (admission.Interface, error) {
|
||||
return nil, nil
|
||||
})
|
||||
}
|
||||
|
||||
if scenario.setEnablePlugins != nil {
|
||||
options.EnablePlugins = scenario.setEnablePlugins
|
||||
}
|
||||
if scenario.setDisablePlugins != nil {
|
||||
options.DisablePlugins = scenario.setDisablePlugins
|
||||
}
|
||||
if scenario.setRecommendedPluginsOrder != nil {
|
||||
options.RecommendedPluginOrder = scenario.setRecommendedPluginsOrder
|
||||
}
|
||||
|
||||
err := options.Validate()
|
||||
if len(err) > 0 && scenario.expectedResult {
|
||||
t.Errorf("Unexpected err: %v", err)
|
||||
}
|
||||
if len(err) == 0 && !scenario.expectedResult {
|
||||
t.Errorf("Expect error, but got none")
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue