From e2884e1186deaa68e3fb45e4c544434093c1a511 Mon Sep 17 00:00:00 2001 From: Davanum Srinivas Date: Fri, 4 Jan 2019 15:26:07 -0500 Subject: [PATCH] Revert "Generate Stack Traces for http response with status code zero" Does not help with the bug investigation. the http server is designed to panic when the http status code is `0`. This reverts commit 72792d59f46f822cf360e797d886e582a6a2dc60. Kubernetes-commit: 85ae15621af1d71caf5d0bac2299d17ec1020664 --- pkg/server/filters/wrap.go | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/pkg/server/filters/wrap.go b/pkg/server/filters/wrap.go index 38ab58554..0a7584561 100644 --- a/pkg/server/filters/wrap.go +++ b/pkg/server/filters/wrap.go @@ -25,17 +25,6 @@ import ( "k8s.io/apiserver/pkg/server/httplog" ) -func badHTTPResponse() httplog.StacktracePred { - return func(status int) bool { - // http status code should not be zero - if status == 0 { - klog.Errorf("Bad HTTP Response - status is zero") - return true - } - return false - } -} - // WithPanicRecovery wraps an http Handler to recover and log panics. func WithPanicRecovery(handler http.Handler) http.Handler { return withPanicRecovery(handler, func(w http.ResponseWriter, req *http.Request, err interface{}) { @@ -50,7 +39,7 @@ func withPanicRecovery(handler http.Handler, crashHandler func(http.ResponseWrit crashHandler(w, req, err) }) - logger := httplog.NewLogged(req, &w).StacktraceWhen(badHTTPResponse()) + logger := httplog.NewLogged(req, &w) defer logger.Log() // Dispatch to the internal handler