iQEcBAABCAAGBQJYhok+AAoJED0WkGtPHFyzhlMIAKUGDc5OG9u8AFgmZaRWp+ig

tTAd5vL479Y9GX0sorhbGZbXS5+ylqEfbkZQC1A4eoDOmt+dkC8jdHgUZmEwwKOM
 V/CH09SAkEa8MhxDbASV0J0oSWphMdOCMtIotB/M2S9TMNCMBDusj1VkB8kUXgKW
 MUnabb90dkFGtYWiPKNx+TVmv0T9fMWvODL24yKzLn13R+Wjk+4FfrEPFacEnsv3
 uaLAgxenhoGyf18E3d4ij6DW8c23Xrdn+s2hDL9WOtELGCUYaflU7q2Udz8DZIKu
 GLcfVzdTpcjw5Q8fdDNykxLq6+18L92V2Wj3wzWEVZmH6kVy2ty1hFY4o08/phc=
 =OL70
 -----END PGP SIGNATURE-----

refactor: move ListOptions references to metav1
This commit is contained in:
Clayton Coleman 2017-01-21 22:36:02 -05:00 committed by deads2k
parent d6c52064fb
commit e5842f0f5f
4 changed files with 6 additions and 6 deletions

View File

@ -63,7 +63,7 @@ const (
// userAgentKey is the context key for the request user agent.
userAgentKey
namespaceDefault = "default" // TODO(sttts): solve import cycle when using api.NamespaceDefault
namespaceDefault = "default" // TODO(sttts): solve import cycle when using metav1.NamespaceDefault
)
// NewContext instantiates a base context object for request flows.

View File

@ -19,10 +19,10 @@ package request_test
import (
"testing"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apiserver/pkg/authentication/user"
genericapirequest "k8s.io/apiserver/pkg/endpoints/request"
"k8s.io/kubernetes/pkg/api"
)
// TestNamespaceContext validates that a namespace can be get/set on a context object
@ -32,8 +32,8 @@ func TestNamespaceContext(t *testing.T) {
if !ok {
t.Fatalf("Error getting namespace")
}
if api.NamespaceDefault != result {
t.Fatalf("Expected: %s, Actual: %s", api.NamespaceDefault, result)
if metav1.NamespaceDefault != result {
t.Fatalf("Expected: %s, Actual: %s", metav1.NamespaceDefault, result)
}
ctx = genericapirequest.NewContext()

View File

@ -176,7 +176,7 @@ func (r *RequestInfoFactory) NewRequestInfo(req *http.Request) (*RequestInfo, er
}
}
} else {
requestInfo.Namespace = "" // TODO(sttts): solve import cycle when using api.NamespaceNone
requestInfo.Namespace = "" // TODO(sttts): solve import cycle when using metav1.NamespaceNone
}
// parsing successful, so we now know the proper value for .Parts

View File

@ -31,7 +31,7 @@ func (f fakeRL) TryAccept() bool { return bool(f) }
func (f fakeRL) Accept() {}
func TestGetAPIRequestInfo(t *testing.T) {
namespaceAll := "" // TODO(sttts): solve import cycle when using api.NamespaceAll
namespaceAll := "" // TODO(sttts): solve import cycle when using metav1.NamespaceAll
successCases := []struct {
method string
url string