kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Promote RetryGenerateName to beta 

Kubernetes-commit: 1b59f3678fa95cb6bf647e349dd8ba023914eff0
This commit is contained in:
Joe Betz 2024-05-01 20:34:21 -04:00 committed by Kubernetes Publisher
parent dad1c2ae20
commit e721afc903
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/features/kube_features.go
View File

@ -335,7 +335,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
RemainingItemCount: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.32
RetryGenerateName: {Default: false, PreRelease: featuregate.Alpha},
RetryGenerateName: {Default: true, PreRelease: featuregate.Beta},
SeparateCacheWatchRPC: {Default: true, PreRelease: featuregate.Beta},

4
pkg/registry/generic/registry/store_test.go
View File

@ -399,7 +399,6 @@ func (m *sequentialNameGenerator) GenerateName(base string) string {
}
func TestStoreCreateWithRetryNameGenerate(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, true)
namedObj := func(id int) *example.Pod {
return &example.Pod{
@ -448,6 +447,7 @@ func TestStoreCreateWithRetryNameGenerate(t *testing.T) {
}
func TestStoreCreateWithRetryNameGenerateFeatureDisabled(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, false)
namedObj := func(id int) *example.Pod {
return &example.Pod{
ObjectMeta: metav1.ObjectMeta{Name: fmt.Sprintf("prefix-%d", id), Namespace: "test"},
@ -2973,6 +2973,8 @@ func (p *predictableNameGenerator) GenerateName(base string) string {
}
func TestStoreCreateGenerateNameConflict(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, false)
// podA will be stored with name foo12345
podA := &example.Pod{
ObjectMeta: metav1.ObjectMeta{Name: "foo1", Namespace: "test"},