store: etcd: TestWatch: use cmp.Diff

Modernize the comparisons used in the watch tests to use `cmp.Diff()` for
readability.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

Kubernetes-commit: d17a19b39d2dbdaf2cbbaad46de403d6d7ce0602
This commit is contained in:
Steve Kuznetsov 2022-02-18 06:51:36 -08:00 committed by Kubernetes Publisher
parent 557ecdf10d
commit fb315d8c17
1 changed files with 3 additions and 3 deletions

View File

@ -19,11 +19,11 @@ package etcd3
import (
"context"
"fmt"
"reflect"
"sync"
"testing"
"time"
"github.com/google/go-cmp/cmp"
clientv3 "go.etcd.io/etcd/client/v3"
"k8s.io/apimachinery/pkg/api/apitesting"
@ -390,8 +390,8 @@ func testCheckResult(t *testing.T, expectEventType watch.EventType, w watch.Inte
t.Errorf("event type want=%v, get=%v", expectEventType, res.Type)
return
}
if !reflect.DeepEqual(expectObj, res.Object) {
t.Errorf("obj want=\n%#v\nget=\n%#v", expectObj, res.Object)
if diff := cmp.Diff(expectObj, res.Object); diff != "" {
t.Errorf("incorrect obj: %s", diff)
}
case <-time.After(wait.ForeverTestTimeout):
t.Errorf("time out after waiting %v on ResultChan", wait.ForeverTestTimeout)