kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,292 Commits 29 Branches 1,436 Tags 31 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Mike Danese a6a121887a force implementors of dyanmiccertificates providers to think about notify 
Right now, `_, ok := provider.(Notifier); !ok` can mean one of two
things:

1. The provider does not support notification because the provided
   content is static.
2. The implementor of the provider hasn't gotten around to implementing
   Notifier yet.

These have very different implications. We should not force consumers of
these interfaces to have to figure out the static of Notifier across
sometimes numerous different implementations. Instead, we should force
implementors to implement Notifier, even if it's a noop.

Change-Id: Ie7a26697a9a17790bfaa58d67045663bcc71e3cb

Kubernetes-commit: 9b7d654a08d694d20226609f7075b112fb18639b
 2021-04-09 16:59:17 -07:00
Monis Khan 091c53ac7a dynamic certs: do not copy mutex via shallow copy of tls.Config 
go vet error:

call of dynamiccertificates.NewDynamicServingCertificateController
copies lock value: crypto/tls.Config contains sync.Once contains
sync.Mutex

Signed-off-by: Monis Khan <mok@vmware.com>

Kubernetes-commit: 86a5993007e3c781749a5099b540307f65a4f377
 2020-03-03 14:58:43 -05:00
David Eads 2e81ed6ee9 allow an SNI cert to be used to respond for a particular IP 
Kubernetes-commit: 2c8639deb70c5934109022372caa32ca029db473
 2019-11-14 16:08:11 -05:00