kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,150 Commits 30 Branches 1,482 Tags 31 MiB
Commit Graph

181 Commits

Author SHA1 Message Date
Wei Huang a67f43f565 Remove `EvenPodsSpread` featuregate and related logic 
Kubernetes-commit: 133dde63589bfb9f149607d1e8f6ae519d41719f
 2020-05-27 14:24:26 -07:00
Tariq Ibrahim d8082ddfe6 s/RelicaSets/ReplicaSets 
Kubernetes-commit: 9760dec9dc84d68c6613887128de192b4a66feff
 2020-04-29 12:59:05 -07:00
Davanum Srinivas 5879417a28 switch over k/k to use klog v2 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Kubernetes-commit: 442a69c3bdf6fe8e525b05887e57d89db1e2f3a5
 2020-04-17 15:25:06 -04:00
Antoine Pelisse 05f95a480d managedfields: Update Apply time if neither object nor managedfields have changed 
Kubernetes-commit: 5231c6815c7b06248575892f3ec96c15c634d368
 2020-03-05 13:13:27 -08:00
Antoine Pelisse c81c86d33f Bump sigs.k8s.io/structured-merge-diff to v3 
Kubernetes-commit: df41fd932bef1686b30a1abee477c5009ebabe80
 2020-03-05 13:09:50 -08:00
Antoine Pelisse 2ff45c3592 fieldmanager: Add failing test for no-op apply actually writing to etcd 
Kubernetes-commit: 7120abe6989afff0d4ad879a4590a960f4ab19f0
 2020-03-05 10:09:08 -08:00
Antoine Pelisse 5de3b6339e fieldmanager: Move ManagedFields update logic into its own class 
Kubernetes-commit: 39681aa5800492b8e4b4ff5fb82e034376864a37
 2020-03-05 10:01:37 -08:00
Antoine Pelisse 82ecbdb375 Don't log "SHOULD NOT HAPPEN" errors more than once per second 
Kubernetes-commit: 389dd0a499e4fa79d3d2ef4261aa9f25aa94e6b0
 2020-02-26 15:58:57 -08:00
Antoine Pelisse 07f3bde07d Enable field management for all new objects 
Kubernetes-commit: a54a52c5de3458bfa5dbe1973d12584f59a5581c
 2020-02-10 09:06:18 -08:00
Yu-Ju Hong 809bbdf7f8 Replace Beta OS/arch labels with the GA ones 
Beta OS/arch labels have been deprecated since 1.14.
This change replaces these labels with the GA ones.

Kubernetes-commit: bcd975aa6575ae37ec3be3481e44cd0dccd02337
 2020-02-12 11:30:39 -08:00
jennybuckley 4e7f113e29 Round times to nearest second before sorting 
Kubernetes-commit: 888a322d9ca3070b811b348e05ee4a3ce7da6ae9
 2020-02-11 11:54:21 -08:00
Jordan Liggitt 51a2cc34eb Lower server-side apply percentage to 10% 
Kubernetes-commit: a657d51ce35eb3886a56ed710805cd68732461ee
 2020-02-11 09:15:12 -05:00
Antoine Pelisse 3104ef647b Enable field management for all new objects 
Kubernetes-commit: 8438bba5fd911c4674e46519228e6c47b5057346
 2020-02-10 09:06:18 -08:00
Joe Betz dced5f29d8 Bump to latest SMD to pick up performance optimizations 
Kubernetes-commit: d9faaca64738a50455f38dd88845e8b4b5ca37e2
 2020-02-06 15:10:25 -08:00
Antoine Pelisse 977fdf9f57 Add UpdateTwice and UpdateApply benchmarks for fieldmanager 
I've also moved the deserialization of the object outside the benchmark
since we're not trying to benchmark the yaml parser.

Kubernetes-commit: a52776fbfb305374d87bb553739f712e055b2206
 2020-02-06 09:25:52 -08:00
jennybuckley 0fe6670327 Make schema error log message more useful 
Kubernetes-commit: fee77388c6d4cc04731f35055d9dfcdf08b0f874
 2020-01-29 15:01:44 -08:00
jennybuckley 605316fae2 Re-enable apply for 50% of requests 
Kubernetes-commit: 9b679748239faa4d01f13c32af1956ffdbfff9aa
 2020-01-23 11:27:20 -08:00
jennybuckley 49d583f0ef Update Structured Merge Diff to V3 
Kubernetes-commit: b33fbc84d9d6e7033c36fa3bc321b8fea28ceed6
 2020-01-21 15:03:56 -08:00
Jordan Liggitt 223f76bd7a Set managedField probability to 0% 
Lowers probability of managedField population on create/update to 0%
until serialization/normalization issues are resolved

Kubernetes-commit: ba23aa98f6574bd1f9781f0d3e61d0496f16fc53
 2020-01-14 14:47:35 -05:00
Jennifer Buckley 2ac09e3ec3 Update fieldmanager.go 
Kubernetes-commit: 4db3822ebbac30248463eb529d88176f8b258fd9
 2020-01-10 11:15:06 -08:00
jennybuckley d516617523 create probabilistic SkipNonAppliedManager 
Kubernetes-commit: 6cab3a7bec75e42581e8041395c3ceaa14e07c74
 2020-01-09 14:15:34 -08:00
Kevin Wiesmüller 4694e4eb62 fix nits 
Kubernetes-commit: a2526286498762de187db23f13da5d747ddd1c90
 2020-01-10 00:58:52 +01:00
Kevin Wiesmüller 41bde5b991 change Apply signature and move decoding into handlers 
Kubernetes-commit: ddf0d4b8034697a8dca23a3c8bc5620629bd691b
 2020-01-09 22:34:33 +01:00
sshukun 38b2d97314 Fix golint failure not contained in .golint_failures 
Kubernetes-commit: 8110e08dd4abd4458b2d3793f5c1eb50069ae7df
 2019-12-19 14:40:26 +09:00
Jordan Liggitt e00fbd05dd Use openapi fixture for server-side apply tests 
Kubernetes-commit: 2b4fac5760ff390d46c2b9bb373feafe9bd97a38
 2019-12-04 10:29:48 -05:00
Antoine Pelisse bab2370cac Update structured-merge-diff to latest version 
Kubernetes-commit: 4f0346530d3e228db20aca6bb484d3ed3c83e33b
 2019-11-06 09:53:38 -08:00
jennybuckley 72d976a445 Cap the number of managedFields entries for updates at 10 
Kubernetes-commit: 61b19c729892a150b61dde19359f6fb19e8d61f1
 2019-09-26 12:53:28 -07:00
jennybuckley 49914e3423 Refactor fieldmanager to be more modular 
Kubernetes-commit: d72260b9dad186d96aa621dc8594ca9bd6088937
 2019-09-19 13:14:36 -07:00
Jordan Liggitt f7fbf2eee4 Limit YAML/JSON decode size 
Kubernetes-commit: 8ef4566cefebf49f9a806a36df2105c9149785a1
 2019-09-27 16:36:48 -04:00
Antoine Pelisse 3e0b6a7493 Apply current parses the yaml object 3 times 
This is super expensive and not needed at all since we don't have to
reparse the entire object. Remove all allocations but the first one.

Kubernetes-commit: 31c644a1e79c685b52683ed1e84964186a37f3ff
 2019-09-25 12:38:38 -07:00
Antoine Pelisse 81b54ad46e Add tests and benchmarks for endpoints and node 
Kubernetes-commit: 0b7ea8bb0e9cc10335044f9ef75920d59462a4ca
 2019-09-20 13:32:06 -07:00
Antoine Pelisse db9f1ff5ea Improve fieldmanager tests and benchmarks 
Kubernetes-commit: fae9d0ee2136d3443cdd87b1a26a06d7857b01ee
 2019-09-10 14:06:08 -07:00
jennybuckley 6c75819b84 Split fieldmanager with interface 
Kubernetes-commit: 2c67bf47db8557b6481a5181bdae924e91665988
 2019-09-12 10:57:21 -07:00
Antoine Pelisse 912f3b47b9 Refactor FieldManager tests to make them simpler 
This is the first step on this, but there are a few improvements that
I'd like to do here.

Kubernetes-commit: b10ad55119a155b776b272a7139dfbed604b05d6
 2019-09-10 15:05:26 -07:00
Ted Yu a50931ba7e Move Update Apply conflict test to field manager test 
Kubernetes-commit: 9828f986afd4db79a10c78bee1cc2e449faee3a6
 2019-08-30 14:47:39 -07:00
Kubernetes Prow Robot c229c2ca0a Merge pull request #81453 from joshmsamuels/master 
Apply will fail with managed fields + tests

Kubernetes-commit: 64718f678695884c93d6d3df8f5799614746bea2
 2019-09-13 08:22:53 +00:00
jennybuckley b1cbdafe99 Use CRD validation field in server-side apply 
Kubernetes-commit: c0617933d4bec5b00dbbfcd24edb7d7e7fc5509d
 2019-08-28 15:28:49 -07:00
Antoine Pelisse 625e8a84fc Add new FieldsType to clarify the format of Fields 
Kubernetes-commit: ff4e1f3592bfd51aea3018ed7e0a8579e5c0eea1
 2019-08-21 16:13:53 -07:00
jennybuckley 263df041f9 Add tests 
Kubernetes-commit: 3279c73945553e211ddb7812e07b3c9d46b5e96a
 2019-08-22 13:27:38 -07:00
jennybuckley 350fef76f5 Only update managedFields on update if it already exists 
Kubernetes-commit: 9a12e37a6dc28fd1d209eb84c210eb0723e6e38f
 2019-06-05 14:09:08 -07:00
jennybuckley dcedf932c2 Make sure no op updates don't affect the resource version 
Kubernetes-commit: aa1f01ec7e6ebf29444b93de7c3cb65a1a54d47e
 2019-08-20 15:09:42 -07:00
jennybuckley 427507ed32 Group update managedFieldsEntries by manager name 
Kubernetes-commit: 87eabcdbfa5d551af7ebcae3fb07fd8f386badc3
 2019-08-19 13:50:15 -07:00
jennybuckley d98d4e6ca0 Use raw bytes in metav1.Fields instead of map 
Also define custom proto unmarshaller that understands the old format

Kubernetes-commit: addad99b6f796bc0f0a2eeafa0296396667800e9
 2019-07-31 16:05:48 -07:00
Daniel Smith 1fc8fb4c4b fix breaking change 
Kubernetes-commit: f55efb8dae5b41a8af083dc96c53b5b6f6e59b49
 2019-07-19 15:25:56 -07:00
jennybuckley 6d17cee146 Make changes to integrate new version 
Kubernetes-commit: 229894c730c70d39992b27fe3ef98968b2a3fbff
 2019-07-08 16:32:03 -07:00
jennybuckley 5751866f63 apiserver: make changes to integrate new structured-merge-patch 
Kubernetes-commit: bd333e3ac7f84c33abebc7d55a8c581743d891f7
 2019-07-08 16:32:03 -07:00
Antoine Pelisse 2f450e5e39 Add benchmarks for FieldManager handling 
We don't have a lot of data on allocations and how much time it takes to
run apply or update on objects, so adding some benchmark will help us
investigate possible improvements.

Kubernetes-commit: 92cf3764f979e63317c8f483d8e841e0358599f4
 2019-07-09 14:00:21 -07:00
jennybuckley e67aadb10a Don't dereference nil pointer in conflicts 
Kubernetes-commit: c71583a31368d1e4e71cd458d6961d8fec2265f1
 2019-06-13 14:42:19 -07:00
zhoulin xie 77ddb0c208 remove redundant words 'the' in comment 
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>

Kubernetes-commit: 77ba845e6d2f0cba81993621531ae5915e7c072b
 2019-02-13 22:40:34 +08:00
Antoine Pelisse 2d27d30e4d fieldManager: Ignore conversion errors to internal types 
Errors on updates are bad because they usually come from controllers and
it's very hard to take actions on them. We also don't want to start
breaking kubernetes clusters if something in a schema happens a way we
didn't foresee (even though we've tried to be diligent and test as much
as possible, these can still happen).

Log an identifiable error when they happen. Ideally people can look in
the logs to find these and report them, or providers can look for these
in logs and make sure they don't happen.

Only conversion to internal types are going to be logged and ignored.

It means that we're still failing for:
- Version conversions. If we can't convert the object from one version
  to another,
- Unions. If we can't normalize the union,
- Invalid MangedFields sent in the object. If something has changed the
  ManagedFields to an invalid value.
- Failure to serialize the manager information, this really shouldn't
  happen.
- Encoding the ManagedFields

Kubernetes-commit: 4e32d183d0257c9f6c7f8342d1f9aa7f28458f2f
 2019-05-16 11:07:47 -07:00
jennybuckley e999a5ebe2 Treat NoCorrespondingTypeError as MissingVersionError 
Kubernetes-commit: 13cb241b1833495c8f195dac96dacf54c0ba4a3a
 2019-05-06 15:13:36 -07:00
jennybuckley aabe804197 Fix int/float apply bug 
Kubernetes-commit: 10259c959e9f20668659f7e20251a217b51c6355
 2019-03-11 23:07:21 -07:00
Aaron Prindle a595f8c602 Added version check between patch and live object in server side apply 
What is the problem being solved?
https://github.com/kubernetes/kubernetes/pull/75135
Currently version compatibility is not being checked in server side apply between the patch object and the live object.  This is causing a merge that will error to be run and the apiserver returns a 500 error.  The request should fail if the apiVersion provided in the object is different from the apiVersion in the url, but it should fail before trying to merge, and be a 4xx error. Probably a bad request error.

Why is this the best approach?
The approach of serializing the patch byte array and then checking for version equality with the already serialized live object is the simplest and most straightforward solution.

Kubernetes-commit: d5bd17cda0c134e5ef5c03c3eac79a9ce4e18003
 2019-03-07 16:52:26 -08:00
jennybuckley 2deaad0322 Fix version converter 
Kubernetes-commit: f9e57744d3e760b1473cb22e655d20c254af03b6
 2019-03-07 17:44:21 -08:00
Antoine Pelisse 46d98f52ff Add "fieldManager" to flag to PATCH/CREATE/UPDATE 
And add a corresponding flag in kubectl (for apply), even though the
value is defaulted in kubectl with "kubectl".

The flag is required for Apply patch-type, and optional for other PATCH,
CREATE and UPDATE (in which case we fallback on the user-agent).

Kubernetes-commit: eb904d8fa89da491f400614f99458ed3f0d529fb
 2019-02-16 20:16:11 -08:00
Kevin Wiesmüller a2d254807d fix handling of nil times in managedFields sorting 
Kubernetes-commit: 186761efee887cee019bc92a85b3207474b42185
 2019-03-07 00:02:52 +00:00
jennybuckley 55fa47be3a add IsMissingVersionError 
Kubernetes-commit: db0562bdbd4ffe17459025fdc10c7bf318dfbc01
 2019-03-04 17:29:11 -08:00
jennybuckley 0b311f9745 Update conversion code 
Kubernetes-commit: bad7599f06cde17e9b4a51087cd0a84836b29c11
 2019-03-04 16:30:37 -08:00
Kevin Wiesmüller e08e8cdb33 change managedFields sort order to oldest first 
Kubernetes-commit: 4394bf779800710e67beae9bddde4bb5425ce039
 2019-03-05 07:45:08 +01:00
Kevin Wiesmüller 64d9391709 cleanup sort implementation 
Kubernetes-commit: 081ccdc75e4646a6b619f16852adb9ce2b4c43d4
 2019-03-02 12:07:19 +01:00
Kevin Wiesmüller 8f6431c490 implement sorting of managedFields 
Kubernetes-commit: 9ac127408d48aa0876330c79c933d4f1cd603761
 2019-03-01 12:51:01 +01:00
Kevin Wiesmüller 61f4009197 start implementing managedFields sorting 
Kubernetes-commit: 822c0da84474c50ac640629e7cb9cad01904c2f0
 2019-02-28 14:24:02 +01:00
Kevin Wiesmüller 485fbb474e test that managedFields get stripped recursively 
Kubernetes-commit: 8a6a2883f9a38e09ae941b62c14f4e68037b2d21
 2019-02-26 20:22:54 +01:00
Kevin Wiesmüller 14b16dd3e2 remove deletionTimestamp from strippedFields 
Kubernetes-commit: d73dbfc8c1bdc443cf6bf2f70a7789b689815cf7
 2019-02-26 20:22:30 +01:00
Kevin Wiesmüller 752a6fcdc7 add tests for new stripped fields and cleanup test 
Kubernetes-commit: 89f4f9d4bfe5dd14a11e94ff13b1efa676a2d59f
 2019-02-23 12:54:33 +01:00
Kevin Wiesmüller a0ddba7a54 add more fields to be stripped from managedFields 
Kubernetes-commit: 78ba7fa05c4360e217af3854c5ae5ba4e823312f
 2019-02-17 22:35:15 +01:00
Davanum Srinivas d0a81fb0fb Avoid using ghodss/yaml - switch to our forked repo 
Change-Id: I115bc834b2b8473c3a81812a76b8433fda24a908

Kubernetes-commit: 42aba643290c19a63168513bd758822e8014a0fd
 2019-02-21 18:48:28 -05:00
Kevin Wiesmüller 00e253c3da hardcode time 
Kubernetes-commit: 332bb15476ed6f7ef0b55a5a3a3a735b915ccee3
 2019-02-19 20:17:33 +01:00
Kevin Wiesmüller 0faeae1509 rename mocks to fakes and add nil check 
Kubernetes-commit: 96d4fa7e4678430046d8fee98bc715f385242e3f
 2019-02-19 19:13:49 +01:00
Kevin Wiesmüller 84fe2e0447 add fieldmanager tests for stripFields 
Kubernetes-commit: 2f8e8fa3af4b8adce5562dd1a033fd37ea8244d8
 2019-02-18 11:44:07 +01:00
jennybuckley ddd6f48420 Make apply conflict errors more readable 
Kubernetes-commit: 69b9167dcbc8eea2ca5653fa42584539920a1fd4
 2019-02-12 15:16:19 -08:00
Antoine Pelisse 3afb63e414 Revert "Temporary fix for alpha features test" 
Kubernetes-commit: 845e44dd207fc3793f8bab1b69665a816f966489
 2019-02-12 12:25:21 -08:00
Antoine Pelisse e23fc114aa Add server-side apply members on some apiserver OWNERS 
Kubernetes-commit: 83f0653a14ab304ca3c049587e40bb33e9c55353
 2019-02-08 16:10:25 -08:00
Kevin Wiesmüller fa595d7437 strip selected fields from managedFields 
refactor fieldstrip and update tests

add checks and remove empty fields

shorten test and check for nil manager

fix gofmt

panic on nil manager

Kubernetes-commit: 9082cac48240ebc316015dabb466e5b24a113dc1
 2019-02-03 22:22:10 +01:00
Ted Yu ea3640581f gofmt 
Kubernetes-commit: 4f50eb49eae1e6561263ff4abc00ea956139a2ef
 2019-02-05 13:58:42 -08:00
Ted Yu ac1ef9aea6 change case for error 
Kubernetes-commit: 1638e6698403341122cd55df61e6fe12559b0604
 2019-02-05 11:34:36 -08:00
Ted Yu cdd65830fd Misc fix for feature-serverside-apply 
Kubernetes-commit: f2e59b44ad5610bb749901b505305ba16c44fad5
 2019-02-05 10:29:38 -08:00
Jennifer Buckley 9955ab5084 Temporary fix for alpha suite 
Kubernetes-commit: 3f947e034fe6436a2075e8eb202aeaaae46e9df5
 2019-02-05 13:23:24 -08:00
jennybuckley f279314dc7 Minor fixes 
Kubernetes-commit: 6b2e4682fe883eebcaf1c1e43cf2957dde441174
 2019-02-01 11:55:18 -08:00
Antoine Pelisse d1a2d7fd8d Plugin FieldManager in CRD handler, change to API 
Kubernetes-commit: b55417f429353e1109df8b3bfa2afc8dbd9f240b
 2019-01-29 14:24:52 -08:00
Antoine Pelisse 337fc9ccde API Machinery, Kubectl and tests 
Kubernetes-commit: 0e1d50e70fdc9ed838d75a7a1abbe5fa607d22a1
 2019-01-16 21:14:42 -08:00