Commit Graph

2640 Commits

Author SHA1 Message Date
Chao Xu 5c9333e4d3 Run deleteValidation at the storage layer so that it will be retried on
conflict.

Adding unit test verify that deleteValidation is retried.

adding e2e test verifying the webhook can intercept configmap and custom
resource deletion, and the existing object is sent via the
admissionreview.OldObject.

update the admission integration test to verify that the existing object
is passed to the deletion admission webhook as oldObject, in case of an
immediate deletion and in case of an update-on-delete.

Kubernetes-commit: 7bb4a3bace048cb9cd93d0221a7bf7c4accbf6be
2019-04-09 13:49:16 -07:00
yue9944882 019679ce23 Cherrypicking #66535
validate deletion admission object

backward compatibility: add validation for direct storage delete calls

apply nil validation to existing tests

revert behavior changes in deleteCollection call

fixes validation on wiring graceful deletion

remove nil validation check

continue admission check on not found error

Kubernetes-commit: 34c4a6e05767e6c6211b88ccc653f2b07021906a
2018-07-24 12:24:59 +08:00
Kubernetes Publisher 591d50ded1 Merge pull request #78029 from liggitt/crd-watch
Terminate custom resource watches when storage is destroyed

Kubernetes-commit: 0f8009b96d7dc3a7a9af25c0ce8d488f7a190b44
2019-05-28 15:57:54 +00:00
Kubernetes Publisher f4b35b9eb2 Merge pull request #77987 from apelisse/dont-fail-on-failures
fieldManager: Ignore conversion errors to internal types

Kubernetes-commit: ddfa49b039af31b461e4ccbf61332bcb43eed027
2019-05-28 15:57:53 +00:00
Kubernetes Publisher 9a6192a9bc Merge pull request #77952 from liggitt/delete-on-update
Handle updates removing remaining finalizers on deleted objects

Kubernetes-commit: 27410955e2db0496af0aaa91ac1cdfc8ca20b1fd
2019-05-28 15:57:52 +00:00
Kubernetes Publisher e01af20ab4 Merge pull request #76442 from viegasdom/fix-golint-utils-bandwith
Fix golint failures of util/bandwith/*.go

Kubernetes-commit: 37281a400d29ec4f515fb8a590d4f012689d89d7
2019-05-28 15:57:50 +00:00
viegasdom 2b465131fe sync: squashed up to merge 69bd30507559be3dea905686b46bc3295c951f45 in 37281a400d29ec4f515fb8a590d4f012689d89d7 2019-05-28 15:57:49 +00:00
Jordan Liggitt fea4dc8e52 Terminate watchers when watch cache is destroyed
Kubernetes-commit: d304c9ecbbd81a32f2c2e059d79e3f79d458a960
2019-05-17 10:02:08 -04:00
Antoine Pelisse 2d27d30e4d fieldManager: Ignore conversion errors to internal types
Errors on updates are bad because they usually come from controllers and
it's very hard to take actions on them. We also don't want to start
breaking kubernetes clusters if something in a schema happens a way we
didn't foresee (even though we've tried to be diligent and test as much
as possible, these can still happen).

Log an identifiable error when they happen. Ideally people can look in
the logs to find these and report them, or providers can look for these
in logs and make sure they don't happen.

Only conversion to internal types are going to be logged and ignored.

It means that we're still failing for:
- Version conversions. If we can't convert the object from one version
  to another,
- Unions. If we can't normalize the union,
- Invalid MangedFields sent in the object. If something has changed the
  ManagedFields to an invalid value.
- Failure to serialize the manager information, this really shouldn't
  happen.
- Encoding the ManagedFields

Kubernetes-commit: 4e32d183d0257c9f6c7f8342d1f9aa7f28458f2f
2019-05-16 11:07:47 -07:00
Jordan Liggitt 3da6a60114 Handle updates removing remaining finalizers on deleted objects
Kubernetes-commit: fba885a0d2cb723a50c95ebc4562696d9f931f04
2019-05-15 15:04:38 -04:00
Kubernetes Publisher fc28ef5782 Merge pull request #77613 from mikedanese/fixinclusterconfig
BoundServiceAccountTokenVolume: fix InClusterConfig

Kubernetes-commit: 5c4b6528c2e9fa989bb6af9dea15d28ca6ac4ef3
2019-05-15 06:41:00 +00:00
Kubernetes Publisher a3c8296cef Merge pull request #70929 from mikedanese/cmp
migrate everything to unify diff.Diff method using cmp

Kubernetes-commit: 1ae09a371faccfc193f9b8d82a9ef77bf3e7fb14
2019-05-15 02:42:03 +00:00
Kubernetes Publisher c754fc9853 Merge pull request #77563 from jpbetz/admission-webhook-options
Pass {Operation}Options to Webhooks

Kubernetes-commit: 0b6ad8bc3f0e85e3a0f1a8a94da3ca4068506de3
2019-05-15 02:42:01 +00:00
Mike Danese da64b0b811 BoundServiceAccountTokenVolume: fix InClusterConfig
Kubernetes-commit: 4198f28855cbda6dac61408fcba6f2d576a9347c
2019-05-14 09:29:16 -07:00
Kubernetes Publisher 23b2cb67e5 Merge pull request #77827 from smarterclayton/fix_partial
PartialObjectMetadataList should nest values, not pointers for Items

Kubernetes-commit: 91ba27e9006b0bdaf1ee51a0b640b68d948c128d
2019-05-14 02:41:57 +00:00
Kubernetes Publisher 29140cf7a1 Merge pull request #77809 from liggitt/beorn7-perks
github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973

Kubernetes-commit: 2fd1e2532ac7beaf94da69abf75dc3d8974513a5
2019-05-14 02:41:56 +00:00
Kubernetes Publisher 0c81f4b99d Merge pull request #77619 from caesarxuchao/always-retry
In GuaranteedUpdate, retry on any error if we are working with cached data

Kubernetes-commit: ed4c50852452a30369bdf7004b1c06043caf8c92
2019-05-13 22:39:39 +00:00
Clayton Coleman 196c34b775 PartialObjectMetadataList should nest values, not pointers for Items
Typo during setting up PartialObjectMetadataList, it should be a slice
of `PartialObjectMetadata`, not a slice of `*PartialObjectMetadata`.

Kubernetes-commit: f25efd12e63f1d7db5f29fe28831ad0126200c0b
2019-05-13 14:13:00 -04:00
Kubernetes Publisher 3f7450c793 Merge pull request #77796 from hormes/fix_data_race_in_ut
fix data race in unittest

Kubernetes-commit: 9b2231a293b57c336455ecf2632603305aae1642
2019-05-13 14:39:41 +00:00
Jordan Liggitt e1b0ad0e17 github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973
bump dependency to version preferred by our version of prometheus

Kubernetes-commit: 867fa61f0cfcbf1875d58d50afc56f71a5031256
2019-05-13 08:41:02 -04:00
fansong.cfs ef7e49ea6d fix data race in unittest
Kubernetes-commit: 3892f6698072827506dfb04acdbf4c6d67a3879d
2019-05-13 15:00:16 +08:00
Kubernetes Publisher ecab80d4d8 Merge pull request #77448 from smarterclayton/api_serve
Support meta.k8s.io/v1 Table and PartialObjectMetadata requests to the API

Kubernetes-commit: 274876ef9af526575f480c977f7dd7c4bb26e760
2019-05-11 06:39:04 +00:00
Kubernetes Publisher d498040504 Merge pull request #77753 from liggitt/prune-replace
Prune matching replace directives in staging repos more effectively

Kubernetes-commit: 6f6890b09e2a8ae7eaaea0a5052d45c3960e1c76
2019-05-11 02:42:06 +00:00
Kubernetes Publisher 296882b377 Merge pull request #77735 from dims/update-beorn7/perks-to-fix-off-by-one-error-for-small-sizes
Update beorn7/perks to Fix off-by-one error for small sample sizes

Kubernetes-commit: e72d73b97d0d43426c939d19fd52733a8adf05cb
2019-05-10 22:39:10 +00:00
Jordan Liggitt 5057d1d1a6 generated files
Kubernetes-commit: eb82dddfdd504c2956ec438b739e01230067e90f
2019-05-10 15:41:34 -04:00
Davanum Srinivas 8888be2eae Update beorn7/perks to Fix off-by-one error for small sample sizes
Change-Id: I444b345743251a13252321df0f385503a4271234

Kubernetes-commit: 56abfb5b012eb6f978086b7da8ca136bc437f8ee
2019-05-10 08:15:22 -04:00
Kubernetes Publisher 32059931b4 Merge pull request #77379 from tedyu/http-stat-map
Use map to check whether stack trace is needed

Kubernetes-commit: b7dc0124a0d89a808cd67e863a4018ca3b071efa
2019-05-09 22:39:33 +00:00
Kubernetes Publisher 3b29680983 Merge pull request #77580 from liggitt/fix-list-interface
Fix unstructured list interface compatibility, fix kubectl paging

Kubernetes-commit: 548bf0afe524155c5e1f27b9476032eed905d6b7
2019-05-09 06:39:09 +00:00
Kubernetes Publisher 4756b09d7a Merge pull request #77037 from logicalhan/counter-wrapper
Add wrappers for prometheus.Counter/CounterVec and prometheus.Registry

Kubernetes-commit: 19431e0168d9ac88db68e078f05a18624fe784ef
2019-05-08 22:39:31 +00:00
Kubernetes Publisher d20bfeed48 Merge pull request #74021 from andrewsykim/move-features-component-base
Move feature gate package from k8s.io/apiserver to k8s.io/component-base

Kubernetes-commit: 09c4e103331314cf53c20d429ba04b95a6193534
2019-05-08 22:39:30 +00:00
Chao Xu d7f4ff742a In GuaranteedUpdate, retry on any error if we are working with stale data
Kubernetes-commit: 5e53522a9ef56f33d06c457c072c379131e127ef
2019-05-08 15:05:07 -07:00
Ted Yu 4af313ef61 Use map to check whether stack trace is needed
Signed-off-by: Ted Yu <yute@vmware.com>

Kubernetes-commit: 85fc0898556d5c0c4b80920bac62842bfc97d763
2019-05-08 14:31:47 -07:00
Daniel (Shijun) Qian 3a0abf14e5 fix duplicated imports of k8s code (#77484)
* fix duplicated imports of api/core/v1

* fix duplicated imports of client-go/kubernetes

* fix duplicated imports of rest code

* change import name to more reasonable

Kubernetes-commit: 5268f69405251a4a74130fa903e055a59071179a
2019-05-08 18:39:56 +00:00
Jordan Liggitt 949522070d Fix unstructured list interface compatibility, fix kubectl paging
Kubernetes-commit: e5778f05b973aa70a129ef77235da3cf1b1139e3
2019-05-08 01:48:26 -04:00
Kubernetes Publisher fd6533a7ae Merge pull request #77522 from jennybuckley/remove-version
Handle conversion errors from ObjectToTyped correctly

Kubernetes-commit: 8765fa2e48974e005ad16e65cb5c3acf5acff17b
2019-05-08 02:39:46 +00:00
Joe Betz f384b59525 Update tests for: Pass {Operation}Option to Webhooks
Kubernetes-commit: 900d652a9ac11e53293950b3d191295c21430215
2019-05-07 13:37:07 -07:00
Joe Betz 19327df6d5 Pass {Operation}Option to Webhooks
Kubernetes-commit: 140c8c73a64deb102b528109138ca9fb7dbb2392
2019-05-07 13:34:18 -07:00
Han Kang f65bb18f55 update dependencies (bring in prometheus and semver)
Kubernetes-commit: 91d3a79aaf787361210bd5eb4142a47e3e5dfb84
2019-05-07 10:38:53 -07:00
Kubernetes Publisher 292cbc37da Merge pull request #75993 from caesarxuchao/add-count
Adding RemainingItemCount to ListMeta

Kubernetes-commit: 1fb8ed12a2d1d50a890f24c67c5fc0d37d4ffb04
2019-05-07 06:39:09 +00:00
Kubernetes Publisher d16c4716d3 Merge pull request #76966 from figo/master
Split TestLoopbackHostPort into 2 tests

Kubernetes-commit: 1b4b1d1c73493f2847d8d33274c79c10ed17eb80
2019-05-06 21:32:05 -07:00
jennybuckley e999a5ebe2 Treat NoCorrespondingTypeError as MissingVersionError
Kubernetes-commit: 13cb241b1833495c8f195dac96dacf54c0ba4a3a
2019-05-06 15:13:36 -07:00
Clayton Coleman 1394d8d85c API server should offer metav1 Table/Partial transforms
Now that internal types are equivalent, allow the apiserver to serve
metav1 and metav1beta1 depending on the client. Test that in the
apiserver integration test and ensure we get the appropriate responses.

Register the metav1 type in the appropriate external locations.

Kubernetes-commit: 33a3e325f754d179b25558dee116fca1c67d353a
2019-05-04 16:55:49 -04:00
hui luo 2c9b5e28c4 Split TestLoopbackHostPort into 2 tests
firstly, split into two tests: TestLoopbackHostPortIPv4 and  TestLoopbackHostPortIPv6.
then improve error handling, going to fail with explicit error message when run host
that does not support ipv6 or ipv4

Kubernetes-commit: 6b73b5031c463437064b1593d00a60107d09dd99
2019-04-23 14:52:39 -07:00
Kubernetes Publisher 31dae0fcea Merge pull request #77510 from wojtek-t/revert_beorn7
Revert "github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973"

Kubernetes-commit: 203d5f07c8cc661f4be020b8f1bf2ede9ecfa279
2019-05-07 02:39:26 +00:00
wojtekt 0270bf6df8 Revert "github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973"
This reverts commit a2ec981f67360f5dace19bd3afa3b120da170484.

Kubernetes-commit: 21e51ddf368416c182734ffd01fb07243c4f8436
2019-05-06 15:56:15 +02:00
Kubernetes Publisher 7dc4ceb2fd Merge pull request #77022 from liggitt/webhook-error-success
Ensure 4xx+ response codes from webhook rejections

Kubernetes-commit: aefa6d4492dd014c27cfc6f08ee5fe94384f87a3
2019-05-04 02:39:14 +00:00
Kubernetes Publisher d03d7cbc3e Merge pull request #76917 from dims/try-json-iterator-go-instead-of-ugorji-coded
Use latest etcd from release-3.3 branch for dropping ugorji

Kubernetes-commit: aff37ada4673a84df0c18f8a74cc8ac2234372a9
2019-05-03 11:13:08 +00:00
Kubernetes Publisher 0804cc0e5e Merge pull request #77278 from liggitt/enable-etcd-paging
Enable API resource paging by default, by feature gate in sample-apiserver

Kubernetes-commit: 005eb53ea1d9a0fac4f008f79a9ee559436def53
2019-05-03 07:12:36 +00:00
Kubernetes Publisher 8584d010d1 Merge pull request #77281 from liggitt/remove-quorum-field
Remove unused quorum field

Kubernetes-commit: c821eb36b75a3756f870ffdf3e111b6e7dbdba7d
2019-05-03 03:12:44 +00:00
Jordan Liggitt c20c25cef4 Remove unused quorum field
Kubernetes-commit: 35757a4b96b49fc21bb9bc8b47c5a86f005b166a
2019-04-30 17:39:31 -04:00