Mike Spreitzer
959fbf9f84
Use timing ratio histograms instead of sample-and-watermark histograms
...
Kubernetes-commit: 0c0b7ca49f9ade72b990bf3a6f568485586af8b4
2022-05-18 02:56:48 -04:00
Mike Spreitzer
32237d0a84
Add timing ratio histograms
...
Following is the result of benchmarking the two kinds of histograms on
my laptop.
% go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/apiserver/pkg/util/flowcontrol/metrics
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkSampleAndWaterMarkHistogramsVecEltSafeEarly-16 980143 1230 ns/op 0 B/op 0 allocs/op
BenchmarkSampleAndWaterMarkHistogramsVecEltSafeLate-16 932380 1216 ns/op 0 B/op 0 allocs/op
BenchmarkTimingRatioHistogram-16 12665247 94.13 ns/op 0 B/op 0 allocs/op
BenchmarkTimingRatioHistogramVecElementSimple-16 11015806 100.4 ns/op 0 B/op 0 allocs/op
BenchmarkTimingRatioHistogramVecElementSafeEarly-16 7142589 172.0 ns/op 0 B/op 0 allocs/op
BenchmarkTimingRatioHistogramVecElementSafeLate-16 11487517 96.67 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/apiserver/pkg/util/flowcontrol/metrics 7.718s
Kubernetes-commit: 8039f9d600c08450a81b60494b392a6aada0c14b
2022-05-18 02:30:06 -04:00
Mike Spreitzer
8628966894
Fix more initial numerators
...
Kubernetes-commit: ba690c2257af76bd971d0dfb6bef13ff9099e549
2022-05-18 00:22:30 -04:00
Mike Spreitzer
cae328fb1c
Give apf metrics abstractions more familiar names
...
The logic is similar to Prometheus gauges and vectors,
adopt that terminology.
Kubernetes-commit: 7d64a93a1407f91b5e13bf540a0fa834a41622eb
2022-05-17 23:27:47 -04:00
Mikhail Mazurskiy
17134151a6
Always dial using a context
...
Kubernetes-commit: 2d62c57533f96985b7847dd63f91471167bd6006
2022-05-18 10:39:35 +10:00
Kubernetes Publisher
45a9315997
Merge pull request #110094 from tkashem/refactor-graceful
...
apiserver: refactor - move AuditBackend.Run out of NonBlockingRun
Kubernetes-commit: f727b5af34dac134aaa5bb5a8f02f78ed6e5291c
2022-05-18 00:21:45 +00:00
Kubernetes Publisher
4f090bcb98
Merge pull request #110061 from wojtek-t/shutdown_apiextensions
...
Cleanup CRD storage on shutdown
Kubernetes-commit: 4bd396115def9afd7eac7f9071ed699d61c55b27
2022-05-18 00:21:43 +00:00
Kubernetes Publisher
0cb3518ed9
Merge pull request #110081 from wojtek-t/document_shutdown_sequence
...
Diagram for graceful shutdown
Kubernetes-commit: c79b909de715a25e247efc48743ce2001ca8779b
2022-05-17 16:15:14 +00:00
Abu Kashem
2000c163ec
apiserver: add lifecycle signal for preshutdown hook
...
Kubernetes-commit: b1f7b60515798934b011d27bfeba1cee4fcd26b7
2022-05-17 12:00:04 -04:00
Abu Kashem
771df84108
apiserver: refactor - move AuditBackend.Run out of NonBlockingRun
...
Kubernetes-commit: 6b8398318c005753383700f27bd398f4724b37a9
2022-05-17 11:14:11 -04:00
Kubernetes Publisher
9b5acf1cdd
Merge pull request #110024 from stevekuznetsov/skuznets/split-list-test
...
storage: split paginated and non-paginated list tests, make them generic
Kubernetes-commit: ed522c7460805b2a942f3dfe9603ee2fc0827e35
2022-05-17 12:15:09 +00:00
Kubernetes Publisher
4cc65c15fa
Merge pull request #110062 from wojtek-t/fix_storage_object_count_tracker_registration
...
Avoid leaking StorageObjectCountTracker goroutine
Kubernetes-commit: 45844049fcdfe1bdaa11ccee685d45eb1c1588a2
2022-05-16 16:14:23 +00:00
Wojciech Tyczyński
751a040f24
Cleanup CRD storage on shutdown
...
Kubernetes-commit: 01cf641ffbb3c876c4fc6c3e53a0613356f883e5
2022-05-15 22:25:43 +02:00
Guillaume Le Biller
e6f50ae491
Update managedFields time when value is modified
...
Kubernetes-commit: f681821fcf028e0e8082be6a9daf0a8ff9392a66
2022-05-15 17:30:36 +02:00
Wojciech Tyczyński
f5d65d90e9
Avoid leaking StorageObjectCountTracker goroutine
...
Kubernetes-commit: 564b376812836fb1e77452d478ab16eee5101447
2022-05-15 09:57:26 +02:00
Kubernetes Publisher
7816c29325
Merge pull request #110025 from stevekuznetsov/skuznets/skuznets-reviews-storage
...
apiserver/storage: add myself to the reviewers list
Kubernetes-commit: 30adcd0b6c1c28303d7281b7be2ac45bdd7989e4
2022-05-13 08:52:01 -07:00
cyclinder
ff9ea26823
ix CVE-2022-27191: Bump golang.org/x/crypto to v0.0.0-20220315160706
...
Signed-off-by: cyclinder qifeng.guo@daocloud.io
Kubernetes-commit: 46bbe52c7a00c27ac530788797b40c685510706e
2022-05-13 10:00:40 +08:00
Abu Kashem
658eeac034
fix preshutdown hook behavor with graceful termination
...
Kubernetes-commit: 9644edc321e3b7e5180eb7c15a27bf28e19485db
2022-05-12 19:58:33 -04:00
Steve Kuznetsov
b2d4efbca3
apiserver/storage: add myself to the reviewers list
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 0d616946c036d5ead9dd03e312c6ac16f9a91c3e
2022-05-12 15:40:33 -07:00
Kubernetes Publisher
7d65d3df16
Merge pull request #110013 from enj/enj/i/remove_azure_gcp_auth_plugins
...
Remove gcp and azure auth plugins
Kubernetes-commit: 2d08104ee3beb5c13db088d40cc22ec053512cea
2022-05-12 23:46:49 +00:00
Kubernetes Publisher
c9f7ab355b
Merge pull request #109971 from stevekuznetsov/skuznets/isolate-continue
...
storage: move continue token definition to storage
Kubernetes-commit: 46469f62db711365c023b5e9f208f7467d302290
2022-05-12 23:46:46 +00:00
Kubernetes Publisher
ba1294fefd
Merge pull request #110009 from azylinski/fix-create-cr-scope
...
Fix requests scope classification
Kubernetes-commit: 0e567664ed3f9eb6c1f41e87f35886188fe5bd96
2022-05-12 23:46:44 +00:00
Kubernetes Publisher
1704b8df52
Merge pull request #109970 from stevekuznetsov/skuznets/isolate-versioner
...
storage: move the APIObjectVersioner definition to storage
Kubernetes-commit: 1be1ec4aa3e0270d591b33024532c8fd3ba8ab08
2022-05-12 23:46:42 +00:00
Steve Kuznetsov
03363cd42b
storage: move some list tests to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 162450c01c9004ded53bb77f651f9a3f30920b30
2022-05-12 15:16:07 -07:00
Steve Kuznetsov
289ed89252
storage/etcd3: make some list tests generic
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: a8067f8e865475cbdb11d812c915927714690676
2022-05-12 15:13:23 -07:00
Steve Kuznetsov
6bff431f4a
storage: move test utiltiies out of test files
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: e50cb6c8d36ca73c99c935126978cbec01f9be01
2022-05-12 11:52:28 -07:00
Kubernetes Publisher
947a097a5c
Merge pull request #109978 from wojtek-t/remove_storage_tracking
...
Cleanup no-longer used storage cleanup method
Kubernetes-commit: 976a940f4a4e84fe814583848f97b9aafcdb083f
2022-05-12 15:41:54 +00:00
Wojciech Tyczyński
30c4077e0e
Diagram for graceful shutdown
...
Kubernetes-commit: 1145582de367b9aa4072e631845ce3abc37b8540
2022-05-12 17:22:36 +02:00
Monis Khan
279d578ea9
Remove gcp and azure auth plugins
...
Signed-off-by: Monis Khan <mok@vmware.com>
Kubernetes-commit: 916cf16cf14928702f3f90b655ddddab2c85fcec
2022-05-12 09:48:04 -04:00
Artur Żyliński
62aa70cd37
Fix requests scope classification
...
create (POST) custom resources should be scope:resource
Kubernetes-commit: 690c912369a6ca7f35363a307a843e91cadd7f6e
2022-05-12 14:27:51 +02:00
Kubernetes Publisher
cc42d28f06
Merge pull request #108797 from deads2k/release-1.25-removed-01-checker
...
update for APIs removed in 1.25
Kubernetes-commit: cae22d8b8a78985f438c232357aa2b6c60d83f9b
2022-05-12 05:03:21 +00:00
Kubernetes Publisher
39b5496414
Merge pull request #109969 from sttts/sttts-auth-group-adder-race
...
authn: fix cache mutation by AuthenticatedGroupAdder
Kubernetes-commit: 2d6534cde925ea16f28755a758c96d621b5fa7d6
2022-05-12 05:03:19 +00:00
Kubernetes Publisher
a0fc11eb6a
Merge pull request #109930 from wojtek-t/cleanup_etcd_healthcheck
...
Cleanup etcd healthcheck on shutdown
Kubernetes-commit: 784cf764690917e6fb229532722ea0d857cfcde4
2022-05-11 21:03:37 +00:00
Kubernetes Publisher
5f27f61940
Merge pull request #108414 from aojea/cacher_context
...
cacher: don't accept requests if stopped
Kubernetes-commit: 999b1bbe92947fca9e1fab67349ad11d3c46d328
2022-05-11 21:03:35 +00:00
Wojciech Tyczyński
d0a6d0fb72
Cleanup no-longer used storage cleanup method
...
Kubernetes-commit: 2dd44d6226efc6b72ae56b5fb81b5b2921cf3e16
2022-05-11 19:02:51 +02:00
Steve Kuznetsov
0a2d58a552
storage: isolate the test resource
...
This test resource only exists to test the versioning logic, but it
cannot live in the general testing package, or import cycles will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: fa2a6d633984aaa36ef988ecf4410c20e27897ea
2022-05-11 09:05:18 -07:00
Steve Kuznetsov
67344c728d
storage: move continue token definition to storage
...
The means by which we encode and decode the continue token during a
paginated LIST call is not specific to etcd3. In order to allow for a
generic suite of tests against any storage.Interface implementation, we
need this logic to live outside of the etcd3 package, or import cycles
will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: eb3aa5be10393968d8083c79f5958501fc029e8d
2022-05-11 07:52:02 -07:00
Steve Kuznetsov
80256820ce
storage: move the APIObjectVersioner definition to storage
...
The means by which we extract and parse the version of an API object is
not specific to etcd3. In order to allow for a generic suite of tests
against any storage.Interface imlpementation, we need this logic to live
outside of the etcd3 package, or import cycles will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 3939f3003e9605c06f65e64d1fc6f94b294f9d97
2022-05-11 07:44:21 -07:00
Steve Kuznetsov
ae4cc8bfc8
storage/etcd3: factor out non-paginated list tests
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 8fcf00ef9171cfb623525d2a6aea1d721c3b5e74
2022-05-11 07:18:05 -07:00
Dr. Stefan Schimanski
3677d6afcf
authn: fix cache mutation by AuthenticatedGroupAdder
...
The cached token authenticator returns a cache value. The group adder changes it.
Kubernetes-commit: e09e81e4f6e62f9fef89736e79d04983a77e695f
2022-05-11 16:17:29 +02:00
Steve Kuznetsov
139068ca91
storage/etcd3: factor store setup into a separate function
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 31d7a28c65c34f2e2a28cfc41c2c517d370e7045
2022-05-11 07:17:26 -07:00
Kubernetes Publisher
fe6b82fbd5
Merge pull request #109914 from stevekuznetsov/skuznets/generic-watch-cancel-test
...
storage/testing: move cancelled watch test to generic package
Kubernetes-commit: ccb7118c22fcb3c8804a4239fb80dd5f3c4e00f3
2022-05-10 14:38:16 +00:00
Davanum Srinivas
8a97d520ab
Move from k8s.gcr.io to registry.k8s.io
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Kubernetes-commit: 50bea1dad89930ad565526910aadc314b9e9f38b
2022-05-10 08:30:09 -04:00
Kubernetes Publisher
f93af7cfa7
Merge pull request #109909 from stevekuznetsov/skuznets/generic-create-test
...
storage/testing: move creation test to generic package
Kubernetes-commit: 0ee790652492cd9283de6907f2eee349b8686c7c
2022-05-10 04:05:43 -07:00
Wojciech Tyczyński
0a7c4bcca1
Cleanup etcd healthcheck on shutdown
...
Kubernetes-commit: cb80082f666e0e5fe220df32e31a8face18e9393
2022-05-10 11:12:08 +02:00
Sugang Li
da8e7d1134
update kube-controller-manager dependencies
...
Kubernetes-commit: c64846da0025d49e72ef431c713fc8c2461caa73
2022-05-09 16:53:00 +00:00
Steve Kuznetsov
a4bcbc5187
storage/testing: move cancelled watch test to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 1f24bd91c30a3f0b623c452cffa9f043f202d98b
2022-05-09 08:23:58 -07:00
Steve Kuznetsov
fe17bc776e
etcd3/store: call a generic cancelled watch test
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: c0fc8172559f7796560a9b80fd23df92095adb14
2022-05-09 08:23:03 -07:00
Steve Kuznetsov
7b82bba67e
etcd3/store: update cancelled watch test to be generic
...
There's no reason to create the watch using the underlying watcher.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 774870611c1d2b405d67eb73ade628ced5e0e994
2022-05-09 08:22:04 -07:00
Steve Kuznetsov
3fd88b5da7
storage/testing: move creation test to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Kubernetes-commit: 2e118f42465efb390bec005f1853a964dd339f97
2022-05-09 08:04:53 -07:00