ce7f425acc
fix S1002 omit comp to bool
...
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Kubernetes-commit: e8878687b18fd961e9f3e29c1c46fe018157a77d
2020-06-26 10:36:38 -05:00
c4c20f4f7d
Update SMD to v4.0.1 and kube-openapi
...
Kubernetes-commit: f4c145511a0bb62ea7ee1f2154945c84c17ffcd5
2020-08-10 13:02:25 -07:00
5c23eb937e
test(endpoints): deflake TestWatchHTTPTimeout
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
Kubernetes-commit: 50e8287e6df67428ab5871af530fb10f6eee19de
2020-08-12 01:58:07 +08:00
97937c66f2
Revert nested trace PR#88936
...
Kubernetes-commit: 02cf58102a61b6d1e021e256381ff750573ce55d
2020-07-20 09:55:05 -07:00
e28ab56bd4
Introduce more metrics on concurrency
...
Introduce min, average, and standard deviation for the number of
executing mutating and readOnly requests.
Introduce min, max, average, and standard deviation for the number
waiting and number waiting per priority level.
Later:
Revised to use a series of windows
Use three individuals instead of array of powers
Later:
Add coarse queue count metrics, removed windowed avg and stddev
Add metrics for number of queued mutating and readOnly requests,
to complement metrics for number executing.
Later:
Removed windowed average and standard deviation because consumers can
derive such from integrals of consumer's chosen window.
Also replaced "requestKind" Prometheus label with "request_kind".
Later:
Revised to focus on sampling
Make the clock intrinsic to a TimedObserver
... so that the clock can be read while holding the observer's lock;
otherwise, forward progress is not guaranteed (and violations were
observed in testing).
Bug fixes and histogram buckets revision
SetX1 to 1 when queue length limit is zero, beause dividing by zero is nasty.
Remove obsolete argument in gen_test.go.
Add a bucket boundary at 0 for sample-and-water-mark histograms, to
distinguish zeroes from non-zeros.
This includes adding Integrator test.
Simplified test code.
More pervasively used "ctlr" instead of "ctl" as abbreviation for
"controller".
Kubernetes-commit: 57ecea22296797a93b0157169db0ff2e477f58d0
2020-05-17 01:02:25 -04:00
fac7ebd95f
Implement server-side apply upgrade & downgrade.
...
- Allow client-side to server-side apply upgrade.
Ensure that a user can change management of an object from client-side apply to
server-side apply without conflicts.
- Allow server-side apply to client-side downgrade.
For an object managed with client-side apply, a user may upgrade to
managing the object with server-side apply, then decide to downgrade.
We can support this downgrade by keeping the last-applied-configuration
annotation for client-side apply updated with server-side apply.
Kubernetes-commit: e4368eb67e363d3d03f81214a8929268d2fe88ff
2019-10-02 11:13:40 -04:00
7a467399ac
Enable nested tracing, add request filter chain tracing incl. authn/authz tracing
...
Kubernetes-commit: b12ac0abc64adb71d97fbde12f373b1424631f20
2020-03-06 16:11:21 -08:00
50fc715287
Add audit annotation for requests to deprecated API endpoints
...
Kubernetes-commit: 9550f5080fde480c0712a0870c56b4e2415f8637
2020-07-06 15:03:24 -04:00
7f8013437d
log tls handshake error at trace level to avoid error flooding, and add
...
metric to count such errors
Kubernetes-commit: eabb362aa37f7acc85bc64f2035dadc5511d3716
2020-05-20 11:29:44 +08:00
5bb316ec73
Bump to sigs.k8s.io/structured-merge-diff 43c19b to pick up unsetting fields changes PR#166
...
Kubernetes-commit: 11c38a9c703b825c61d6490e8da85202b760f3b1
2020-06-26 20:05:34 -07:00
ff5372c83d
Add warnings capability for admission webhooks
...
Kubernetes-commit: 5eef60a00aeb18eda4238dbd8f6dc96930a6a05a
2020-06-30 16:27:56 -04:00
ee219411ed
Add ResourceVersionMatch parameter to make Resource Version semantics consistent for list
...
Kubernetes-commit: e214f2408b59c745c199645547948a8ad2a87ac2
2020-05-29 10:44:26 -07:00
e0d29c69be
Migrate API server logs to Structured logging framewrok
...
Kubernetes-commit: af60e7b34d59d635740880a03e7e2587ec9ba041
2020-06-17 21:06:35 +00:00
c02923d8c7
apiserver: increment metric for deprecated API use
...
Kubernetes-commit: e4bb1daecf36aac3051d36a20dfdf7ea3050de58
2020-04-30 12:21:29 -04:00
7add3b408a
apiserver: add warnings for deprecated APIs
...
Kubernetes-commit: e06b0635de5983aa115e2073c7335ad2bc8985cb
2020-04-14 16:11:21 -04:00
d7d5d84691
apiserver: add API server plumbing for adding warnings
...
Kubernetes-commit: e5e557e90257d5bc69f1fabf253f87491e0868b2
2020-04-14 16:10:54 -04:00
025116d4fa
Fix fieldType being dropped by older go-clients
...
Kubernetes-commit: 3f10709e4ce7e14fa9efc019ade3e99bb0a84b8a
2020-04-30 13:38:23 -07:00
3b7411b225
FieldManager: Reset if we receive nil or a list with one empty item
...
Kubernetes-commit: ed2cf6ef2cc4f4d358eee038d2d87387614bbf45
2020-05-21 13:23:30 -07:00
6b9950ac7e
fix kube-apiserver panic when CRD Kind contains only one letter
...
Signed-off-by: SataQiu <1527062125@qq.com>
Kubernetes-commit: 2c8c9d02098a975ee3f42c6a6d29579da8502b6d
2020-06-06 23:01:35 +08:00
cc0f41ad59
fieldManager: Ignore and log all errors when updating managedFields
...
Kubernetes-commit: 5378a788e471a18594c446888306d826d3b44661
2020-05-08 12:48:09 -07:00
a67f43f565
Remove `EvenPodsSpread` featuregate and related logic
...
Kubernetes-commit: 133dde63589bfb9f149607d1e8f6ae519d41719f
2020-05-27 14:24:26 -07:00
64913bcbc2
fix a number of unbounded dimensions in request metrics ( #89451 )
...
* fix a number of unbounded dimensions in request metrics
* add test suite for cleanVerb and cleanContentType
* Properly validate that the content-type and charset (if applicable) are RFC compliant
* add additional test case
* truncate list of content-types
Change-Id: Ia5fe0d2e2c602e4def4b8e0849cc19f3f9251818
Kubernetes-commit: 6c588c3f441252f42fd37526297ed92d1e1f3acf
2020-05-29 08:29:03 +00:00
d8082ddfe6
s/RelicaSets/ReplicaSets
...
Kubernetes-commit: 9760dec9dc84d68c6613887128de192b4a66feff
2020-04-29 12:59:05 -07:00
5879417a28
switch over k/k to use klog v2
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Kubernetes-commit: 442a69c3bdf6fe8e525b05887e57d89db1e2f3a5
2020-04-17 15:25:06 -04:00
099ec78c1b
exclude openapi params for DELETECOLLECTION
...
Kubernetes-commit: 6a7aa377f2894fe392906982afade19501783aa6
2020-05-14 11:14:23 +08:00
1873d19869
Allow handlers early in the request chain to set audit annotations
...
This change adds the generic ability for request handlers that run
before WithAudit to set annotations in the audit.Event.Annotations
map.
Note that this change does not use this capability yet. Determining
which handlers should set audit annotations and what keys and values
should be used requires further discussion (this data will become
part of our public API).
Signed-off-by: Monis Khan <mok@vmware.com>
Kubernetes-commit: 0bc62112adf270ef4efada37286319c229324c7b
2020-03-19 20:02:37 -04:00
59604ff55c
Not rely on default conversions in apiserver test
...
Kubernetes-commit: 8c59c2133cabe70039f67986383a3598c174e546
2020-02-11 14:53:17 +01:00
7fa523535d
Remove support for basic authentication
...
This change removes support for basic authn in v1.19 via the
--basic-auth-file flag. This functionality was deprecated in v1.16
in response to ATR-K8S-002: Non-constant time password comparison.
Similar functionality is available via the --token-auth-file flag
for development purposes.
Signed-off-by: Monis Khan <mok@vmware.com>
Kubernetes-commit: df292749c9d063b06861d0f4f1741c37b815a2fa
2020-03-11 14:31:31 -04:00
532d284317
Require listers to implement TableConverter
...
Kubernetes-commit: 7cbb74d089f88c3323b7be2dcd8a8d39d8aad271
2020-03-09 10:08:13 -04:00
05f95a480d
managedfields: Update Apply time if neither object nor managedfields have changed
...
Kubernetes-commit: 5231c6815c7b06248575892f3ec96c15c634d368
2020-03-05 13:13:27 -08:00
c81c86d33f
Bump sigs.k8s.io/structured-merge-diff to v3
...
Kubernetes-commit: df41fd932bef1686b30a1abee477c5009ebabe80
2020-03-05 13:09:50 -08:00
2ff45c3592
fieldmanager: Add failing test for no-op apply actually writing to etcd
...
Kubernetes-commit: 7120abe6989afff0d4ad879a4590a960f4ab19f0
2020-03-05 10:09:08 -08:00
5de3b6339e
fieldmanager: Move ManagedFields update logic into its own class
...
Kubernetes-commit: 39681aa5800492b8e4b4ff5fb82e034376864a37
2020-03-05 10:01:37 -08:00
2e70c9ff51
client-go dynamic client: add context to callers
...
Kubernetes-commit: b7c2faf26c2a25427794478c6265e6d55e8acb5a
2020-03-06 10:17:41 -05:00
82ecbdb375
Don't log "SHOULD NOT HAPPEN" errors more than once per second
...
Kubernetes-commit: 389dd0a499e4fa79d3d2ef4261aa9f25aa94e6b0
2020-02-26 15:58:57 -08:00
e6ae7336e6
Factor-out metrics related logic from authentication logic.
...
Kubernetes-commit: c0bad80e5b4bf56757e1a4999e831a5341693203
2020-01-28 15:53:25 -08:00
a87d964ed1
Don't save managedFields if object is too large
...
Kubernetes-commit: ccd9e4e2de32b8708f3a7be159f7a4316449c433
2020-01-22 15:38:27 -08:00
07f3bde07d
Enable field management for all new objects
...
Kubernetes-commit: a54a52c5de3458bfa5dbe1973d12584f59a5581c
2020-02-10 09:06:18 -08:00
809bbdf7f8
Replace Beta OS/arch labels with the GA ones
...
Beta OS/arch labels have been deprecated since 1.14.
This change replaces these labels with the GA ones.
Kubernetes-commit: bcd975aa6575ae37ec3be3481e44cd0dccd02337
2020-02-12 11:30:39 -08:00
4e7f113e29
Round times to nearest second before sorting
...
Kubernetes-commit: 888a322d9ca3070b811b348e05ee4a3ce7da6ae9
2020-02-11 11:54:21 -08:00
51a2cc34eb
Lower server-side apply percentage to 10%
...
Kubernetes-commit: a657d51ce35eb3886a56ed710805cd68732461ee
2020-02-11 09:15:12 -05:00
3104ef647b
Enable field management for all new objects
...
Kubernetes-commit: 8438bba5fd911c4674e46519228e6c47b5057346
2020-02-10 09:06:18 -08:00
dced5f29d8
Bump to latest SMD to pick up performance optimizations
...
Kubernetes-commit: d9faaca64738a50455f38dd88845e8b4b5ca37e2
2020-02-06 15:10:25 -08:00
977fdf9f57
Add UpdateTwice and UpdateApply benchmarks for fieldmanager
...
I've also moved the deserialization of the object outside the benchmark
since we're not trying to benchmark the yaml parser.
Kubernetes-commit: a52776fbfb305374d87bb553739f712e055b2206
2020-02-06 09:25:52 -08:00
4a26259a7c
Register full object as return type for `DELETE` web services.
...
Related to https://github.com/kubernetes/kubernetes/issues/59501
Maybe related to https://github.com/kubernetes/enhancements/pull/1263
Kubernetes-commit: 4d33d837c8be778044d50755de83f8738e957c13
2020-01-24 21:50:29 +07:00
216aab95f9
Move mutating admission into finishRequest
...
Kubernetes-commit: 9bd42287f90feeb0cf1076fcfb180ff6e1d02110
2020-01-29 13:21:58 -08:00
fe6033d4a2
remove client label from apiserver request count metric since it is unbounded
...
Change-Id: I3a9eacebc9d9dc9ed6347260d9378cdcb5743431
Kubernetes-commit: cc3190968b1f14ddf4067abef849fc41bd6068dc
2020-01-29 12:25:55 -08:00
0fe6670327
Make schema error log message more useful
...
Kubernetes-commit: fee77388c6d4cc04731f35055d9dfcdf08b0f874
2020-01-29 15:01:44 -08:00
605316fae2
Re-enable apply for 50% of requests
...
Kubernetes-commit: 9b679748239faa4d01f13c32af1956ffdbfff9aa
2020-01-23 11:27:20 -08:00
49d583f0ef
Update Structured Merge Diff to V3
...
Kubernetes-commit: b33fbc84d9d6e7033c36fa3bc321b8fea28ceed6
2020-01-21 15:03:56 -08:00
223f76bd7a
Set managedField probability to 0%
...
Lowers probability of managedField population on create/update to 0%
until serialization/normalization issues are resolved
Kubernetes-commit: ba23aa98f6574bd1f9781f0d3e61d0496f16fc53
2020-01-14 14:47:35 -05:00
99a93eeef1
clean deprecated apiserver request metrics
...
Kubernetes-commit: 0e8b956e27b07092ca4873c09314e4cff930ab27
2020-01-10 17:09:26 +08:00
ade6c3cc65
keep apiserver_request_latencies_summary
...
Kubernetes-commit: 2c2e1c5443a637353a3ab36cb8e51a9a60691042
2019-05-28 17:31:08 +08:00
669e87efbe
clean SinceInMicroseconds, convert to SinceInSeconds
...
Kubernetes-commit: ab182552b485ceed96c3b05d284ae9480377daf8
2019-04-15 16:18:01 +08:00
b31ce5f20e
remove deprecated metrics of apiserver
...
Kubernetes-commit: 060756babbb6991cf9426c38be595d23e7124b4e
2019-04-12 16:15:13 +08:00
2ac09e3ec3
Update fieldmanager.go
...
Kubernetes-commit: 4db3822ebbac30248463eb529d88176f8b258fd9
2020-01-10 11:15:06 -08:00
d516617523
create probabilistic SkipNonAppliedManager
...
Kubernetes-commit: 6cab3a7bec75e42581e8041395c3ceaa14e07c74
2020-01-09 14:15:34 -08:00
4694e4eb62
fix nits
...
Kubernetes-commit: a2526286498762de187db23f13da5d747ddd1c90
2020-01-10 00:58:52 +01:00
41bde5b991
change Apply signature and move decoding into handlers
...
Kubernetes-commit: ddf0d4b8034697a8dca23a3c8bc5620629bd691b
2020-01-09 22:34:33 +01:00
a521baa66a
Minor nit in error message about feature gate stage
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Kubernetes-commit: 1eaa0ee3f9553cce1821434ce64e745ba5b135d2
2020-01-01 15:54:06 +02:00
76c4ab8bb5
unify alias of api errors under pkg and staging
...
Kubernetes-commit: 5bc0e26c1902e7e28abfc828de19a2dbb3e492c2
2019-11-12 16:26:59 +08:00
38b2d97314
Fix golint failure not contained in .golint_failures
...
Kubernetes-commit: 8110e08dd4abd4458b2d3793f5c1eb50069ae7df
2019-12-19 14:40:26 +09:00
e00fbd05dd
Use openapi fixture for server-side apply tests
...
Kubernetes-commit: 2b4fac5760ff390d46c2b9bb373feafe9bd97a38
2019-12-04 10:29:48 -05:00
d1465bc6c3
fix potential memory leak issue in processing watch request
...
Kubernetes-commit: b911aa6471a83b1d2b4ea346e5c6b442dfa9b53b
2019-11-18 16:43:15 +08:00
3aa0552959
Switch TableGenerator/TableConvertor interfaces to metav1
...
Kubernetes-commit: 36eb250cbb441984260ded6f7abeb796974031c3
2019-11-26 13:13:25 -05:00
455e205726
use context to check client closed instead of http.CloseNotifier in processing watch request
...
Kubernetes-commit: 1daa08c5c8634af762b0352ff4a49bdef6924c5f
2019-11-18 21:27:05 +08:00
de8c866328
Hide apiserver metrics that have been deprecated in 1.14
...
Update E2E test accordingly.
Kubernetes-commit: 5e0695e339ff0887ebebddfa8630de191f7fa235
2019-10-12 20:25:10 +08:00
bab2370cac
Update structured-merge-diff to latest version
...
Kubernetes-commit: 4f0346530d3e228db20aca6bb484d3ed3c83e33b
2019-11-06 09:53:38 -08:00
ca6e794c60
Eliminate couple unnecessary conversions
...
Kubernetes-commit: 067d173266303c5c9a4281e962d3662c34a78053
2019-11-12 14:19:14 +01:00
26a8fb1b92
test: Watch should fail immediately on negotiate errors
...
Instead of returning an error on the watch stream, if we can't properly
negotiate a watch serialization format we should error and return that
error to the client.
Kubernetes-commit: 9aad6aa54d824ba93a6670cd5a0cab6ad337e9f0
2019-11-03 15:08:22 -05:00
6c2628ccd6
json unmarshal coded error at function applyJSPatch()
...
Kubernetes-commit: 1da2d00935942a887205f801d4b2acfa227055d2
2019-11-07 20:40:28 +08:00
48d357e235
Stop Watching when there is encoding error
...
Kubernetes-commit: 639af77d463a4d07bc5d7d19366bd98310b55724
2019-11-07 14:32:47 -08:00
6fd9ceb0b8
Eliminate some default conversions
...
Kubernetes-commit: ccded1494116d6aa1ac3f4612b4a613b56a2044a
2019-11-06 14:02:27 +01:00
44b9fc84ab
migrate callers to g/g/uuid
...
Kubernetes-commit: a4ca9e6c93e45b4a97e7d04df37362299088f64a
2019-11-04 23:15:20 -08:00
00d376192a
rename metric for apiserver request terminations and reword corresponding documentation
...
Change-Id: I47a9c7b10614afe85bb652fa61984f91848d6d65
Kubernetes-commit: f8f1def5f1d92a588f48ebc01293e142f8dd63fd
2019-10-21 13:26:31 -07:00
a5356f425d
pluralize error metric name
...
Change-Id: I12eb94f41ded20ed5a16332ada13a7b34f75de18
Kubernetes-commit: 5e652fe12605027509870d5d7f821390f20b1cee
2019-10-08 15:49:12 -07:00
4a680138c0
Fix double counting issue for request metrics on timeout.
...
Currently we record request metrics during the normal request flow and
we also manually invoke `Record` in the timeout handler to record
timeouts. This means that we effectively double count whenever we
timeout. This PR renames the `Record` function to `RecordRequestError`
to more accurately reflect the intended side-effect of the function
call.
Change-Id: Ie37fd0c1e501bd525640a434433d364a5fd6dde2
Kubernetes-commit: 4c6e7247878477a1f2efc26df7f141258010374f
2019-10-02 15:04:29 -07:00
bde5fd1449
choose a more unique request timeout default
...
Kubernetes-commit: e1dd9af8948f983d48dfc0dd81dc31b7d6c1672f
2019-05-30 15:17:40 -04:00
a5b9ca7482
feat(apiserver): add user-agent and remote info into trace log for endpoints handlers.
...
Kubernetes-commit: 91bddd13485082892be8e8e471e358be317c4e9b
2019-10-10 21:30:05 +08:00
5f538bd5e3
Optimize NegotiateMediaTypeOptions
...
Kubernetes-commit: 1baf4778ae130dc9c305736216b5f5024a962595
2019-10-10 11:49:31 +02:00
7687c3a4e8
Migrate prometheus bucket functionality to metrics stability framework.
...
Kubernetes-commit: 1f9ab1b85c5560a155b1702d1b5d28aa2d95a1b7
2019-09-12 17:10:44 +08:00
72d976a445
Cap the number of managedFields entries for updates at 10
...
Kubernetes-commit: 61b19c729892a150b61dde19359f6fb19e8d61f1
2019-09-26 12:53:28 -07:00
49914e3423
Refactor fieldmanager to be more modular
...
Kubernetes-commit: d72260b9dad186d96aa621dc8594ca9bd6088937
2019-09-19 13:14:36 -07:00
f7fbf2eee4
Limit YAML/JSON decode size
...
Kubernetes-commit: 8ef4566cefebf49f9a806a36df2105c9149785a1
2019-09-27 16:36:48 -04:00
94a2664cd3
Implement support for CacheableObject
...
Kubernetes-commit: 970f103e2c079da98743db35e38fd411a64e2e04
2019-08-15 22:02:33 +02:00
f186d58ea0
Fix transformObject to work with CacheableObject.
...
Kubernetes-commit: 1dd43724ce97b610aae7f9e0f3842f0798ec9d7b
2019-08-19 09:55:49 +02:00
4aa6bc019e
Implement Encoder.Identifier() method
...
Kubernetes-commit: cd4215ad8b95773a793f69fc2e8bf93c7ede97aa
2019-08-14 16:23:03 +02:00
3e0b6a7493
Apply current parses the yaml object 3 times
...
This is super expensive and not needed at all since we don't have to
reparse the entire object. Remove all allocations but the first one.
Kubernetes-commit: 31c644a1e79c685b52683ed1e84964186a37f3ff
2019-09-25 12:38:38 -07:00
81b54ad46e
Add tests and benchmarks for endpoints and node
...
Kubernetes-commit: 0b7ea8bb0e9cc10335044f9ef75920d59462a4ca
2019-09-20 13:32:06 -07:00
db9f1ff5ea
Improve fieldmanager tests and benchmarks
...
Kubernetes-commit: fae9d0ee2136d3443cdd87b1a26a06d7857b01ee
2019-09-10 14:06:08 -07:00
5f565617cd
Add metrics of authentication overall latency.
...
Add alpha tags to authentication_attempts explicitly.
Kubernetes-commit: 0c0d69e8be69fd2e1c62a292ed44be6c0d4158fc
2019-09-04 20:50:24 +08:00
d1d66bda16
Propagate context to Authorize() calls
...
Kubernetes-commit: 92eb072989eba22236d034b56cc2bf159dfb4915
2019-09-24 10:06:32 -04:00
6c75819b84
Split fieldmanager with interface
...
Kubernetes-commit: 2c67bf47db8557b6481a5181bdae924e91665988
2019-09-12 10:57:21 -07:00
a64485969d
Verify the response audience matches one of apiAuds
...
Kubernetes-commit: d66d0472057dc59dff5ac686aea4304e5fe2eded
2019-09-13 06:41:23 -07:00
ba8f49cc73
Ensure conversions are registered for metainternalversion codecs
...
Kubernetes-commit: 54163527a69a8c868b87d301876559495220d1b0
2019-09-11 16:30:08 +02:00
223a2b92f0
Propagate and honor http.ErrAbortHandler
...
Kubernetes-commit: 43415294a72d13a6d685ec0e2ecb274fada7587c
2019-09-11 11:16:31 -04:00
912f3b47b9
Refactor FieldManager tests to make them simpler
...
This is the first step on this, but there are a few improvements that
I'd like to do here.
Kubernetes-commit: b10ad55119a155b776b272a7139dfbed604b05d6
2019-09-10 15:05:26 -07:00
5bce489f18
fix some ineffassigns
...
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>
Kubernetes-commit: aaed9daf9b44757e767d93bd45d1bb0412c00243
2019-09-09 18:52:17 +08:00
fc05a0cd5b
endpoints: fix admission test types
...
Kubernetes-commit: 420f010f8798a8938ff4332ca53bbac8a8e09c01
2019-09-09 08:36:52 +02:00
a50931ba7e
Move Update Apply conflict test to field manager test
...
Kubernetes-commit: 9828f986afd4db79a10c78bee1cc2e449faee3a6
2019-08-30 14:47:39 -07:00
Ken Sipe