/* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package testing import ( "context" "errors" "fmt" "math" "reflect" "strconv" "sync" "testing" "github.com/google/go-cmp/cmp" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/fields" "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/watch" "k8s.io/apiserver/pkg/apis/example" "k8s.io/apiserver/pkg/storage" ) type KeyValidation func(ctx context.Context, t *testing.T, key string) func RunTestCreate(ctx context.Context, t *testing.T, store storage.Interface, validation KeyValidation) { key := "/testkey" out := &example.Pod{} obj := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo", SelfLink: "testlink"}} // verify that kv pair is empty before set if err := store.Get(ctx, key, storage.GetOptions{}, out); !storage.IsNotFound(err) { t.Fatalf("expecting empty result on key %s, got %v", key, err) } if err := store.Create(ctx, key, obj, out, 0); err != nil { t.Fatalf("Set failed: %v", err) } // basic tests of the output if obj.ObjectMeta.Name != out.ObjectMeta.Name { t.Errorf("pod name want=%s, get=%s", obj.ObjectMeta.Name, out.ObjectMeta.Name) } if out.ResourceVersion == "" { t.Errorf("output should have non-empty resource version") } if out.SelfLink != "" { t.Errorf("output should have empty selfLink") } validation(ctx, t, key) } func RunTestCreateWithTTL(ctx context.Context, t *testing.T, store storage.Interface) { input := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}} key := "/somekey" out := &example.Pod{} if err := store.Create(ctx, key, input, out, 1); err != nil { t.Fatalf("Create failed: %v", err) } w, err := store.Watch(ctx, key, storage.ListOptions{ResourceVersion: out.ResourceVersion, Predicate: storage.Everything}) if err != nil { t.Fatalf("Watch failed: %v", err) } TestCheckEventType(t, watch.Deleted, w) } func RunTestCreateWithKeyExist(ctx context.Context, t *testing.T, store storage.Interface) { obj := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}} key, _ := TestPropogateStore(ctx, t, store, obj) out := &example.Pod{} err := store.Create(ctx, key, obj, out, 0) if err == nil || !storage.IsExist(err) { t.Errorf("expecting key exists error, but get: %s", err) } } func RunTestGet(ctx context.Context, t *testing.T, store storage.Interface) { // create an object to test key, createdObj := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}}) // update the object once to allow get by exact resource version to be tested updateObj := createdObj.DeepCopy() updateObj.Annotations = map[string]string{"test-annotation": "1"} storedObj := &example.Pod{} err := store.GuaranteedUpdate(ctx, key, storedObj, true, nil, func(_ runtime.Object, _ storage.ResponseMeta) (runtime.Object, *uint64, error) { ttl := uint64(1) return updateObj, &ttl, nil }, nil) if err != nil { t.Fatalf("Update failed: %v", err) } // create an additional object to increment the resource version for pods above the resource version of the foo object lastUpdatedObj := &example.Pod{} if err := store.Create(ctx, "bar", &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "bar"}}, lastUpdatedObj, 0); err != nil { t.Fatalf("Set failed: %v", err) } currentRV, _ := strconv.Atoi(storedObj.ResourceVersion) lastUpdatedCurrentRV, _ := strconv.Atoi(lastUpdatedObj.ResourceVersion) // TODO(jpbetz): Add exact test cases tests := []struct { name string key string ignoreNotFound bool expectNotFoundErr bool expectRVTooLarge bool expectedOut *example.Pod rv string }{{ // test get on existing item name: "get existing", key: key, ignoreNotFound: false, expectNotFoundErr: false, expectedOut: storedObj, }, { // test get on existing item with resource version set to 0 name: "resource version 0", key: key, expectedOut: storedObj, rv: "0", }, { // test get on existing item with resource version set to the resource version is was created on name: "object created resource version", key: key, expectedOut: storedObj, rv: createdObj.ResourceVersion, }, { // test get on existing item with resource version set to current resource version of the object name: "current object resource version, match=NotOlderThan", key: key, expectedOut: storedObj, rv: fmt.Sprintf("%d", currentRV), }, { // test get on existing item with resource version set to latest pod resource version name: "latest resource version", key: key, expectedOut: storedObj, rv: fmt.Sprintf("%d", lastUpdatedCurrentRV), }, { // test get on existing item with resource version set too high name: "too high resource version", key: key, expectRVTooLarge: true, rv: strconv.FormatInt(math.MaxInt64, 10), }, { // test get on non-existing item with ignoreNotFound=false name: "get non-existing", key: "/non-existing", ignoreNotFound: false, expectNotFoundErr: true, }, { // test get on non-existing item with ignoreNotFound=true name: "get non-existing, ignore not found", key: "/non-existing", ignoreNotFound: true, expectNotFoundErr: false, expectedOut: &example.Pod{}, }} for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { out := &example.Pod{} err := store.Get(ctx, tt.key, storage.GetOptions{IgnoreNotFound: tt.ignoreNotFound, ResourceVersion: tt.rv}, out) if tt.expectNotFoundErr { if err == nil || !storage.IsNotFound(err) { t.Errorf("expecting not found error, but get: %v", err) } return } if tt.expectRVTooLarge { if err == nil || !storage.IsTooLargeResourceVersion(err) { t.Errorf("expecting resource version too high error, but get: %v", err) } return } if err != nil { t.Fatalf("Get failed: %v", err) } ExpectNoDiff(t, fmt.Sprintf("%s: incorrect pod", tt.name), tt.expectedOut, out) }) } } func RunTestUnconditionalDelete(ctx context.Context, t *testing.T, store storage.Interface) { key, storedObj := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}}) tests := []struct { name string key string expectedObj *example.Pod expectNotFoundErr bool }{{ name: "existing key", key: key, expectedObj: storedObj, expectNotFoundErr: false, }, { name: "non-existing key", key: "/non-existing", expectedObj: nil, expectNotFoundErr: true, }} for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { out := &example.Pod{} // reset err := store.Delete(ctx, tt.key, out, nil, storage.ValidateAllObjectFunc, nil) if tt.expectNotFoundErr { if err == nil || !storage.IsNotFound(err) { t.Errorf("%s: expecting not found error, but get: %s", tt.name, err) } return } if err != nil { t.Fatalf("%s: Delete failed: %v", tt.name, err) } ExpectNoDiff(t, fmt.Sprintf("%s: incorrect pod:", tt.name), tt.expectedObj, out) }) } } func RunTestConditionalDelete(ctx context.Context, t *testing.T, store storage.Interface) { key, storedObj := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo", UID: "A"}}) tests := []struct { name string precondition *storage.Preconditions expectInvalidObjErr bool }{{ name: "UID match", precondition: storage.NewUIDPreconditions("A"), expectInvalidObjErr: false, }, { name: "UID mismatch", precondition: storage.NewUIDPreconditions("B"), expectInvalidObjErr: true, }} for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { out := &example.Pod{} err := store.Delete(ctx, key, out, tt.precondition, storage.ValidateAllObjectFunc, nil) if tt.expectInvalidObjErr { if err == nil || !storage.IsInvalidObj(err) { t.Errorf("%s: expecting invalid UID error, but get: %s", tt.name, err) } return } if err != nil { t.Fatalf("%s: Delete failed: %v", tt.name, err) } ExpectNoDiff(t, fmt.Sprintf("%s: incorrect pod", tt.name), storedObj, out) key, storedObj = TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo", UID: "A"}}) }) } } // The following set of Delete tests are testing the logic of adding `suggestion` // as a parameter with probably value of the current state. // Introducing it for GuaranteedUpdate cause a number of issues, so we're addressing // all of those upfront by adding appropriate tests: // - https://github.com/kubernetes/kubernetes/pull/35415 // [DONE] Lack of tests originally - added TestDeleteWithSuggestion. // - https://github.com/kubernetes/kubernetes/pull/40664 // [DONE] Irrelevant for delete, as Delete doesn't write data (nor compare it). // - https://github.com/kubernetes/kubernetes/pull/47703 // [DONE] Irrelevant for delete, because Delete doesn't persist data. // - https://github.com/kubernetes/kubernetes/pull/48394/ // [DONE] Irrelevant for delete, because Delete doesn't compare data. // - https://github.com/kubernetes/kubernetes/pull/43152 // [DONE] Added TestDeleteWithSuggestionAndConflict // - https://github.com/kubernetes/kubernetes/pull/54780 // [DONE] Irrelevant for delete, because Delete doesn't compare data. // - https://github.com/kubernetes/kubernetes/pull/58375 // [DONE] Irrelevant for delete, because Delete doesn't compare data. // - https://github.com/kubernetes/kubernetes/pull/77619 // [DONE] Added TestValidateDeletionWithSuggestion for corresponding delete checks. // - https://github.com/kubernetes/kubernetes/pull/78713 // [DONE] Bug was in getState function which is shared with the new code. // - https://github.com/kubernetes/kubernetes/pull/78713 // [DONE] Added TestPreconditionalDeleteWithSuggestion func RunTestDeleteWithSuggestion(ctx context.Context, t *testing.T, store storage.Interface) { key, originalPod := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "name"}}) out := &example.Pod{} if err := store.Delete(ctx, key, out, nil, storage.ValidateAllObjectFunc, originalPod); err != nil { t.Errorf("Unexpected failure during deletion: %v", err) } if err := store.Get(ctx, key, storage.GetOptions{}, &example.Pod{}); !storage.IsNotFound(err) { t.Errorf("Unexpected error on reading object: %v", err) } } func RunTestDeleteWithSuggestionAndConflict(ctx context.Context, t *testing.T, store storage.Interface) { key, originalPod := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "name"}}) // First update, so originalPod is outdated. updatedPod := &example.Pod{} if err := store.GuaranteedUpdate(ctx, key, updatedPod, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) pod.ObjectMeta.Labels = map[string]string{"foo": "bar"} return pod, nil }), nil); err != nil { t.Errorf("Unexpected failure during updated: %v", err) } out := &example.Pod{} if err := store.Delete(ctx, key, out, nil, storage.ValidateAllObjectFunc, originalPod); err != nil { t.Errorf("Unexpected failure during deletion: %v", err) } if err := store.Get(ctx, key, storage.GetOptions{}, &example.Pod{}); !storage.IsNotFound(err) { t.Errorf("Unexpected error on reading object: %v", err) } } func RunTestDeleteWithSuggestionOfDeletedObject(ctx context.Context, t *testing.T, store storage.Interface) { key, originalPod := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "name"}}) // First delete, so originalPod is outdated. deletedPod := &example.Pod{} if err := store.Delete(ctx, key, deletedPod, nil, storage.ValidateAllObjectFunc, originalPod); err != nil { t.Errorf("Unexpected failure during deletion: %v", err) } // Now try deleting with stale object. out := &example.Pod{} if err := store.Delete(ctx, key, out, nil, storage.ValidateAllObjectFunc, originalPod); !storage.IsNotFound(err) { t.Errorf("Unexpected error during deletion: %v, expected not-found", err) } } func RunTestValidateDeletionWithSuggestion(ctx context.Context, t *testing.T, store storage.Interface) { key, originalPod := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "name"}}) // Check that validaing fresh object fails is called once and fails. validationCalls := 0 validationError := fmt.Errorf("validation error") validateNothing := func(_ context.Context, _ runtime.Object) error { validationCalls++ return validationError } out := &example.Pod{} if err := store.Delete(ctx, key, out, nil, validateNothing, originalPod); err != validationError { t.Errorf("Unexpected failure during deletion: %v", err) } if validationCalls != 1 { t.Errorf("validate function should have been called once, called %d", validationCalls) } // First update, so originalPod is outdated. updatedPod := &example.Pod{} if err := store.GuaranteedUpdate(ctx, key, updatedPod, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) pod.ObjectMeta.Labels = map[string]string{"foo": "bar"} return pod, nil }), nil); err != nil { t.Errorf("Unexpected failure during updated: %v", err) } calls := 0 validateFresh := func(_ context.Context, obj runtime.Object) error { calls++ pod := obj.(*example.Pod) if pod.ObjectMeta.Labels == nil || pod.ObjectMeta.Labels["foo"] != "bar" { return fmt.Errorf("stale object") } return nil } if err := store.Delete(ctx, key, out, nil, validateFresh, originalPod); err != nil { t.Errorf("Unexpected failure during deletion: %v", err) } if calls != 2 { t.Errorf("validate function should have been called twice, called %d", calls) } if err := store.Get(ctx, key, storage.GetOptions{}, &example.Pod{}); !storage.IsNotFound(err) { t.Errorf("Unexpected error on reading object: %v", err) } } func RunTestPreconditionalDeleteWithSuggestion(ctx context.Context, t *testing.T, store storage.Interface) { key, originalPod := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "name"}}) // First update, so originalPod is outdated. updatedPod := &example.Pod{} if err := store.GuaranteedUpdate(ctx, key, updatedPod, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) pod.ObjectMeta.UID = "myUID" return pod, nil }), nil); err != nil { t.Errorf("Unexpected failure during updated: %v", err) } prec := storage.NewUIDPreconditions("myUID") out := &example.Pod{} if err := store.Delete(ctx, key, out, prec, storage.ValidateAllObjectFunc, originalPod); err != nil { t.Errorf("Unexpected failure during deletion: %v", err) } if err := store.Get(ctx, key, storage.GetOptions{}, &example.Pod{}); !storage.IsNotFound(err) { t.Errorf("Unexpected error on reading object: %v", err) } } func RunTestGetListNonRecursive(ctx context.Context, t *testing.T, store storage.Interface) { prevKey, prevStoredObj := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "prev"}}) prevRV, _ := strconv.Atoi(prevStoredObj.ResourceVersion) key, storedObj := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}}) currentRV, _ := strconv.Atoi(storedObj.ResourceVersion) tests := []struct { name string key string pred storage.SelectionPredicate expectedOut []*example.Pod rv string rvMatch metav1.ResourceVersionMatch expectRVTooLarge bool }{{ name: "existing key", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, }, { name: "existing key, resourceVersion=0", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: "0", }, { name: "existing key, resourceVersion=0, resourceVersionMatch=notOlderThan", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: "0", rvMatch: metav1.ResourceVersionMatchNotOlderThan, }, { name: "existing key, resourceVersion=current", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: fmt.Sprintf("%d", currentRV), }, { name: "existing key, resourceVersion=current, resourceVersionMatch=notOlderThan", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: fmt.Sprintf("%d", currentRV), rvMatch: metav1.ResourceVersionMatchNotOlderThan, }, { name: "existing key, resourceVersion=previous, resourceVersionMatch=notOlderThan", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: fmt.Sprintf("%d", prevRV), rvMatch: metav1.ResourceVersionMatchNotOlderThan, }, { name: "existing key, resourceVersion=current, resourceVersionMatch=exact", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: fmt.Sprintf("%d", currentRV), rvMatch: metav1.ResourceVersionMatchExact, }, { name: "existing key, resourceVersion=current, resourceVersionMatch=exact", key: prevKey, pred: storage.Everything, expectedOut: []*example.Pod{prevStoredObj}, rv: fmt.Sprintf("%d", prevRV), rvMatch: metav1.ResourceVersionMatchExact, }, { name: "existing key, resourceVersion=too high", key: key, pred: storage.Everything, expectedOut: []*example.Pod{storedObj}, rv: strconv.FormatInt(math.MaxInt64, 10), expectRVTooLarge: true, }, { name: "non-existing key", key: "/non-existing", pred: storage.Everything, expectedOut: nil, }, { name: "with matching pod name", key: "/non-existing", pred: storage.SelectionPredicate{ Label: labels.Everything(), Field: fields.ParseSelectorOrDie("metadata.name!=" + storedObj.Name), GetAttrs: func(obj runtime.Object) (labels.Set, fields.Set, error) { pod := obj.(*example.Pod) return nil, fields.Set{"metadata.name": pod.Name}, nil }, }, expectedOut: nil, }} for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { out := &example.PodList{} storageOpts := storage.ListOptions{ ResourceVersion: tt.rv, ResourceVersionMatch: tt.rvMatch, Predicate: tt.pred, Recursive: false, } err := store.GetList(ctx, tt.key, storageOpts, out) if tt.expectRVTooLarge { if err == nil || !storage.IsTooLargeResourceVersion(err) { t.Errorf("%s: expecting resource version too high error, but get: %s", tt.name, err) } return } if err != nil { t.Fatalf("GetList failed: %v", err) } if len(out.ResourceVersion) == 0 { t.Errorf("%s: unset resourceVersion", tt.name) } if len(out.Items) != len(tt.expectedOut) { t.Errorf("%s: length of list want=%d, get=%d", tt.name, len(tt.expectedOut), len(out.Items)) return } for j, wantPod := range tt.expectedOut { getPod := &out.Items[j] ExpectNoDiff(t, fmt.Sprintf("%s: incorrect pod", tt.name), wantPod, getPod) } }) } } func RunTestGuaranteedUpdateWithTTL(ctx context.Context, t *testing.T, store storage.Interface) { input := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}} key := "/somekey" out := &example.Pod{} err := store.GuaranteedUpdate(ctx, key, out, true, nil, func(_ runtime.Object, _ storage.ResponseMeta) (runtime.Object, *uint64, error) { ttl := uint64(1) return input, &ttl, nil }, nil) if err != nil { t.Fatalf("Create failed: %v", err) } w, err := store.Watch(ctx, key, storage.ListOptions{ResourceVersion: out.ResourceVersion, Predicate: storage.Everything}) if err != nil { t.Fatalf("Watch failed: %v", err) } TestCheckEventType(t, watch.Deleted, w) } func RunTestGuaranteedUpdateWithConflict(ctx context.Context, t *testing.T, store storage.Interface) { key, _ := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}}) errChan := make(chan error, 1) var firstToFinish sync.WaitGroup var secondToEnter sync.WaitGroup firstToFinish.Add(1) secondToEnter.Add(1) go func() { err := store.GuaranteedUpdate(ctx, key, &example.Pod{}, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) pod.Name = "foo-1" secondToEnter.Wait() return pod, nil }), nil) firstToFinish.Done() errChan <- err }() updateCount := 0 err := store.GuaranteedUpdate(ctx, key, &example.Pod{}, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { if updateCount == 0 { secondToEnter.Done() firstToFinish.Wait() } updateCount++ pod := obj.(*example.Pod) pod.Name = "foo-2" return pod, nil }), nil) if err != nil { t.Fatalf("Second GuaranteedUpdate error %#v", err) } if err := <-errChan; err != nil { t.Fatalf("First GuaranteedUpdate error %#v", err) } if updateCount != 2 { t.Errorf("Should have conflict and called update func twice") } } func RunTestGuaranteedUpdateWithSuggestionAndConflict(ctx context.Context, t *testing.T, store storage.Interface) { key, originalPod := TestPropogateStore(ctx, t, store, &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: "foo"}}) // First, update without a suggestion so originalPod is outdated updatedPod := &example.Pod{} err := store.GuaranteedUpdate(ctx, key, updatedPod, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) pod.Name = "foo-2" return pod, nil }), nil, ) if err != nil { t.Fatalf("unexpected error: %v", err) } // Second, update using the outdated originalPod as the suggestion. Return a conflict error when // passed originalPod, and make sure that SimpleUpdate is called a second time after a live lookup // with the value of updatedPod. sawConflict := false updatedPod2 := &example.Pod{} err = store.GuaranteedUpdate(ctx, key, updatedPod2, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) if pod.Name != "foo-2" { if sawConflict { t.Fatalf("unexpected second conflict") } sawConflict = true // simulated stale object - return a conflict return nil, apierrors.NewConflict(example.SchemeGroupVersion.WithResource("pods").GroupResource(), "name", errors.New("foo")) } pod.Name = "foo-3" return pod, nil }), originalPod, ) if err != nil { t.Fatalf("unexpected error: %v", err) } if updatedPod2.Name != "foo-3" { t.Errorf("unexpected pod name: %q", updatedPod2.Name) } // Third, update using a current version as the suggestion. // Return an error and make sure that SimpleUpdate is NOT called a second time, // since the live lookup shows the suggestion was already up to date. attempts := 0 updatedPod3 := &example.Pod{} err = store.GuaranteedUpdate(ctx, key, updatedPod3, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) { pod := obj.(*example.Pod) if pod.Name != updatedPod2.Name || pod.ResourceVersion != updatedPod2.ResourceVersion { t.Errorf( "unexpected live object (name=%s, rv=%s), expected name=%s, rv=%s", pod.Name, pod.ResourceVersion, updatedPod2.Name, updatedPod2.ResourceVersion, ) } attempts++ return nil, fmt.Errorf("validation or admission error") }), updatedPod2, ) if err == nil { t.Fatalf("expected error, got none") } if attempts != 1 { t.Errorf("expected 1 attempt, got %d", attempts) } } // TestPropogateStore helps propagates store with objects, automates key generation, and returns // keys and stored objects. func TestPropogateStore(ctx context.Context, t *testing.T, store storage.Interface, obj *example.Pod) (string, *example.Pod) { // Setup store with a key and grab the output for returning. key := "/testkey" return key, TestPropogateStoreWithKey(ctx, t, store, key, obj) } // TestPropogateStoreWithKey helps propagate store with objects, the given object will be stored at the specified key. func TestPropogateStoreWithKey(ctx context.Context, t *testing.T, store storage.Interface, key string, obj *example.Pod) *example.Pod { // Setup store with the specified key and grab the output for returning. err := store.Delete(ctx, key, &example.Pod{}, nil, storage.ValidateAllObjectFunc, nil) if err != nil && !storage.IsNotFound(err) { t.Fatalf("Cleanup failed: %v", err) } setOutput := &example.Pod{} if err := store.Create(ctx, key, obj, setOutput, 0); err != nil { t.Fatalf("Set failed: %v", err) } return setOutput } func RunTestCount(ctx context.Context, t *testing.T, store storage.Interface) { resourceA := "/foo.bar.io/abc" // resourceA is intentionally a prefix of resourceB to ensure that the count // for resourceA does not include any objects from resourceB. resourceB := fmt.Sprintf("%sdef", resourceA) resourceACountExpected := 5 for i := 1; i <= resourceACountExpected; i++ { obj := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: fmt.Sprintf("foo-%d", i)}} key := fmt.Sprintf("%s/%d", resourceA, i) TestPropogateStoreWithKey(ctx, t, store, key, obj) } resourceBCount := 4 for i := 1; i <= resourceBCount; i++ { obj := &example.Pod{ObjectMeta: metav1.ObjectMeta{Name: fmt.Sprintf("foo-%d", i)}} key := fmt.Sprintf("%s/%d", resourceB, i) TestPropogateStoreWithKey(ctx, t, store, key, obj) } resourceACountGot, err := store.Count(resourceA) if err != nil { t.Fatalf("store.Count failed: %v", err) } // count for resourceA should not include the objects for resourceB // even though resourceA is a prefix of resourceB. if int64(resourceACountExpected) != resourceACountGot { t.Fatalf("store.Count for resource %s: expected %d but got %d", resourceA, resourceACountExpected, resourceACountGot) } } func ExpectNoDiff(t *testing.T, msg string, expected, got interface{}) { t.Helper() if !reflect.DeepEqual(expected, got) { if diff := cmp.Diff(expected, got); diff != "" { t.Errorf("%s: %s", msg, diff) } else { t.Errorf("%s:\nexpected: %#v\ngot: %#v", msg, expected, got) } } }