The effective layering of ResponseWriters is today, from outside to inside, httplog(timeout(audit(metrics(original)))). From 6e3fd91e1aa3259d7bd67e0a65693e346ade347d, calls to http.Error in the apiserver's root healthz handler use an unwrapped ResponseWriter -- effectively timeout(audit(metrics(original))) -- to avoid logging stack traces for those requests. From 0d50c969c587c8a6c16e0962118305ac652c5a6b, the same call to http.Error receives a completely-unwrapped ResponseWriter. This has the effect of bypassing not only the httplog wrapper, but also timeout, audit, and metrics. The timeout wrapper defends against the (disallowed) use of underyling ResponseWriter after the completion of its request's ServeHTTP call. Since that defensive behavior is being bypassed, it's possible for the root healthz handler to panic when health probes time out. Instead of continuing to use a wrapper-aware means of disabling stack traces, this commit adds a new function to httplog that allows customization of the stack trace logging predicate on a per-request basis. Kubernetes-commit: ff849fe8b688606d5173d5ee0213a96cffae23c0 |
||
|---|---|---|
| .github | ||
| pkg | ||
| plugin/pkg | ||
| .import-restrictions | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| OWNERS | ||
| README.md | ||
| SECURITY_CONTACTS | ||
| code-of-conduct.md | ||
| doc.go | ||
| go.mod | ||
| go.sum | ||
README.md
apiserver
Generic library for building a Kubernetes aggregated API server.
Purpose
This library contains code to create Kubernetes aggregation server complete with delegated authentication and authorization,
kubectl compatible discovery information, optional admission chain, and versioned types. It's first consumers are
k8s.io/kubernetes, k8s.io/kube-aggregator, and github.com/kubernetes-incubator/service-catalog.
Compatibility
There are NO compatibility guarantees for this repository, yet. It is in direct support of Kubernetes, so branches will track Kubernetes and be compatible with that repo. As we more cleanly separate the layers, we will review the compatibility guarantee. We have a goal to make this easier to use in the future.
Where does it come from?
apiserver is synced from https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver.
Code changes are made in that location, merged into k8s.io/kubernetes and later synced here.
Things you should NOT do
- Directly modify any files under
pkgin this repo. Those are driven fromk8s.io/kubernetes/staging/src/k8s.io/apiserver. - Expect compatibility. This repo is changing quickly in direct support of Kubernetes and the API isn't yet stable enough for API guarantees.