kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
apiserver/Godeps
History
Kubernetes Publisher 9a8af0d13f Merge pull request #66807 from caesarxuchao/remove-connectrequest 
Automatic merge from submit-queue (batch tested with PRs 66196, 67016, 66807, 67023). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Make admission webhooks conversion convert CONNECT body correctly

Fix #59759.

1. Make apiserver pass connectRequest.Options directly to the admission layer. All other information in rest.ConnectRequest is present in admission attributes.
2. Make the scope.Kind of pod/attach, pod/exec, pod/portforward, node/proxy, service/proxy to their respective options Kind, instead of the parent Kind.

I've tested it locally, the conversion is working correctly for "kubectl attach". I'll add e2e tests.

I'll keep this to myself until I add the tests, but cc @mikedanese @liggitt RE. https://github.com/kubernetes/kubernetes/pull/66633.

Kubernetes-commit: d1636b8019fa042eb1135263b00293b1c806b1d7
 		2018-08-07 21:46:05 +00:00
..
Godeps.json Merge pull request #66807 from caesarxuchao/remove-connectrequest 2018-08-07 21:46:05 +00:00
OWNERS Remove dep-reviewers 2018-02-26 11:11:15 -08:00
Readme update godep.json files 2017-02-23 09:48:09 -05:00

Readme 

This directory tree is generated automatically by godep.

Please do not edit.

See https://github.com/tools/godep for more information.