kubernetes
/
apiserver
mirror of https://github.com/kubernetes/apiserver.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
apiserver/pkg/server
History
Patrick Ohly ec795ae204 avoid klog Info calls without verbosity 
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.

Kubernetes-commit: 9eaa2dc554e0c3d4485d4c916dfdbc2f517db2e0
 		2021-12-11 12:10:21 +01:00
..
dynamiccertificates run hack/update-netparse-cve.sh 2021-08-20 01:16:14 +02:00
egressselector apiserver aggregator upgrade unit test 2021-10-05 00:19:43 +02:00
filters Fix header mutation race in timeout filter 2022-01-04 22:57:29 -05:00
healthz Don't bypass ResponseWriter wrappers for apiserver healthz errors. 2021-12-14 16:23:36 -05:00
httplog avoid klog Info calls without verbosity 2021-12-11 12:10:21 +01:00
mux Check in OWNERS modified by update-yamlfmt.sh 2021-12-09 21:31:26 -05:00
options Cleanup OWNERS files (No Activity in the last year) 2021-12-10 15:18:50 -05:00
resourceconfig switch over k/k to use klog v2 2020-04-17 15:25:06 -04:00
routes Check in OWNERS modified by update-yamlfmt.sh 2021-12-09 21:31:26 -05:00
storage Introduce storagebackend.ConfigForResource 2021-08-29 01:06:12 -04:00
config.go Added requestSloLatencies metric 2021-10-25 22:19:24 +00:00
config_selfclient.go Move the comment to the right line 2021-04-23 00:05:15 +00:00
config_selfclient_test.go run hack/update-netparse-cve.sh 2021-08-20 01:16:14 +02:00
config_test.go genericapiserver: indroduce muxCompleteSignals for holding signals that indicate all known HTTP paths have been registered 2021-10-15 18:14:20 +02:00
deleted_kinds.go Revert strict-in-alpha to false 2021-11-12 17:04:41 -05:00
deleted_kinds_test.go enforce strict alpha handling for API serving 2021-05-12 09:17:15 -04:00
deprecated_insecure_serving.go Set idle and readheader timeouts 2021-07-27 11:58:45 -04:00
doc.go update docs.go files under staging/src/k8s.io/apiserver/pkg/server 2019-02-03 20:43:13 +00:00
genericapiserver.go Rename ServeWithListenerStopped to Serve in secure_serving 2021-11-08 17:20:31 +03:00
genericapiserver_graceful_termination_test.go aggregator: pass apiServiceRegistrationControllerInitiated signal directly to apiserviceRegistration controller 2021-10-20 11:06:27 +02:00
genericapiserver_test.go aggregator: pass apiServiceRegistrationControllerInitiated signal directly to apiserviceRegistration controller 2021-10-20 11:06:27 +02:00
graceful_shutdown_test.go adds a unit test for checking if graceful shutdown of HTTP2 server works 2020-12-11 13:12:46 +01:00
handler.go k8s.io/apiserver/pkg/server: fix name in APIServerHandler description 2021-10-04 14:54:14 +02:00
healthz.go Migrate to k8s.io/utils/clock in apiserver 2021-09-14 20:36:07 +02:00
healthz_test.go Migrate to k8s.io/utils/clock in apiserver 2021-09-14 20:36:07 +02:00
hooks.go switch over k/k to use klog v2 2020-04-17 15:25:06 -04:00
lifecycle_signals.go rename to muxAndDiscoveryComplete 2021-10-19 12:24:00 +02:00
plugins.go Remove alpha InitializerConfiguration types, Initializers admission plugin 2019-01-16 10:19:44 -05:00
secure_serving.go Rename ServeWithListenerStopped to Serve in secure_serving 2021-11-08 17:20:31 +03:00
signal.go make Kubelet bootstrap certificate signal aware 2020-07-04 12:08:04 +08:00
signal_posix.go generated: Run hack/update-gofmt.sh 2021-08-12 17:13:11 -04:00
signal_windows.go apiservers: add synchronous shutdown mechanism on SIGTERM+INT 2017-08-29 13:16:11 +00:00