apiserver

History

Kubernetes Publisher 58bab6c3cd Merge pull request #58547 from liggitt/watch-cache-delete-resourceversion Automatic merge from submit-queue (batch tested with PRs 58547, 57228, 58528, 58499, 58618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Send correct resource version for delete events from watch cache Fixes #58545 the watch cache filtering is returning the previous object content intact, including resource version. this is the logic the watch cache uses: ```go switch { case curObjPasses && !oldObjPasses: watchEvent = watch.Event{Type: watch.Added, Object: event.Object.DeepCopyObject()} case curObjPasses && oldObjPasses: watchEvent = watch.Event{Type: watch.Modified, Object: event.Object.DeepCopyObject()} case !curObjPasses && oldObjPasses: watchEvent = watch.Event{Type: watch.Deleted, Object: event.PrevObject.DeepCopyObject()} } ``` when processing a delete event, we should be sending the old object's content but with the event's resource version set in it. corresponding logic exists in the uncached stores: `77ac663df4/staging/src/k8s.io/apiserver/pkg/storage/etcd/etcd_watcher.go (L401-L403)` `77ac663df4/staging/src/k8s.io/apiserver/pkg/storage/etcd3/watcher.go (L373-L378)` ```release-note Fixes an issue where the resourceVersion of an object in a DELETE watch event was not the resourceVersion of the delete itself, but of the last update to the object. This could cause clients receiving the watch event to revert to an old "last observed" resource version, and disrupt their ability to re-establish watches properly. ``` Kubernetes-commit: 619305f1015758f5ffc858a5b3e26d1a779c4278	2018-01-23 05:15:08 +00:00
..
Godeps.json	Merge pull request #58547 from liggitt/watch-cache-delete-resourceversion	2018-01-23 05:15:08 +00:00
Readme	update godep.json files	2017-02-23 09:48:09 -05:00

Kubernetes Publisher 58bab6c3cd Merge pull request #58547 from liggitt/watch-cache-delete-resourceversion

Automatic merge from submit-queue (batch tested with PRs 58547, 57228, 58528, 58499, 58618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Send correct resource version for delete events from watch cache

Fixes #58545

the watch cache filtering is returning the previous object content intact, including resource version. this is the logic the watch cache uses:
```go
switch {
case curObjPasses && !oldObjPasses:
	watchEvent = watch.Event{Type: watch.Added, Object: event.Object.DeepCopyObject()}
case curObjPasses && oldObjPasses:
	watchEvent = watch.Event{Type: watch.Modified, Object: event.Object.DeepCopyObject()}
case !curObjPasses && oldObjPasses:
	watchEvent = watch.Event{Type: watch.Deleted, Object: event.PrevObject.DeepCopyObject()}
}
```

when processing a delete event, we should be sending the old object's content *but* with the event's resource version set in it. corresponding logic exists in the uncached stores:

77ac663df4/staging/src/k8s.io/apiserver/pkg/storage/etcd/etcd_watcher.go (L401-L403)

77ac663df4/staging/src/k8s.io/apiserver/pkg/storage/etcd3/watcher.go (L373-L378)

```release-note
Fixes an issue where the resourceVersion of an object in a DELETE watch event was not the resourceVersion of the delete itself, but of the last update to the object. This could cause clients receiving the watch event to revert to an old "last observed" resource version, and disrupt their ability to re-establish watches properly.
```

Kubernetes-commit: 619305f1015758f5ffc858a5b3e26d1a779c4278

2018-01-23 05:15:08 +00:00

Godeps.json Merge pull request #58547 from liggitt/watch-cache-delete-resourceversion 2018-01-23 05:15:08 +00:00

Readme update godep.json files 2017-02-23 09:48:09 -05:00

Readme

This directory tree is generated automatically by godep.

Please do not edit.

See https://github.com/tools/godep for more information.