kubernetes
/
autoscaler
mirror of https://github.com/kubernetes/autoscaler.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

nit: when scheduling fails on topology constraints, skip the last node that failed scheduling 

Signed-off-by: MenD32 <amit.mendelevitch@gmail.com>
This commit is contained in:
MenD32 2025-06-11 09:38:49 +03:00
parent 8fd9e1f04d
commit 0002157b3a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cluster-autoscaler/estimator/binpacking_estimator.go
View File

@ -190,7 +190,7 @@ func (e *BinpackingNodeEstimator) tryToScheduleOnNewNodes(
// If the pod can't be scheduled on the last node because of topology constraints, we can stop binpacking. // If the pod can't be scheduled on the last node because of topology constraints, we can stop binpacking.
// The pod can't be scheduled on any new node either, because it has the same topology constraints. // The pod can't be scheduled on any new node either, because it has the same topology constraints.
nodeName, err := e.clusterSnapshot.SchedulePodOnAnyNodeMatching(pod, func(nodeInfo *framework.NodeInfo) bool { nodeName, err := e.clusterSnapshot.SchedulePodOnAnyNodeMatching(pod, func(nodeInfo *framework.NodeInfo) bool {
return true // Node scale-up can cause old nodes to become schedulable, so we check all nodes. return nodeInfo.Node().Name != estimationState.lastNodeName // only skip the last node that failed scheduling
}) })
if err != nil && err.Type() == clustersnapshot.SchedulingInternalError { if err != nil && err.Type() == clustersnapshot.SchedulingInternalError {
// Unexpected error. // Unexpected error.