address comments

cluster-autoscaler/cloudprovider/test/test_cloud_provider.go

@@ -18,7 +18,6 @@ package test
 
 import (
 	"fmt"
-	"sort"
 	"sync"
 
 	apiv1 "k8s.io/api/core/v1"
@@ -137,10 +136,6 @@ func (tcp *TestCloudProvider) NodeGroups() []cloudprovider.NodeGroup {
 	for _, group := range tcp.groups {
 		result = append(result, group)
 	}
-	// Sort the nodegroups in order of Id.
-	sort.Slice(result, func(i, j int) bool {
-		return result[i].Id() < result[j].Id()
-	})
 	return result
 }
 

cluster-autoscaler/core/scaleup/orchestrator/orchestrator_test.go

@@ -860,7 +860,6 @@ func TestBinpackingLimiter(t *testing.T) {
 	expansionOptions := expander.LastInputOptions()
 	// Only 1 expansion option should be there. Without BinpackingLimiter there will be 2.
 	assert.True(t, len(expansionOptions) == 1)
-	assert.Equal(t, expansionOptions, []GroupSizeChange{{GroupName: "ng1", SizeChange: 1}})
 }
 
 func TestScaleUpNoHelp(t *testing.T) {