kubernetes
/
autoscaler
mirror of https://github.com/kubernetes/autoscaler.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add additional error codes for invalid reservations to GCE client

This commit is contained in:
Hakan Bostan 2023-09-07 09:16:58 +00:00
parent 57f2814267
commit 20f41e2ba3
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go
View File

@ -72,6 +72,22 @@ const (
ErrorCodeOther = "OTHER" ErrorCodeOther = "OTHER"
) )
var (
regexReservationErrors = []*regexp.Regexp{
regexp.MustCompile("Incompatible AggregateReservation VMFamily"),
regexp.MustCompile("Could not find the given reservation with the following name"),
regexp.MustCompile("must use ReservationAffinity of"),
regexp.MustCompile("The reservation must exist in the same project as the instance"),
regexp.MustCompile("only compatible with Aggregate Reservations"),
regexp.MustCompile("Please target a reservation with workload_type ="),
regexp.MustCompile("AggregateReservation VMFamily: should be a (.*) VM Family for instance with (.*) machine type"),
regexp.MustCompile("VM Family: (.*) is not supported for aggregate reservations. It must be one of"),
regexp.MustCompile("Reservation (.*) is incorrect for the requested resources"),
regexp.MustCompile("Zone does not currently have sufficient capacity for the requested resources"),
regexp.MustCompile("Reservation (.*) does not have sufficient capacity for the requested resources."),
}
)
// AutoscalingGceClient is used for communicating with GCE API. // AutoscalingGceClient is used for communicating with GCE API.
type AutoscalingGceClient interface { type AutoscalingGceClient interface {
// reading resources // reading resources
@ -453,15 +469,8 @@ func isReservationNotReady(errorCode, errorMessage string) bool {
} }
func isInvalidReservationError(errorCode, errorMessage string) bool { func isInvalidReservationError(errorCode, errorMessage string) bool {
reservationErrors := []string{ for _, re := range regexReservationErrors {
"Incompatible AggregateReservation VMFamily", if re.MatchString(errorMessage) {
"Could not find the given reservation with the following name",
"must use ReservationAffinity of",
"The reservation must exist in the same project as the instance",
"only compatible with Aggregate Reservations",
}
for _, rErr := range reservationErrors {
if strings.Contains(errorMessage, rErr) {
return true return true
} }
} }