kubernetes
/
autoscaler
mirror of https://github.com/kubernetes/autoscaler.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4184 from MaciekPytel/fix_ut 

Skipping metrics tests added in #4022
This commit is contained in:
Kubernetes Prow Robot 2021-07-08 06:34:54 -07:00 committed by GitHub
parent 7f6f9531d9 52392b3707
commit 389cfd2e18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cluster-autoscaler/metrics/metrics_test.go
View File

@ -24,12 +24,14 @@ import (
) )
func TestDisabledPerNodeGroupMetrics(t *testing.T) { func TestDisabledPerNodeGroupMetrics(t *testing.T) {
t.Skip("Registering metrics multiple times causes panic. Skipping until the test is fixed to not impact other tests.")
RegisterAll(false) RegisterAll(false)
assert.False(t, nodesGroupMinNodes.IsCreated()) assert.False(t, nodesGroupMinNodes.IsCreated())
assert.False(t, nodesGroupMaxNodes.IsCreated()) assert.False(t, nodesGroupMaxNodes.IsCreated())
} }
func TestEnabledPerNodeGroupMetrics(t *testing.T) { func TestEnabledPerNodeGroupMetrics(t *testing.T) {
t.Skip("Registering metrics multiple times causes panic. Skipping until the test is fixed to not impact other tests.")
RegisterAll(true) RegisterAll(true)
assert.True(t, nodesGroupMinNodes.IsCreated()) assert.True(t, nodesGroupMinNodes.IsCreated())
assert.True(t, nodesGroupMaxNodes.IsCreated()) assert.True(t, nodesGroupMaxNodes.IsCreated())