Merge pull request #870 from kgolab/kg-clean-up-012

Set lastScaleDownFailTime properly
This commit is contained in:
Aleksandra Malinowska 2018-05-17 12:09:15 +02:00 committed by GitHub
commit 3b6cfc7c2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions

View File

@ -364,14 +364,12 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) errors.AutoscalerError
result, typedErr := scaleDown.TryToScaleDown(allNodes, allScheduled, pdbs, currentTime)
metrics.UpdateDurationFromStart(metrics.ScaleDown, scaleDownStart)
// TODO: revisit result handling
if typedErr != nil {
glog.Errorf("Failed to scale down: %v", err)
a.lastScaleDownFailTime = currentTime
return typedErr
}
if result == ScaleDownError {
a.lastScaleDownFailTime = currentTime
} else if result == ScaleDownNodeDeleted {
if result == ScaleDownNodeDeleted {
a.lastScaleDownDeleteTime = currentTime
}
}