kubernetes
/
autoscaler
mirror of https://github.com/kubernetes/autoscaler.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #817 from losipiuk/lo/use-sort-slice 

Use less verbose sort.Slice instead sort.Sort
This commit is contained in:
Marcin Wielgus 2018-04-26 18:44:45 +02:00 committed by GitHub
parent a86ea7669a 5344cc637c
commit ad84c46edc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cluster-autoscaler/estimator/binpacking_estimator.go
View File

@ -31,12 +31,6 @@ type podInfo struct {
pod *apiv1.Pod
}
type byScoreDesc []*podInfo
func (a byScoreDesc) Len() int { return len(a) }
func (a byScoreDesc) Swap(i, j int) { a[i], a[j] = a[j], a[i] }
func (a byScoreDesc) Less(i, j int) bool { return a[i].score > a[j].score }
// BinpackingNodeEstimator estimates the number of needed nodes to handle the given amount of pods.
type BinpackingNodeEstimator struct {
predicateChecker *simulator.PredicateChecker
@ -60,7 +54,7 @@ func (estimator *BinpackingNodeEstimator) Estimate(pods []*apiv1.Pod, nodeTempla
comingNodes []*schedulercache.NodeInfo) int {
podInfos := calculatePodScore(pods, nodeTemplate)
sort.Sort(byScoreDesc(podInfos))
sort.Slice(podInfos, func(i, j int) bool { return podInfos[i].score > podInfos[j].score })
// nodeWithPod function returns NodeInfo, which is a copy of nodeInfo argument with an additional pod scheduled on it.
nodeWithPod := func(nodeInfo *schedulercache.NodeInfo, pod *apiv1.Pod) *schedulercache.NodeInfo {