Merge pull request #7453 from gvnc/oci-self-managed-nodes-fix

exclude self-managed nodes from being processed
This commit is contained in:
Kubernetes Prow Robot 2024-11-15 23:32:53 +00:00 committed by GitHub
commit b01bff1640
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions

View File

@ -21,6 +21,7 @@ type OciRef struct {
PrivateIPAddress string
PublicIPAddress string
Shape string
IsNodeSelfManaged bool
}
// NodeToOciRef converts a node object into an oci reference
@ -36,6 +37,7 @@ func NodeToOciRef(n *apiv1.Node) (OciRef, error) {
PrivateIPAddress: getNodeInternalAddress(n),
PublicIPAddress: getNodeExternalAddress(n),
Shape: getNodeShape(n),
IsNodeSelfManaged: n.Labels["oci.oraclecloud.com/node.info.byon"] == "true",
}, nil
}

View File

@ -54,6 +54,10 @@ func (ocp *OciCloudProvider) NodeGroupForNode(n *apiv1.Node) (cloudprovider.Node
return nil, err
}
// self-managed-nodes aren't expected to be managed by cluster-autoscaler
if ociRef.IsNodeSelfManaged {
return nil, nil
}
ng, err := ocp.manager.GetNodePoolForInstance(ociRef)
// this instance may be part of a node pool that the autoscaler does not handle
@ -75,6 +79,9 @@ func (ocp *OciCloudProvider) HasInstance(node *apiv1.Node) (bool, error) {
if err != nil {
return true, err
}
if instance.IsNodeSelfManaged {
return false, nil
}
np, err := ocp.manager.GetNodePoolForInstance(instance)
if err != nil {
return true, err