kubernetes
/
autoscaler
mirror of https://github.com/kubernetes/autoscaler.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add unit test case for OTHER error handling

This commit is contained in:
Łukasz Osipiuk 2019-06-07 16:53:17 +02:00
parent 1b4f1855cb
commit be68d06b40
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
cluster-autoscaler/core/static_autoscaler_test.go
View File

@ -817,7 +817,7 @@ func TestStaticAutoscalerRunOncePodsWithPriorities(t *testing.T) {
podDisruptionBudgetListerMock, daemonSetListerMock, onScaleUpMock, onScaleDownMock) podDisruptionBudgetListerMock, daemonSetListerMock, onScaleUpMock, onScaleDownMock)
} }
func TestStaticAutoscalerOutOfResources(t *testing.T) { func TestStaticAutoscalerInstaceCreationErrors(t *testing.T) {
// setup // setup
provider := &mockprovider.CloudProvider{} provider := &mockprovider.CloudProvider{}
@ -904,6 +904,16 @@ func TestStaticAutoscalerOutOfResources(t *testing.T) {
}, },
}, },
}, },
{
"A6",
&cloudprovider.InstanceStatus{
State: cloudprovider.InstanceCreating,
ErrorInfo: &cloudprovider.InstanceErrorInfo{
ErrorClass: cloudprovider.OtherErrorClass,
ErrorCode: "OTHER",
},
},
},
}, nil).Twice() }, nil).Twice()
nodeGroupB.On("Exist").Return(true) nodeGroupB.On("Exist").Return(true)
@ -944,14 +954,14 @@ func TestStaticAutoscalerOutOfResources(t *testing.T) {
// check delete was called on correct nodes // check delete was called on correct nodes
nodeGroupA.AssertCalled(t, "DeleteNodes", mock.MatchedBy( nodeGroupA.AssertCalled(t, "DeleteNodes", mock.MatchedBy(
func(nodes []*apiv1.Node) bool { func(nodes []*apiv1.Node) bool {
if len(nodes) != 3 { if len(nodes) != 4 {
return false return false
} }
names := make(map[string]bool) names := make(map[string]bool)
for _, node := range nodes { for _, node := range nodes {
names[node.Spec.ProviderID] = true names[node.Spec.ProviderID] = true
} }
return names["A3"] && names["A4"] && names["A5"] return names["A3"] && names["A4"] && names["A5"] && names["A6"]
})) }))
// TODO assert that scaleup was failed (separately for QUOTA and STOCKOUT) // TODO assert that scaleup was failed (separately for QUOTA and STOCKOUT)
@ -968,14 +978,14 @@ func TestStaticAutoscalerOutOfResources(t *testing.T) {
// nodes should be deleted again // nodes should be deleted again
nodeGroupA.AssertCalled(t, "DeleteNodes", mock.MatchedBy( nodeGroupA.AssertCalled(t, "DeleteNodes", mock.MatchedBy(
func(nodes []*apiv1.Node) bool { func(nodes []*apiv1.Node) bool {
if len(nodes) != 3 { if len(nodes) != 4 {
return false return false
} }
names := make(map[string]bool) names := make(map[string]bool)
for _, node := range nodes { for _, node := range nodes {
names[node.Spec.ProviderID] = true names[node.Spec.ProviderID] = true
} }
return names["A3"] && names["A4"] && names["A5"] return names["A3"] && names["A4"] && names["A5"] && names["A6"]
})) }))
// TODO assert that scaleup is not failed again // TODO assert that scaleup is not failed again
@ -1012,6 +1022,12 @@ func TestStaticAutoscalerOutOfResources(t *testing.T) {
State: cloudprovider.InstanceDeleting, State: cloudprovider.InstanceDeleting,
}, },
}, },
{
"A6",
&cloudprovider.InstanceStatus{
State: cloudprovider.InstanceDeleting,
},
},
}, nil) }, nil)
clusterState.RefreshCloudProviderNodeInstancesCache() clusterState.RefreshCloudProviderNodeInstancesCache()