From 0e0f294f72a55f74da7683a45da4205f777829da Mon Sep 17 00:00:00 2001 From: Joachim Bartosik Date: Mon, 4 Sep 2023 10:16:22 +0200 Subject: [PATCH] Fix flag name in documentation It's [`recommender-name`](https://github.com/kubernetes/autoscaler/blob/cd5ed0be530e2313f762e30042cb324b768507f6/vertical-pod-autoscaler/pkg/recommender/main.go#L48C40-L48C56) not `name`. Fixing #5231, see #5451 --- vertical-pod-autoscaler/README.md | 2 +- vertical-pod-autoscaler/deploy/recommender-deployment-high.yaml | 2 +- vertical-pod-autoscaler/deploy/recommender-deployment-low.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/vertical-pod-autoscaler/README.md b/vertical-pod-autoscaler/README.md index f17b21d76e..9225e2f70f 100644 --- a/vertical-pod-autoscaler/README.md +++ b/vertical-pod-autoscaler/README.md @@ -304,7 +304,7 @@ For example you could have 3 profiles: [frugal](deploy/recommender-deployment-lo use different TargetCPUPercentile (50, 90 and 95) to calculate their recommendations. Please note the usage of the following arguments to override default names and percentiles: -- --name=performance +- --recommender-name=performance - --target-cpu-percentile=0.95 You can then choose which recommender to use by setting `recommenders` inside the `VerticalPodAutoscaler` spec. diff --git a/vertical-pod-autoscaler/deploy/recommender-deployment-high.yaml b/vertical-pod-autoscaler/deploy/recommender-deployment-high.yaml index 91f3b90c62..10bdef97bc 100644 --- a/vertical-pod-autoscaler/deploy/recommender-deployment-high.yaml +++ b/vertical-pod-autoscaler/deploy/recommender-deployment-high.yaml @@ -29,7 +29,7 @@ spec: image: registry.k8s.io/autoscaling/vpa-recommender:0.14.0 imagePullPolicy: Always args: - - --name=performance + - --recommender-name=performance - --target-cpu-percentile=0.95 resources: limits: diff --git a/vertical-pod-autoscaler/deploy/recommender-deployment-low.yaml b/vertical-pod-autoscaler/deploy/recommender-deployment-low.yaml index 03c7145dfb..bb7cbcf900 100644 --- a/vertical-pod-autoscaler/deploy/recommender-deployment-low.yaml +++ b/vertical-pod-autoscaler/deploy/recommender-deployment-low.yaml @@ -29,7 +29,7 @@ spec: image: registry.k8s.io/autoscaling/vpa-recommender:0.14.0 imagePullPolicy: Always args: - - --name=frugal + - --recommender-name=frugal - --target-cpu-percentile=0.50 resources: limits: